Content-Type: multipart/mixed;
 boundary=d80ae9ebd25625e0a41bdbecf05911bbac7359cdaeac99141a615d60d8df
Date: Tue, 26 May 2026 09:22:07 +0200
Message-Id: <DISFEF23Y30A.3H6YMBMPYVF8I@jeltef.nl>
Cc: <pgsql-hackers@postgresql.org>, "Robert Haas" <robertmhaas@gmail.com>,
 "Bruce Momjian" <bruce@momjian.us>
Subject: Re: libpq maligning postgres stability
To: "Andres Freund" <andres@anarazel.de>
From: "Jelte Fennema-Nio" <postgres@jeltef.nl>
MIME-Version: 1.0
References: <up7whuxn263agr7whdzzoak7mo7ywryc7z7z3ejdvgbbke4vji@3puckkgm4ide>
In-Reply-To: <up7whuxn263agr7whdzzoak7mo7ywryc7z7z3ejdvgbbke4vji@3puckkgm4ide>
Archived-At: 
 <https://www.postgresql.org/message-id/DISFEF23Y30A.3H6YMBMPYVF8I%40jeltef.nl>
Precedence: bulk

--d80ae9ebd25625e0a41bdbecf05911bbac7359cdaeac99141a615d60d8df
Content-Type: multipart/alternative;
 boundary=16ae5f6066639e8fd520fb8e78ebf4e54677fb0f7f7a4e2bdb29f5d7b4c1

--16ae5f6066639e8fd520fb8e78ebf4e54677fb0f7f7a4e2bdb29f5d7b4c1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8; format=Flowed

On Thu, 27 Mar 2025 at 16:19, Andres Freund <andres@anarazel.de> wrote:
> And we don't even just add this message when the connection was actually
> closed unexpectedly, we often do it even when we *did* get a FATAL, as in=
 this
> example:
>
> psql -c 'select pg_terminate_backend(pg_backend_pid())'
> FATAL:  57P01: terminating connection due to administrator command
> LOCATION:  ProcessInterrupts, postgres.c:3351
> server closed the connection unexpectedly
>         This probably means the server terminated abnormally
>         before or while processing the request.
> connection to server was lost
>
>
> I think this one is mostly a weakness in how libpq tracks connection stat=
e,
> but it kind of shows the silliness of claiming postgres probably crashed.

I ran into this for the nth time (this time while trying to have psql
handle certain FATAL errors differently). Turns out fixing this is
actually really simple. All that's needed is to mark a connection as
CONNECTION_BAD whenever a FATAL or PANIC error is received by the
client.

(this change is intended for PG20)

--16ae5f6066639e8fd520fb8e78ebf4e54677fb0f7f7a4e2bdb29f5d7b4c1--

--d80ae9ebd25625e0a41bdbecf05911bbac7359cdaeac99141a615d60d8df
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=v1-0001-libpq-Consider-a-connection-with-a-FATAL-error-to.patch
Content-Type: text/x-patch; charset=utf-8;
 name=v1-0001-libpq-Consider-a-connection-with-a-FATAL-error-to.patch

RnJvbSBhMjk5ZTdjNzc3OTMzMWRiYzA5ZDJjOGJmYzU5MjMxNTNlMTU3NjNhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWx0ZSBGZW5uZW1hLU5pbyA8cG9zdGdyZXNAamVsdGVmLm5s
PgpEYXRlOiBUdWUsIDI2IE1heSAyMDI2IDA5OjA1OjU2ICswMjAwClN1YmplY3Q6IFtQQVRDSCB2
MV0gbGlicHE6IENvbnNpZGVyIGEgY29ubmVjdGlvbiB3aXRoIGEgRkFUQUwgZXJyb3IgdG8gYmUK
IGNsb3NlZAoKVGhpcyBzdGFydHMgbWFya2luZyBhIGNvbm5lY3Rpb24gYXMgY2xvc2VkIChpLmUu
IENPTk5FQ1RJT05fQkFEKSB3aGVuCnRoZSBjbGllbnQgcmVjZWl2ZXMgYSBGQVRBTC9QQU5JQyBl
cnJvci4gUHJldmlvdXNseSBhbnkgRkFUQUwgZXJyb3Igd291bGQgZ2V0IHRoZQp0aGUgInNlcnZl
ciBjbG9zZWQgdGhlIGNvbm5lY3Rpb24gdW5leHBlY3RlZGx5IiBzdHJpbmcgYXBwZW5kZWQgbGlr
ZSBzdWNoOgoKRkFUQUw6ICA1N1AwMTogdGVybWluYXRpbmcgY29ubmVjdGlvbiBkdWUgdG8gYWRt
aW5pc3RyYXRvciBjb21tYW5kCkxPQ0FUSU9OOiAgUHJvY2Vzc0ludGVycnVwdHMsIHBvc3RncmVz
LmM6MzQzMQpzZXJ2ZXIgY2xvc2VkIHRoZSBjb25uZWN0aW9uIHVuZXhwZWN0ZWRseQogICAgVGhp
cyBwcm9iYWJseSBtZWFucyB0aGUgc2VydmVyIHRlcm1pbmF0ZWQgYWJub3JtYWxseQogICAgYmVm
b3JlIG9yIHdoaWxlIHByb2Nlc3NpbmcgdGhlIHJlcXVlc3QuCgpUaGlzIGFkZGl0aW9uIHRvIHRo
ZSBlcnJvciBpcyBqdXN0IHBsYWluIGluY29ycmVjdCwgdGhlIHNlcnZlciB0b2xkIHRoZQpjbGll
bnQgdGhhdCBpdCB3YXMgY2xvc2luZyB0aGUgY29ubmVjdGlvbi4gU28gaXQncyBub3QgdW5leHBl
Y3RlZCwgbm9yCmRpZCB0aGUgc2VydmVyIHRlcm1pbmF0ZSBhYm5vcm1hbGx5LiBJdCBhbHNvIG1h
a2VzIHRoZSBlcnJvciBoYXJkZXIgdG8KcGFyc2UgYnkgYSBjbGllbnQsIGJlY2F1c2UgaXQgd291
bGQgbG9zZSB0aGUgYWJpbGl0eSB0byB1c2UKUFFyZXN1bHRFcnJvckZpZWxkIG9uIHRoZSBmaW5h
bCBQR3Jlc3VsdC4KLS0tCiBzcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1wcm90b2NvbDMuYyB8IDE5
ICsrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspCgpk
aWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvbGlicHEvZmUtcHJvdG9jb2wzLmMgYi9zcmMvaW50
ZXJmYWNlcy9saWJwcS9mZS1wcm90b2NvbDMuYwppbmRleCA4NDBlMDE4Y2QxOC4uNTA0ZTg1OTIx
OTYgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLXByb3RvY29sMy5jCisrKyBi
L3NyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLXByb3RvY29sMy5jCkBAIC05NTUsNiArOTU1LDI1IEBA
IHBxR2V0RXJyb3JOb3RpY2UzKFBHY29ubiAqY29ubiwgYm9vbCBpc0Vycm9yKQogCQkJCQlzaXpl
b2YoY29ubi0+bGFzdF9zcWxzdGF0ZSkpOwogCQllbHNlIGlmIChpZCA9PSBQR19ESUFHX1NUQVRF
TUVOVF9QT1NJVElPTikKIAkJCWhhdmVfcG9zaXRpb24gPSB0cnVlOworCQllbHNlIGlmIChpc0Vy
cm9yICYmIGlkID09IFBHX0RJQUdfU0VWRVJJVFlfTk9OTE9DQUxJWkVEICYmCisJCQkJIChzdHJj
bXAod29ya0J1Zi5kYXRhLCAiRkFUQUwiKSA9PSAwIHx8CisJCQkJICBzdHJjbXAod29ya0J1Zi5k
YXRhLCAiUEFOSUMiKSA9PSAwKSkKKwkJeworCQkJLyoKKwkJCSAqIEEgRkFUQUwgb3IgUEFOSUMg
ZnJvbSB0aGUgc2VydmVyIG1lYW5zIHRoZSBiYWNrZW5kIGlzIGdvaW5nIHRvCisJCQkgKiB0ZWFy
IHRoZSBjb25uZWN0aW9uIGRvd24gcmlnaHQgYWZ0ZXIgZGVsaXZlcmluZyB0aGlzIG1lc3NhZ2Uu
CisJCQkgKiBNYXJrIHRoZSBjb25uZWN0aW9uIGJhZCBpbW1lZGlhdGVseSBzbyBjYWxsZXJzIHRo
YXQgZHJhaW4KKwkJCSAqIHJlc3VsdHMgKFBRZXhlY0ZpbmlzaCwgUFFleGVjU3RhcnQncyBkaXNj
YXJkIGxvb3AsIGV0Yy4pIHN0b3AKKwkJCSAqIHJlYWRpbmcgZnJvbSB0aGUgc29ja2V0IGFmdGVy
IHJlY2VpdmluZyB0aGlzIHJlc3VsdC4gRnVydGhlcgorCQkJICogcmVhZHMgZnJvbSB0aGUgc29j
a2V0IHdpbGwgcmVjZWl2ZSBhbiBFT0YsIHdoaWNoIHdvdWxkIGNhdXNlIHVzCisJCQkgKiB0byBp
bmNvcnJlY3RseSByZXBvcnQgdGhpcyBhcyBhbiB1bmV4cGVjdGVkIGNvbm5lY3Rpb24gY2xvc3Vy
ZQorCQkJICogYnkgYXBwZW5kaW5nICJzZXJ2ZXIgY2xvc2VkIHRoZSBjb25uZWN0aW9uIHVuZXhw
ZWN0ZWRseSAuLi4iIHRvCisJCQkgKiB0aGUgc2VydmVyJ3Mgb3duIGVycm9yIG1lc3NhZ2UuIFdl
IHJlYWQgU0VWRVJJVFlfTk9OTE9DQUxJWkVECisJCQkgKiByYXRoZXIgdGhhbiBTRVZFUklUWSBz
byB0aGUgY2hlY2sgaXMgaW5kZXBlbmRlbnQgb2YgdGhlCisJCQkgKiBzZXJ2ZXIncyBsY19tZXNz
YWdlcyBzZXR0aW5nLgorCQkJICovCisJCQljb25uLT5zdGF0dXMgPSBDT05ORUNUSU9OX0JBRDsK
KwkJfQogCX0KIAogCS8qCgpiYXNlLWNvbW1pdDogMmM0YmQyYmY1NzAwZGI5OGJlMDYwMjg1NGE4
YjdmYTJjMTZiNWY0YQotLSAKMi41NC4wCgo=
--d80ae9ebd25625e0a41bdbecf05911bbac7359cdaeac99141a615d60d8df--