Feedback-ID: idd01497b:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 05 Jun 2026 21:04:34 +0000
Message-Id: <DJ1F5L6XMENK.ABIOKCQQQ0FZ@partin.io>
To: "Mark Wong" <markwkm@gmail.com>
From: "Tristan Partin" <tristan@partin.io>
Cc: <pgsql-hackers@lists.postgresql.org>
Subject: Re: updates for handling optional argument in system functions
References: <aTiwu9o8vBkLreAL@ltdrgnflg2> <ac63G6p1LAdbsca0@ltdrgnflg2>
 <6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se>
 <adWWX4jFbxib8oQ1@ltdrgnflg2>
 <b6808c92-9531-4772-aeba-f60535d68b72@proxel.se>
 <adaaL5VD9bfipZQI@ltdrgnflg2> <aiMuFBFYLAWQC_5Z@ltdrgnflg2>
In-Reply-To: <aiMuFBFYLAWQC_5Z@ltdrgnflg2>
Archived-At: 
 <https://www.postgresql.org/message-id/DJ1F5L6XMENK.ABIOKCQQQ0FZ%40partin.io>
Precedence: bulk

> Patch 1
>
> -  proargtypes =3D> 'oid bool', prosrc =3D> 'pg_get_ruledef_ext' },
> +  proargtypes =3D> 'oid bool', proargnames =3D> '{rule,pretty}',
> +  proargdefaults =3D> '{false}',prosrc =3D> 'pg_get_ruledef' },

There is a space missing before prosrc in the added line.

Other than that one comment, this looks good to me.

I am a little confused how proargdefaults works given the function takes=20
two arguments, but you only defined one default, so how does the parser=20
know that the false default is in reference to "pretty". I do see there=20
is other precedent for this pattern, so it is correct.

--=20
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)