Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1waFwa-001duy-0L for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jun 2026 16:50:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1waFwY-00CnPk-1s for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jun 2026 16:50:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1waFwY-00CnOX-03 for pgsql-hackers@lists.postgresql.org; Thu, 18 Jun 2026 16:50:18 +0000 Received: from fout-b3-smtp.messagingengine.com ([202.12.124.146]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1waFwW-000000010Ii-1IAQ for pgsql-hackers@lists.postgresql.org; Thu, 18 Jun 2026 16:50:17 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id A98571D000FD; Thu, 18 Jun 2026 12:50:14 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-05.internal (MEProxy); Thu, 18 Jun 2026 12:50:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=partin.io; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1781801414; x=1781887814; bh=Jml+PY49eaMUJxG9YIf+yL/R/PQyIz/dVjZjG0G2nS4=; b= SX9MyGdIuDGreKlvX6vTGe+jbCRP71BDKnEZpPos0m8KQKn838REuw5GqlsbZrYY G41sgi8BX8R5312vWgV7VAWXgaP96OQ1LcbTkywElMtKTSmdW5+sBqnv8776oxBO EF0uhqN/E7Y6ip+X24OB5wuncUD2s8WKna/lIRS8yQmhDYhZP00ddNrYUIjryhzt v+i++p6ocXA8cz6txakiAID6BVeD4u2JDfn/7elnXtTWHev8UG0GJVT9jWqisjWL +e0vt0VKMwEG/vwIQpTXicrHx2X0HRtSY15v2TIok913MW2mYluTseS4JfQMuSX5 b0c5eN4QLMoStuiZ8mTGLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1781801414; x= 1781887814; bh=Jml+PY49eaMUJxG9YIf+yL/R/PQyIz/dVjZjG0G2nS4=; b=d l4a2LfKyRSircjtyGNM+f9MFsU89TOVw9J/KpAT44LHpn07bh5GueM4/l/iT5h2V ULqurlF011Lf49eftLbH0Wwy87ZdHw4jguJmL5ZDCe4XRujY3cK41KULufFBiauY FfVAneVETdYfN1u+t/V5e9jlWoSxaf7kCxpdte9NuwlQuYaRfZazStgYRpOn9AsK 07DO44IsFoq6dCIAO0YYmHIonSVVj93FzYTUkPO7EcDad4uBP58/7y0CsxQzT4oJ CuApEOj+dbyhW4dsSvcjVyy31m9p5jm2mSx8r0S0Scp++8CvLjDhyGYjsIHJ1CdX 3lmKBSvcodI5x+1U3AAZQ== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFkBYnb/pNyNGEtSgh97blcqDmy90XLrke55qVoqOQwDlSpk/IIzb/qdiaHZUzL77 onuWpyO5yzgQ5f03ta1b51/RZoPBykSc4EpwiOY8VKhKokIeQY+KtjMbkclif4/sLq2Her DhqAMd3Q+mjvLcK9Zg7zugCan+Zy8aJJ4zuFLjPPSRd+E//j5ieTLNjY2WO3oFgcNTtkor nzw50Ly0/SY9XvLRRnXWJck53HwbYdu1ovTPRBqdHuCkI1fQP9xEAwPfjYbB726bs9Ti7U 9JtIPItwqSPoQ5/DmoTx5SR4WZR/GGJRcFiXPTjK3ntKouLXBS8uqwJLcgeLghgXsbeKhM kwa88gupu6SkyRnUW4ZLac/xISaN9y5LEAyiObbLGZCY/w9wbcIOVz7g08yd5UzDQdJ38E xp0w8vQ+LBsC2KQ5j/+Ra1zBEwFhnZYOyPRMuDYMkcYbMz5MUMXV1Taeq4GZ4gpnj5hfoq 3mPL4bugV5Ryh9KVB0DhBVlmA3qnN7+6OZE6JO7y5p4SvVS4mzwaNh0ozkpdcYHxXzUu0M uAoHH4Psc1iP5kPeM620EjR22L7ei+4hhRMUVD4JXK+tF1ULej7+2yCRAOMDrpNDf6ZlyS xr+bdyYKCA5JCaxHxxphm+dCJcMq8lXaJXGTE/C2isSc6kRZ+79nutpZgMjg X-ME-Proxy: Feedback-ID: idd01497b:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 1FD27780259; Thu, 18 Jun 2026 12:50:14 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Jun 2026 16:50:13 +0000 Message-Id: To: "Mark Wong" From: "Tristan Partin" Cc: Subject: Re: updates for handling optional argument in system functions X-Mailer: aerc 0.21.0 References: <6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu Jun 11, 2026 at 2:47 PM UTC, Mark Wong wrote: > On Fri, Jun 05, 2026 at 09:04:34PM +0000, Tristan Partin wrote: >> > Patch 1 >> > >> > - proargtypes =3D> 'oid bool', prosrc =3D> 'pg_get_ruledef_ext' }, >> > + proargtypes =3D> 'oid bool', proargnames =3D> '{rule,pretty}', >> > + proargdefaults =3D> '{false}',prosrc =3D> 'pg_get_ruledef' }, >>=20 >> There is a space missing before prosrc in the added line. >>=20 >> Other than that one comment, this looks good to me. > > Oops, v8.1 attached to correct that white space. Patches look great Mark! --=20 Tristan Partin PostgreSQL Contributors Team AWS (https://aws.amazon.com)