Feedback-ID: idd01497b:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 19 Jun 2026 16:38:27 +0000
Message-Id: <DJD69GFRSZ8G.27K1856EEDBF0@partin.io>
Cc: "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix publisher-side sequence permission reporting
To: "Fujii Masao" <masao.fujii@gmail.com>
From: "Tristan Partin" <tristan@partin.io>
References: 
 <CAHGQGwGNTaXnBKUV510_P1KwhdbHT+kgZ4zU5njBHy7nCqdhzg@mail.gmail.com>
 <DJCK033ELDM0.24V36DWNB6XH@partin.io>
 <CAHGQGwE95GLD7RZr2g=zTHKJRafKACmKouhb4TTVH155Hy8zKA@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwE95GLD7RZr2g=zTHKJRafKACmKouhb4TTVH155Hy8zKA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DJD69GFRSZ8G.27K1856EEDBF0%40partin.io>
Precedence: bulk

On Fri Jun 19, 2026 at 9:16 AM CDT, Fujii Masao wrote:
> On Fri, Jun 19, 2026 at 8:11=E2=80=AFAM Tristan Partin <tristan@partin.io=
> wrote:
>> The patch looks good to me! I had one suggestion:
>>
>> >  ##########
>> >  # Ensure that insufficient privileges on the publisher for a sequence=
 do not
>> > -# disrupt the subscriber. The subscriber should log a warning and con=
tinue
>> > -# retrying.
>> > +# get misreported as a missing sequence. The subscriber should log a =
warning
>> > +# and continue retrying.
>> >  ##########
>>
>> I think a better comment might be:
>>
>>         Ensure that insufficient privileges on the publisher for a seque=
nce
>>         are reported correctly...
>>
>> My reasoning for suggesting that is because your comment would to
>> indicate that any warning is accurate as long as it isn't related to
>> a missing sequence.
>
> Thanks for the review! I've updated the patch as suggested.
>
> Updated patches attached.

Looks great! Thanks for fixing this.

--=20
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)