Date: Fri, 3 Jul 2026 08:42:18 +0200
From: Alberto Piai <alberto.piai@gmail.com>
To: Alberto Piai <alberto.piai@gmail.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>, pgsql-hackers@postgresql.org
Cc: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
Subject: Re: Adding a stored generated column without long-lived locks
Message-ID: <DJOPT622HYJK.3JRH1VQCV5CDL@gmail.com>
References: <abkrpUwlGngF4e-d@phidippus.sen.work>
 <DHMSK551GIM8.1B1CN2JN8BK50@gmail.com>
 <DI19FP3X4VI0.21FO6V1HGJK5P@gmail.com>
 <DIIRFCWJIA80.2Q5DYIX6C7KZ5@gmail.com>
 <DITN90YX3328.2A0I3LCV164BA@gmail.com>
 <3af338791e8ab27c4a7efbc4217c97162de76bc8.camel@cybertec.at>
 <DJMFASI8OYBS.2JBMQ7KZ2XOTO@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="vszqhseuea6ckzmb"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <DJMFASI8OYBS.2JBMQ7KZ2XOTO@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DJOPT622HYJK.3JRH1VQCV5CDL%40gmail.com>
Precedence: bulk


--vszqhseuea6ckzmb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

v5 had a rather brittle test that was relying on a DEBUG message being
emitted when phase 3 verifies or rewrites a table (via
client_min_messages). That was failing on the CI because the output
depends on any other setting that might affect logging (in this case it
was log_statement).

The attached v6 replaces it with an injection_point test. If adding new
injection points to detect scans/rewrites is considered too much, I can
back it out and set/reset log_statement too. But I do prefer the
injection_point test.

If the new injection point is good, there are also a couple more tests
which might be updated to use it.


Regards,

Alberto

-- 
Alberto Piai
Sensational AG
Zürich, Switzerland

--vszqhseuea6ckzmb
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="v6-0001-Support-changing-a-column-into-a-stored-generated.patch"