public inbox for [email protected]
help / color / mirror / Atom feedFrom: Shinoda, Noriyoshi (PN Japan FSIP) <[email protected]>
To: David Rowley <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: [16Beta1][doc] pgstat: Track time of the last scan of a relation
Date: Thu, 1 Jun 2023 09:38:18 +0000
Message-ID: <DM4PR84MB1734F413279B051DA0599E64EE499@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAApHDvr2WOUdnvJemheTXtONC6KdWrBwSxLCN8b687+vLFbKyQ@mail.gmail.com>
References: <DM4PR84MB17348EA11FA90A9BE896AF89EE489@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
<CAApHDvr2WOUdnvJemheTXtONC6KdWrBwSxLCN8b687+vLFbKyQ@mail.gmail.com>
Hi, Thanks for your comment.
As you say, it would be difficult to unify the data types in all documents right now.
The patch I attached the other day unifies only the newly added columns in monitoring.sgml to "timestamp with time zone".
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: David Rowley <[email protected]>
Sent: Wednesday, May 31, 2023 3:14 PM
To: Shinoda, Noriyoshi (PN Japan FSIP) <[email protected]>
Cc: PostgreSQL-development <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [16Beta1][doc] pgstat: Track time of the last scan of a relation
On Wed, 31 May 2023 at 15:57, Shinoda, Noriyoshi (PN Japan FSIP) <[email protected]> wrote:
> According to the documentation [2], the data type of the columns added to these views is 'timestamptz'.
> However, columns of the same data type in pg_stat_all_tables.last_vacuum, last_analyze and other tables are unified to 'timestamp with time zone'. The attached patch changes the data type of the added column from timestamptz to timestamp with time zone.
I agree that it would be good to make those consistently use timestamp with time zone for all columns of that type in the docs for pg_stat_all_tables.
More generally, it might be good if we did it for the entire docs:
doc $ git grep "<type>timestamptz</type>" | wc -l
17
doc $ git grep "<type>timestamp with time zone</type>" | wc -l
74
Clearly "timestamp with time zone" is much more commonly used.
The bar is probably set a bit higher for changing the longer-established ones, however.
David
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: [16Beta1][doc] pgstat: Track time of the last scan of a relation
In-Reply-To: <DM4PR84MB1734F413279B051DA0599E64EE499@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox