Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlaHa-0006QW-AI for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Nov 2021 17:24:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mlaHX-0000wk-Ht for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Nov 2021 17:24:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlaHX-0000wa-4w for pgsql-hackers@lists.postgresql.org; Fri, 12 Nov 2021 17:24:07 +0000 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlaHS-0004Hf-8o for pgsql-hackers@lists.postgresql.org; Fri, 12 Nov 2021 17:24:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1636737842; x=1668273842; h=from:to:cc:date:message-id:references:in-reply-to: mime-version:subject; bh=+kBQCiEZMZFuTWQlg1x29ZZ9KAp+SpI3VshR1JXSYR8=; b=A+9zM3bA3LucYlUkHxPANm08izAtJDwJM+m0KXVx23XQObFyDBd/RO6P vyH//KaJdS3tDh79mToZ45De2+lqvNR9kghRoGgCVSAnC+EFY5bZ/kD0H CnJ1e3byNR+KJ0GJ0rB7Dzx/hjOakS+8f1BQLI8vemJahBrU2UANE/geQ c=; X-Amazon-filename: v2-0001-Adjust-password-to-use-current-user-instead-of-au.patch, v2-0002-Add-role-name-to-password-prompt.patch X-IronPort-AV: E=Sophos;i="5.87,230,1631577600"; d="scan'208,223";a="154724704" Subject: Re: Improving psql's \password command Thread-Topic: Improving psql's \password command Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-0168675e.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 12 Nov 2021 17:24:00 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-0168675e.us-east-1.amazon.com (Postfix) with ESMTPS id C73D5A26A7; Fri, 12 Nov 2021 17:23:59 +0000 (UTC) Received: from EX13D03UWC004.ant.amazon.com (10.43.162.49) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Fri, 12 Nov 2021 17:23:59 +0000 Received: from EX13D03UWC004.ant.amazon.com (10.43.162.49) by EX13D03UWC004.ant.amazon.com (10.43.162.49) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Fri, 12 Nov 2021 17:23:58 +0000 Received: from EX13D03UWC004.ant.amazon.com ([10.43.162.49]) by EX13D03UWC004.ant.amazon.com ([10.43.162.49]) with mapi id 15.00.1497.026; Fri, 12 Nov 2021 17:23:58 +0000 From: "Bossart, Nathan" To: Tom Lane CC: "pgsql-hackers@lists.postgresql.org" Thread-Index: AQHXzP3B9iQCNkm0LUi0LT7YHsPMsavp/IGAgACtnwCAE2FDgIAAiE2AgAEgXoA= Date: Fri, 12 Nov 2021 17:23:58 +0000 Message-ID: References: <747443.1635536754@sss.pgh.pa.us> <765509.1635552418@sss.pgh.pa.us> <7BAC8A28-148B-4B03-A345-D68071388300@amazon.com> <1553329.1636647111@sss.pgh.pa.us> In-Reply-To: <1553329.1636647111@sss.pgh.pa.us> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.161.6] Content-Type: multipart/mixed; boundary="_003_E0C46CDF46B24388B53B96EB2CA0F71Eamazoncom_" MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_003_E0C46CDF46B24388B53B96EB2CA0F71Eamazoncom_ Content-Type: text/plain; charset="utf-8" Content-ID: <83EB6BB25C5C7F4F9C3DAFECE63CC495@amazon.com> Content-Transfer-Encoding: base64 T24gMTEvMTEvMjEsIDg6MTIgQU0sICJUb20gTGFuZSIgPHRnbEBzc3MucGdoLnBhLnVzPiB3cm90 ZToNCj4gSXQgc2VlbXMgdG8gbWUgaXQnZCBvdmVyY29tcGxpY2F0ZSBzaW1wbGVfcHJvbXB0J3Mg QVBJIGZvciBvbmUgdXNlLWNhc2UNCj4gLi4uIGJ1dCBpZiB5b3Ugd2FudCB0byB0cnkgaXQsIHN0 ZXAgcmlnaHQgdXAuICAoSSBzdXBwb3NlIHNvbWUgb2YgdGhhdA0KPiBvYmplY3Rpb24gY291bGQg YmUgb3ZlcmNvbWUgYnkgbWFraW5nIHNpbXBsZV9wcm9tcHQgaW50byBhIHdyYXBwZXINCj4gYXJv dW5kIGFub3RoZXIgZnVuY3Rpb24gbm90X3NvX3NpbXBsZV9wcm9tcHQuKQ0KDQpJIGhhdmVuJ3Qg c3RhcnRlZCBvbiB0aGUgU0lHSU5UIHN0dWZmIHlldCwgYnV0IEkgZGlkIGV4dHJhY3QgdGhlDQpQ UXVzZXIoKSBmaXggc28gdGhhdCB3ZSBjYW4gaG9wZWZ1bGx5IGdldCB0aGF0IG9uZSBvdXQgb2Yg dGhlIHdheS4gIEkNCm1hZGUgc29tZSBzbWFsbCBhZGp1c3RtZW50cyBpbiBhbiBhdHRlbXB0IHRv IGtlZXAgdGhlIGJyYW5jaGluZyBpbg0KdGhpcyBmdW5jdGlvbiBmcm9tIGdldHRpbmcgdG9vIGNv bXBsaWNhdGVkLg0KDQpOYXRoYW4NCg0K --_003_E0C46CDF46B24388B53B96EB2CA0F71Eamazoncom_ Content-Type: application/octet-stream; name="v2-0001-Adjust-password-to-use-current-user-instead-of-au.patch" Content-Description: v2-0001-Adjust-password-to-use-current-user-instead-of-au.patch Content-Disposition: attachment; filename="v2-0001-Adjust-password-to-use-current-user-instead-of-au.patch"; size=1753; creation-date="Fri, 12 Nov 2021 17:23:58 GMT"; modification-date="Fri, 12 Nov 2021 17:23:58 GMT" Content-ID: <0A400EDE607AC34A83C503FB9D854099@amazon.com> Content-Transfer-Encoding: base64 RnJvbSAwMjQ1OWJiZDEwN2Q3YmYwNGU5NzE4NGEwMGQ4MjNjODYwNjg4YTUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW4gQm9zc2FydCA8Ym9zc2FydG5AYW1hem9uLmNvbT4K RGF0ZTogRnJpLCAxMiBOb3YgMjAyMSAxNjo1NzozNiArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjIg MS8yXSBBZGp1c3QgXHBhc3N3b3JkIHRvIHVzZSBjdXJyZW50IHVzZXIgaW5zdGVhZCBvZgogYXV0 aGVudGljYXRlZCB1c2VyIGJ5IGRlZmF1bHQuCgotLS0KIHNyYy9iaW4vcHNxbC9jb21tYW5kLmMg fCAyNSArKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0 aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmluL3BzcWwvY29tbWFu ZC5jIGIvc3JjL2Jpbi9wc3FsL2NvbW1hbmQuYwppbmRleCA0OWQ0YzBlM2NlLi41NjE5ZWQ2ODVh IDEwMDY0NAotLS0gYS9zcmMvYmluL3BzcWwvY29tbWFuZC5jCisrKyBiL3NyYy9iaW4vcHNxbC9j b21tYW5kLmMKQEAgLTIwMjMsMTEgKzIwMjMsMjQgQEAgZXhlY19jb21tYW5kX3Bhc3N3b3JkKFBz cWxTY2FuU3RhdGUgc2Nhbl9zdGF0ZSwgYm9vbCBhY3RpdmVfYnJhbmNoKQogCiAJaWYgKGFjdGl2 ZV9icmFuY2gpCiAJewotCQljaGFyCSAgICpvcHQwID0gcHNxbF9zY2FuX3NsYXNoX29wdGlvbihz Y2FuX3N0YXRlLAorCQljaGFyCSAgICp1c2VyID0gcHNxbF9zY2FuX3NsYXNoX29wdGlvbihzY2Fu X3N0YXRlLAogCQkJCQkJCQkJCQkJICBPVF9TUUxJRCwgTlVMTCwgdHJ1ZSk7CiAJCWNoYXIJICAg KnB3MTsKIAkJY2hhcgkgICAqcHcyOwogCisJCWlmICh1c2VyID09IE5VTEwpCisJCXsKKwkJCS8q IEZldGNoIGN1cnJlbnQgdXNlciBzbyB3ZSBjYW4gcmVwb3J0IHdob3NlIFBXIHdpbGwgYmUgY2hh bmdlZCAqLworCQkJUEdyZXN1bHQgICAqcmVzOworCisJCQlyZXMgPSBQU1FMZXhlYygiU0VMRUNU IENVUlJFTlRfVVNFUiIpOworCQkJaWYgKCFyZXMpCisJCQkJcmV0dXJuIFBTUUxfQ01EX0VSUk9S OworCisJCQl1c2VyID0gcGdfc3RyZHVwKFBRZ2V0dmFsdWUocmVzLCAwLCAwKSk7CisJCQlQUWNs ZWFyKHJlcyk7CisJCX0KKwogCQlwdzEgPSBzaW1wbGVfcHJvbXB0KCJFbnRlciBuZXcgcGFzc3dv cmQ6ICIsIGZhbHNlKTsKIAkJcHcyID0gc2ltcGxlX3Byb21wdCgiRW50ZXIgaXQgYWdhaW46ICIs IGZhbHNlKTsKIApAQCAtMjAzOCwxNCArMjA1MSw4IEBAIGV4ZWNfY29tbWFuZF9wYXNzd29yZChQ c3FsU2NhblN0YXRlIHNjYW5fc3RhdGUsIGJvb2wgYWN0aXZlX2JyYW5jaCkKIAkJfQogCQllbHNl CiAJCXsKLQkJCWNoYXIJICAgKnVzZXI7CiAJCQljaGFyCSAgICplbmNyeXB0ZWRfcGFzc3dvcmQ7 CiAKLQkJCWlmIChvcHQwKQotCQkJCXVzZXIgPSBvcHQwOwotCQkJZWxzZQotCQkJCXVzZXIgPSBQ UXVzZXIocHNldC5kYik7Ci0KIAkJCWVuY3J5cHRlZF9wYXNzd29yZCA9IFBRZW5jcnlwdFBhc3N3 b3JkQ29ubihwc2V0LmRiLCBwdzEsIHVzZXIsIE5VTEwpOwogCiAJCQlpZiAoIWVuY3J5cHRlZF9w YXNzd29yZCkKQEAgLTIwNzIsOCArMjA3OSw4IEBAIGV4ZWNfY29tbWFuZF9wYXNzd29yZChQc3Fs U2NhblN0YXRlIHNjYW5fc3RhdGUsIGJvb2wgYWN0aXZlX2JyYW5jaCkKIAkJCX0KIAkJfQogCi0J CWlmIChvcHQwKQotCQkJZnJlZShvcHQwKTsKKwkJaWYgKHVzZXIpCisJCQlmcmVlKHVzZXIpOwog CQlmcmVlKHB3MSk7CiAJCWZyZWUocHcyKTsKIAl9Ci0tIAoyLjE2LjYKCg== --_003_E0C46CDF46B24388B53B96EB2CA0F71Eamazoncom_ Content-Type: application/octet-stream; name="v2-0002-Add-role-name-to-password-prompt.patch" Content-Description: v2-0002-Add-role-name-to-password-prompt.patch Content-Disposition: attachment; filename="v2-0002-Add-role-name-to-password-prompt.patch"; size=1739; creation-date="Fri, 12 Nov 2021 17:23:58 GMT"; modification-date="Fri, 12 Nov 2021 17:23:58 GMT" Content-ID: Content-Transfer-Encoding: base64 RnJvbSAwZjkyYjdiMWQ5OTJjNjE3NGI0OTM1OGYzMzdkODRiYTcxOWI5NTc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW4gQm9zc2FydCA8Ym9zc2FydG5AYW1hem9uLmNvbT4K RGF0ZTogRnJpLCAxMiBOb3YgMjAyMSAxNzoxMDo1MSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjIg Mi8yXSBBZGQgcm9sZSBuYW1lIHRvIFxwYXNzd29yZCBwcm9tcHQuCgotLS0KIHNyYy9iaW4vcHNx bC9jb21tYW5kLmMgfCAxMCArKysrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC9jb21tYW5kLmMg Yi9zcmMvYmluL3BzcWwvY29tbWFuZC5jCmluZGV4IDU2MTllZDY4NWEuLmVlZGM2MjQzZDMgMTAw NjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC9jb21tYW5kLmMKKysrIGIvc3JjL2Jpbi9wc3FsL2NvbW1h bmQuYwpAQCAtMjAyNyw2ICsyMDI3LDcgQEAgZXhlY19jb21tYW5kX3Bhc3N3b3JkKFBzcWxTY2Fu U3RhdGUgc2Nhbl9zdGF0ZSwgYm9vbCBhY3RpdmVfYnJhbmNoKQogCQkJCQkJCQkJCQkJICBPVF9T UUxJRCwgTlVMTCwgdHJ1ZSk7CiAJCWNoYXIJICAgKnB3MTsKIAkJY2hhcgkgICAqcHcyOworCQlQ UUV4cEJ1ZmZlckRhdGEgYnVmOwogCiAJCWlmICh1c2VyID09IE5VTEwpCiAJCXsKQEAgLTIwNDEs NyArMjA0MiwxMCBAQCBleGVjX2NvbW1hbmRfcGFzc3dvcmQoUHNxbFNjYW5TdGF0ZSBzY2FuX3N0 YXRlLCBib29sIGFjdGl2ZV9icmFuY2gpCiAJCQlQUWNsZWFyKHJlcyk7CiAJCX0KIAotCQlwdzEg PSBzaW1wbGVfcHJvbXB0KCJFbnRlciBuZXcgcGFzc3dvcmQ6ICIsIGZhbHNlKTsKKwkJaW5pdFBR RXhwQnVmZmVyKCZidWYpOworCQlwcmludGZQUUV4cEJ1ZmZlcigmYnVmLCBfKCJFbnRlciBuZXcg cGFzc3dvcmQgZm9yIHVzZXIgXCIlc1wiOiAiKSwgdXNlcik7CisKKwkJcHcxID0gc2ltcGxlX3By b21wdChidWYuZGF0YSwgZmFsc2UpOwogCQlwdzIgPSBzaW1wbGVfcHJvbXB0KCJFbnRlciBpdCBh Z2FpbjogIiwgZmFsc2UpOwogCiAJCWlmIChzdHJjbXAocHcxLCBwdzIpICE9IDApCkBAIC0yMDYy LDE1ICsyMDY2LDEyIEBAIGV4ZWNfY29tbWFuZF9wYXNzd29yZChQc3FsU2NhblN0YXRlIHNjYW5f c3RhdGUsIGJvb2wgYWN0aXZlX2JyYW5jaCkKIAkJCX0KIAkJCWVsc2UKIAkJCXsKLQkJCQlQUUV4 cEJ1ZmZlckRhdGEgYnVmOwogCQkJCVBHcmVzdWx0ICAgKnJlczsKIAotCQkJCWluaXRQUUV4cEJ1 ZmZlcigmYnVmKTsKIAkJCQlwcmludGZQUUV4cEJ1ZmZlcigmYnVmLCAiQUxURVIgVVNFUiAlcyBQ QVNTV09SRCAiLAogCQkJCQkJCQkgIGZtdElkKHVzZXIpKTsKIAkJCQlhcHBlbmRTdHJpbmdMaXRl cmFsQ29ubigmYnVmLCBlbmNyeXB0ZWRfcGFzc3dvcmQsIHBzZXQuZGIpOwogCQkJCXJlcyA9IFBT UUxleGVjKGJ1Zi5kYXRhKTsKLQkJCQl0ZXJtUFFFeHBCdWZmZXIoJmJ1Zik7CiAJCQkJaWYgKCFy ZXMpCiAJCQkJCXN1Y2Nlc3MgPSBmYWxzZTsKIAkJCQllbHNlCkBAIC0yMDgzLDYgKzIwODQsNyBA QCBleGVjX2NvbW1hbmRfcGFzc3dvcmQoUHNxbFNjYW5TdGF0ZSBzY2FuX3N0YXRlLCBib29sIGFj dGl2ZV9icmFuY2gpCiAJCQlmcmVlKHVzZXIpOwogCQlmcmVlKHB3MSk7CiAJCWZyZWUocHcyKTsK KwkJdGVybVBRRXhwQnVmZmVyKCZidWYpOwogCX0KIAllbHNlCiAJCWlnbm9yZV9zbGFzaF9vcHRp b25zKHNjYW5fc3RhdGUpOwotLSAKMi4xNi42Cgo= --_003_E0C46CDF46B24388B53B96EB2CA0F71Eamazoncom_--