Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Adjust error message for CREATE STATISTICS to account for
 expressions
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow@mail.gmail.com>
Date: Mon, 30 Mar 2026 11:19:36 +0800
Cc: Michael Paquier <michael@paquier.xyz>,
 Yugo Nagata <nagata@sraoss.co.jp>,
 John Naylor <johncnaylorls@gmail.com>,
 Dean Rasheed <dean.a.rasheed@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E0E9225B-82B0-485E-8E8B-07330D217383@gmail.com>
References: <20260324203430.411331c59ca462457ec0aa8b@sraoss.co.jp>
 <CANWCAZYdyQzCoAiq9kybHT2RcnC1CgrxbCpyxeV3+KZn2xj2UA@mail.gmail.com>
 <20260325131548.4c9a0c8d05a422021b1ba76c@sraoss.co.jp>
 <CANWCAZYjDSsvC6M6pas26ffbj-TZmXOHHC1-DwRM2LFa+qr3GQ@mail.gmail.com>
 <acXAAbIp9tfsvHxy@paquier.xyz>
 <CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow@mail.gmail.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/E0E9225B-82B0-485E-8E8B-07330D217383%40gmail.com>
Precedence: bulk


> On Mar 27, 2026, at 08:45, John Naylor <johncnaylorls@gmail.com> =
wrote:
>=20
> On Fri, Mar 27, 2026 at 6:23=E2=80=AFAM Michael Paquier =
<michael@paquier.xyz> wrote:
>> -    errmsg("extended statistics require at least 2 columns")));
>> +    errmsg("extended statistics are not supported on a single =
column")));
>>=20
>> Now our documentation also tells that the former message is not the
>> preferred project style (full sentences usually avoided in primary
>> messages):
>> =
https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-G=
UIDE-GRAMMAR-PUNCTUATION
>=20
> My reading of that is that hints/details need to be complete
> sentences, and primary messages don't need to be.=20

+1


> From: Dean Rasheed <dean.a.rasheed@gmail.com>
>=20
>=20
> If we were to give more detail, it should probably be to point out
> that regular statistics will already be built for single columns,
> which is why single-column extended statistics would be redundant. So
> perhaps something like this:
>=20
> Error: cannot create extended statistics on a single column
> Detail: Univariate statistics are already built for each individual
> table column.

I like this version.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/