Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVEKd-0003y6-1U for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Mar 2022 15:15:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nVEKb-00051o-UD for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Mar 2022 15:15:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVEKb-00051f-Bx for pgsql-hackers@lists.postgresql.org; Fri, 18 Mar 2022 15:15:57 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nVEKV-000672-Gw for pgsql-hackers@postgresql.org; Fri, 18 Mar 2022 15:15:57 +0000 Received: by mail-pf1-x431.google.com with SMTP id d19so9685766pfv.7 for ; Fri, 18 Mar 2022 08:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9n9K+K0gnJC8XsK0kQqu8GGWNukhZ6yDmfFtCndHXIs=; b=bYWScPmYhuLXJ4qGjt/sHFJz64Fuc/iaAgZBfBW4jwdT4hklg4pvq09EBQJZxMwqPU 6QboSTne8VXd53k751E8ts2O0DgBDdJ/b66NPzZIvbyvfWkLA2223cc6hKYV4BUK1Wx6 sPEXNhHfrhTI4aBkV22x9X2g2mSxjVFafwWHUGFAQuNtQR7yeAKn1PT0Usqfc/4oV8CM IbwafvsnLkPlcn9Dba2ihObkqsoMBbQOk4lMO/RwOxa2Ia2ScKxsLffrrQ+c+urzZrfH N27pq3rxBCKPgj3mHxbEuBbpu+dirdMTqnUe+ssl+jzxfN3zej39mvvcsKyyQeKhEY4B c8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9n9K+K0gnJC8XsK0kQqu8GGWNukhZ6yDmfFtCndHXIs=; b=VvhJ3HGQh7SijyX9DaVIwNiMA78pJyAfMRYiVNRLOTrOllH+fOB/psjQU1zOn50Wb4 GIaRakFA17KJNOpGaVJUSUN5pvvt8S6kWDLvs90q08PRQRkIpoH8LW+pRpS5em8F+IiZ 2DD7XDyqpLqlYGl3RfpRjU/ZrbgEB4cccMzNEg6aKJmVoBOcG9UPRYU7jteWRXVIW4Bf ZQnWz0sIy83jG0nAg36JZRbVqXne304Gn2qvA31oIyLf1mtkY2k7XFSHh6nVJsfPIl8K rA7MoltWAnzTr4o+RMThrWYUg2iCVLXWcaKIGXRfVMS1mSVU2BcQlRXILQE+1PlChTaR TeZQ== X-Gm-Message-State: AOAM532wJgD7CcAIYxpg0umpMhYNap/5/Wch1F/r8QGwQHiCaiiusvLi 1sQqWgPg95YiBUJsErEuTUisGmBAFhzNbPFwnNnQrgrXiSY43NbRufj+rchg5EUuUrHknJjfhsQ XfH0iRg5S1/H64RdGcUt+/mtGwCZLIILPFFbkceTc0C6KWq3/QDn8M2K3LsvdEodlCGV2N9vMqg 1hyYQhp5e6HNxttVkiZRnc7cjRmRMGDPPMmF7I X-Google-Smtp-Source: ABdhPJyjN8vTAqRRJALQFRGS8vK9OgEiPsXWoA4vj41fI85DMXV/j4sg363OPIhJz0+5XTKHbzo06A== X-Received: by 2002:a63:740f:0:b0:381:1467:d478 with SMTP id p15-20020a63740f000000b003811467d478mr8150071pgc.391.1647616548720; Fri, 18 Mar 2022 08:15:48 -0700 (PDT) Received: from laptop280-ma-us.hitronhub.home (24-113-193-150.wavecable.com. [24.113.193.150]) by smtp.gmail.com with ESMTPSA id p10-20020a056a0026ca00b004fa06fa407asm10224016pfw.91.2022.03.18.08.15.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Mar 2022 08:15:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: New Object Access Type hooks From: Mark Dilger In-Reply-To: Date: Fri, 18 Mar 2022 08:15:47 -0700 Cc: PostgreSQL-development , Robert Haas , Tom Lane , Andrew Dunstan , Jeff Davis , Joe Conway , Stephen Frost Content-Transfer-Encoding: quoted-printable Message-Id: References: <47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com> To: Joshua Brindle X-Mailer: Apple Mail (2.3608.120.23.2.7) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Mar 18, 2022, at 7:16 AM, Joshua Brindle = wrote: >=20 > This is great, thank you for doing this. I didn't even realize the OAT > hooks had no regression tests. >=20 > It looks good to me, I reviewed both and tested the module. I wonder > if the slight abuse of subid is warranted with brand new hooks going > in but not enough to object, I just hope this doesn't rise to the too > large to merge this late level. The majority of the patch is regression testing code, stuff which = doesn't get installed. It's even marked as NO_INSTALLCHECK, so it won't = get installed even as part of "make installcheck". That seems safe = enough to me. Not including tests of OAT seems worse, as it leaves us open to breaking = the behavior without realizing we've done so. A refactoring of the core = code might cause hooks to be called in a different order, something = which isn't necessarily wrong, but should not be done unknowingly. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company