From: Chao Li <li.evan.chao@gmail.com>
Message-Id: <E2D69547-B593-4899-95DE-1F46F7E14588@gmail.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_E9185E41-E06F-4150-AE36-3BF697F01117"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Use proc_exit() in WalRcvWaitForStartPosition
Date: Mon, 13 Apr 2026 07:33:02 +0800
In-Reply-To: 
 <CAHGQGwHdqm5CCqiTR+Dpkr2maKCSVEPyoCOuB8WMHorDsGUeTw@mail.gmail.com>
Cc: Xuneng Zhou <xunengzhou@gmail.com>,
 Andreas Karlsson <andreas@proxel.se>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
To: Fujii Masao <masao.fujii@gmail.com>
References: <74381238-4E8A-4621-B794-57025DCCE0BA@gmail.com>
 <6a42c40e-eb81-4212-9bca-8c0eb02d47d1@proxel.se>
 <CABPTF7V=y2rHC=gLTeC-42aRc+jcXueomUBjbNiy3pOfhJs3_A@mail.gmail.com>
 <CAHGQGwHHrDv8Z=D-UP+-RUR2yntv3Ab=yw4_uPWEMY0vLX_O6g@mail.gmail.com>
 <0D17D4E1-919F-4412-8EFE-BEB80211321D@gmail.com>
 <CAHGQGwHdqm5CCqiTR+Dpkr2maKCSVEPyoCOuB8WMHorDsGUeTw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/E2D69547-B593-4899-95DE-1F46F7E14588%40gmail.com>
Precedence: bulk


--Apple-Mail=_E9185E41-E06F-4150-AE36-3BF697F01117
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Apr 10, 2026, at 22:17, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Fri, Apr 10, 2026 at 4:07=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>> PFA v2 - updated header comment of walreceive.c. I tried to avoid =
mentioning the exact exit value in the comment, so I just changed =
=E2=80=9Cexit(0)=E2=80=9D to =E2=80=9Cterminate=E2=80=9D.
>=20
> Thanks for updating the patch!
>=20
> "termination instructs XXX to terminate" sounds a bit redundant. How
> about saying
> "to ereport(FATAL)" instead of =E2=80=9Cto terminate=E2=80=9D?
>=20
> Regards,
>=20
>=20
> --=20
> Fujii Masao


Okay, yes, that was a bit redundant. I changed it to =E2=80=9Cto =
ereport(FATAL)=E2=80=9D in v3.

After that change, the line went over 80 columns, so I also adjusted a =
few nearby lines to keep everything within the 80-column limit. There is =
no content change.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_E9185E41-E06F-4150-AE36-3BF697F01117
Content-Disposition: attachment;
	filename=v3-0001-Use-proc_exit-in-WalRcvWaitForStartPosition.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="v3-0001-Use-proc_exit-in-WalRcvWaitForStartPosition.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20162eb0622f3f7ea436243aa2723737716a7c3e96=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20<lic@highgo.com>=0A=
Date:=20Wed,=208=20Apr=202026=2017:02:28=20+0800=0ASubject:=20[PATCH=20=
v3]=20Use=20proc_exit()=20in=20WalRcvWaitForStartPosition=0A=0AAuthor:=20=
Chao=20Li=20<lic@highgo.com>=0AReviewed-by:=20Fujii=20Masao=20=
<masao.fujii@gmail.com>=0AReviewed-by:=20Andreas=20Karlsson=20=
<andreas@proxel.se>=0AReviewed-by:=20Xuneng=20Zhou=20=
<xunengzhou@gmail.com>=0ADiscussion:=20=
https://postgr.es/m/74381238-4E8A-4621-B794-57025DCCE0BA@gmail.com=0A---=0A=
=20src/backend/replication/walreceiver.c=20|=208=20++++----=0A=201=20=
file=20changed,=204=20insertions(+),=204=20deletions(-)=0A=0Adiff=20=
--git=20a/src/backend/replication/walreceiver.c=20=
b/src/backend/replication/walreceiver.c=0Aindex=20=
09fde92bfd7..80743e6af29=20100644=0A---=20=
a/src/backend/replication/walreceiver.c=0A+++=20=
b/src/backend/replication/walreceiver.c=0A@@=20-30,9=20+30,9=20@@=0A=20=20=
*=20a=20new=20one.=0A=20=20*=0A=20=20*=20Normal=20termination=20is=20by=20=
SIGTERM,=20which=20instructs=20the=20walreceiver=20to=0A-=20*=20exit(0).=20=
Emergency=20termination=20is=20by=20SIGQUIT;=20like=20any=20postmaster=20=
child=0A-=20*=20process,=20the=20walreceiver=20will=20simply=20abort=20=
and=20exit=20on=20SIGQUIT.=20A=20close=0A-=20*=20of=20the=20connection=20=
and=20a=20FATAL=20error=20are=20treated=20not=20as=20a=20crash=20but=20=
as=0A+=20*=20ereport(FATAL).=20Emergency=20termination=20is=20by=20=
SIGQUIT;=20like=20any=20postmaster=0A+=20*=20child=20process,=20the=20=
walreceiver=20will=20simply=20abort=20and=20exit=20on=20SIGQUIT.=20A=0A+=20=
*=20close=20of=20the=20connection=20and=20a=20FATAL=20error=20are=20=
treated=20not=20as=20a=20crash=20but=20as=0A=20=20*=20normal=20=
operation.=0A=20=20*=0A=20=20*=20This=20file=20contains=20the=20=
server-facing=20parts=20of=20walreceiver.=20The=20libpq-=0A@@=20-710,7=20=
+710,7=20@@=20WalRcvWaitForStartPosition(XLogRecPtr=20*startpoint,=20=
TimeLineID=20*startpointTLI)=0A=20=09=09=09=20*=20to=20die,=20but=20=
might=20as=20well=20check=20it=20here=20too.=0A=20=09=09=09=20*/=0A=20=09=
=09=09SpinLockRelease(&walrcv->mutex);=0A-=09=09=09exit(1);=0A+=09=09=09=
proc_exit(1);=0A=20=09=09}=0A=20=09=09SpinLockRelease(&walrcv->mutex);=0A=
=20=0A--=20=0A2.50.1=20(Apple=20Git-155)=0A=0A=

--Apple-Mail=_E9185E41-E06F-4150-AE36-3BF697F01117--