Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\))
Subject: Re: jsonapi: scary new warnings with LTO enabled
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CAOYmi+=w3Q-3F=LCr9hPRhiG2HGv6sogGOJW3v9pwpoCD6wN+w@mail.gmail.com>
Date: Mon, 21 Apr 2025 20:20:00 +0200
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E4E01D53-5E8C-4D93-85A8-633E93D0A194@yesql.se>
References: <2074634.1744839761@sss.pgh.pa.us>
 <0A3CF5C4-9947-42E3-89A9-34FCF7BA95BA@yesql.se>
 <2078511.1744841564@sss.pgh.pa.us>
 <DCD56158-A642-4954-87FF-9DAD5425F3FF@yesql.se>
 <2084687.1744844690@sss.pgh.pa.us>
 <CAOYmi+n+DHpaEV5hymhufutTgc+S=+pDQfXEUi4hMAV1eO8aTw@mail.gmail.com>
 <2087556.1744846124@sss.pgh.pa.us>
 <0A596D8B-24F3-408F-B89B-B42014B00A05@yesql.se>
 <2202326.1744903233@sss.pgh.pa.us>
 <CAOYmi+mxjW0GhSGPKoOy3TYrFcdTM=5FcUn=u1i7CFhb2303Zg@mail.gmail.com>
 <25801148-284F-41F9-A279-A4CF92623C77@yesql.se>
 <CAOYmi+=w3Q-3F=LCr9hPRhiG2HGv6sogGOJW3v9pwpoCD6wN+w@mail.gmail.com>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/E4E01D53-5E8C-4D93-85A8-633E93D0A194%40yesql.se>
Precedence: bulk

> On 21 Apr 2025, at 17:33, Jacob Champion =
<jacob.champion@enterprisedb.com> wrote:
>=20
> On Sat, Apr 19, 2025 at 2:15=E2=80=AFPM Daniel Gustafsson =
<daniel@yesql.se> wrote:
>> Since there is no way to determine if the allocation succeeded from =
outside of
>> the JSON api it might be better to keep the calloc and explicitly =
free it?
>=20
> I don't think so; pg_parse_json() will error out quickly, so I don't
> see much advantage to the extra code. Raw performance isn't much of a
> concern for the out-of-memory case, IMO.

Sure, but I fear we'll get an endless stream of static analysis reports =
for the
allocation leaking if we don't free it.

--
Daniel Gustafsson