Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: initdb's -c option behaves wrong way?
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <2629788.1705682037@sss.pgh.pa.us>
Date: Mon, 22 Jan 2024 11:09:14 +0100
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E54AEDA7-D20D-48A6-95B6-1502875EFFC5@yesql.se>
References: <2062980.1705523170@sss.pgh.pa.us>
 <2063810.1705523582@sss.pgh.pa.us>
 <2FC1625E-4757-4076-8965-7DBDA5ECC6D9@yesql.se>
 <20240118.134944.899707778910524729.horikyota.ntt@gmail.com>
 <8103BBF3-107B-4FE8-B325-B9FC2BF7429D@yesql.se>
 <2629788.1705682037@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/E54AEDA7-D20D-48A6-95B6-1502875EFFC5%40yesql.se>
Precedence: bulk

> On 19 Jan 2024, at 17:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Daniel Gustafsson <daniel@yesql.se> writes:
>> I'll give some more time for opinions, then I'll go ahead with one of =
the
>> patches with a backpatch to v16.
>=20
> OK, I take back my previous complaint that just using strncasecmp
> would be enough --- I was misremembering how the code worked, and
> you're right that it would use the spelling from the command line
> rather than that from the file.
>=20
> However, the v3 patch is flat broken.  You can't assume you have
> found a match until you've verified that whitespace and '=3D'
> appear next --- otherwise, you'll be fooled by a guc_name that
> is a prefix of one that appears in the file.  I think the simplest
> change that does it correctly is as attached.

The attached v4 looks good to me, I don't think it moves the needle wrt
readability (ie, no need to move the search).  Feel free to go ahead =
with that
version, or let me know if you want me to deal with it.

--
Daniel Gustafsson