Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxOME-00BioV-2Z for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Mar 2026 11:56:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vxOMD-006ofG-0V for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Mar 2026 11:56:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxOMC-006of8-2s for pgsql-hackers@lists.postgresql.org; Tue, 03 Mar 2026 11:56:09 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vxOMB-00000000Aoq-0TCk for pgsql-hackers@lists.postgresql.org; Tue, 03 Mar 2026 11:56:08 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2ae41544dcfso31736725ad.1 for ; Tue, 03 Mar 2026 03:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772538966; x=1773143766; darn=lists.postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iMEep9LD80+FAZM4eH+zWqOjk+JmlCbchOl6oUo0o78=; b=dAn14r9du4achkh8EVDlrgDGTFCEBjEKYZPgcHfVRAzypBIMLI8CqXU/cqnF1K7giK TKJEFsFuGtKeTyFfAfuYlKXBX63jExh9wvrlvHm+fT6KuExt5/0FMopc7nktbe3hbLRl SqQOYJWo9ZRqrPTaJRacyVVIgLuJs+lK1WQezYF/It682mIAazvdXifE5gDf0cLg+Grm YYaDfl+Hcaui6aSQyK2f+mCZFuQreKkYYpGel8WAzG2yCADMKNqA2roOS15iI1zalv+G cnG3z5p4v8OSjvTm1PLrIcjlDoH/lzvsSfmVmg8Y8Tc4oMInkIJCuKm75sUsnbe/c1+1 6scA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772538966; x=1773143766; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iMEep9LD80+FAZM4eH+zWqOjk+JmlCbchOl6oUo0o78=; b=kjFrOIu5xoqPVsv+uD6EgWp+ezc26OQopzULjbujcXp1bNAMMogLvwFipaXfi6y+Q3 s8u/Bf9lvzW9DYR1X9WwLlfrw6rDTeqaUVMaWtSV6kpxOd5st2ltsVn0PgRsnKp6ayKj n4Cy4Eogkn8ARYwxPgkC/TabzjBzogsOJDjO4D8MWVPEASRckU4AAkNFJHiKlqTc++5i k5/cZ3NjLKPM+7rjuMDBAH4TiavGmtSMoesJawR6DV12PAiD6l5S7Np/nGBthb5sBGFc Yb/iq/wUAippkLw2/Tyk7uFaq3DYQqZpHGUXxdiHuttqVsDEb6ZxQLU9aYl1m8QYAPLE UBBw== X-Gm-Message-State: AOJu0Yw23T9RS/bX8QNLz+jvOudhWv80rwrUoJBJWf3q8W/4Ql791gV8 0vnM2ESV8ssy6EbhAq1LhfxHry3Cm5MzpOPbLv/imG2ozcdRZ7303AeF X-Gm-Gg: ATEYQzyVx7c/9I5b5swlhc5qByrengpf2vL3ILbPFfloZY6WpODDBvPAWp+rTcmf4zd qXYuaYZw2NDf5DjUOJrPxVmlltR4LEDlj48lzm9vYz7Vwan/pcZiD28hYpQci+CTH2+AVcqvm6J uTH/We+0Ev7Wan5NgMJQ9j+XZtYlYE2dfcjYjmXMd1EqJYw2kU7u/twEiKUl/LHW9Zw3aSk3PQQ e/v7K0CmSfSnsC9mqQwEeHUfbKryb9SsGCQUOnXxWLRPTBKw2nagMu0VIMgkPv4QM67RUys5AZO 7O9VOwMvLXugK6UbSfd3iK06vXMuhqdRbMqtMzB/Ef+x+lG5Wt00qH69AIhq8N4BRsKDWUpqT0A XPR7FCHb+eZMFFbA+kmpoKiEZBU90jmvCXA4gLIqcHwX7YChPGFwDiIM5jC04vRv3r++DwubWUL v/lDZ7BDF+TZSxHRNtWdHN5Irn0v6pZPQ= X-Received: by 2002:a17:903:3ba5:b0:2ae:61bb:425c with SMTP id d9443c01a7336-2ae61bb4671mr16193525ad.35.1772538966139; Tue, 03 Mar 2026 03:56:06 -0800 (PST) Received: from smtpclient.apple ([203.76.245.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5b36e1sm167013905ad.9.2026.03.03.03.56.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2026 03:56:05 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: Cleanup shadows variable warnings, round 1 From: Chao Li In-Reply-To: <202603031015.s6lmrgi7x67r@alvherre.pgsql> Date: Tue, 3 Mar 2026 19:55:36 +0800 Cc: Postgres hackers , Peter Eisentraut , Peter Smith Content-Transfer-Encoding: quoted-printable Message-Id: References: <202603031015.s6lmrgi7x67r@alvherre.pgsql> To: =?utf-8?Q?=C3=81lvaro_Herrera?= X-Mailer: Apple Mail (2.3864.400.21) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Mar 3, 2026, at 18:26, =C3=81lvaro Herrera = wrote: >=20 > Pushed 0001. Hi Alvaro, thank you very much for pushing 0001. But I don=E2=80=99t see = it. I tried to pull master and refresh = https://git.postgresql.org/cgit/postgresql.git/log/?qt=3Dgrep&q=3D, none = of them shows 0001 pushed. >=20 > Three things about the next ones, >=20 > 1. if you rename a function argument, then the function declaration > should match the new name as well. Sure, I will make sure that in next revision. >=20 > 2. xlogrecovery.c has far too many global variables. Can we use this > opportunity to try to get rid of some of them? Especially one called > "xlogreader" is I think quite bug-prone. Okay, I will try to address this. >=20 > 3. I disagree with some of the choices made; for instance rather than > rename the local "progname" variables in all those places, I would > rename the global to logging_progname in logging.c; in bringetbitmap > (0002) I would rename the outer "tmp" to "sizecheck" or something like > that. I guess this is mostly matter of mostly arbitrary judgment ... >=20 I will rename them per your suggestion, and check if there are similar = things to rename. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/