Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\))
Subject: Re: Vacuum statistics
From: Jim Nasby <jnasby@upgrade.com>
In-Reply-To: <CAA5RZ0vFkGX8Hks3GCg=BPqVEcUHFTXBTmiheKgJ1-0C_14JFg@mail.gmail.com>
Date: Fri, 3 Jan 2025 13:08:02 -0600
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>,
 Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>,
 Andrei Zubkov <zubkov@moonset.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 a.lepikhov@postgrespro.ru,
 Alexander Korotkov <aekorotkov@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E806AFB8-168A-4396-BFA8-F3CF52B7AE3F@upgrade.com>
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru>
 <CAD21AoAVK7DwTZLfhwuRhTGgR=_ASu5YshEg_Cmpojk5ZdZ3tA@mail.gmail.com>
 <CAAKRu_auu=xt4w3Mm_jW-voJunZgno6XDDohH6hhRc4Z9dGdYQ@mail.gmail.com>
 <CAD21AoD66b3u28n=73kudgMp5wiGiyYUN9LuC9z2ka6YTru5Gw@mail.gmail.com>
 <9485d892-fd04-4e3a-ac24-7dd767cb7333@postgrespro.ru>
 <CAPpHfduwY8-fp34CuO9O57ouCs1K=Gn1rTnuG4AaWYhEo6nXyw@mail.gmail.com>
 <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com>
 <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru>
 <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com>
 <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru>
 <E0B6D242-C16D-4848-930E-B693D4E5C678@upgrade.com>
 <e2003f94-2075-4183-8298-9d25d8431fb1@postgrespro.ru>
 <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com>
 <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru>
 <CAPpHfds=woPcB9nPtMmu=g=U9q6-FHFh7fF_x=uhU3k2Oi03sA@mail.gmail.com>
 <f972c2c9-edcc-49b8-9f23-6208eedc3d23@tantorlabs.com>
 <77e6e723-0d3e-4235-8386-03d143916125@postgrespro.ru>
 <CAA5RZ0sjDx6QFRJJ+e=orwvLboLWO42f2qF0_HbDq-sMq=tW4g@mail.gmail.com>
 <0E5557BC-50FC-400F-BE96-11922C0C11EE@upgrade.com>
 <CAA5RZ0vFkGX8Hks3GCg=BPqVEcUHFTXBTmiheKgJ1-0C_14JFg@mail.gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/E806AFB8-168A-4396-BFA8-F3CF52B7AE3F%40upgrade.com>
Precedence: bulk

On Jan 2, 2025, at 4:33=E2=80=AFPM, Sami Imseih <samimseih@gmail.com> =
wrote:
>=20
>> While backwards compatibility is important, there=E2=80=99s =
definitely precedent for changing
>> what shows up in the catalog. IMHO it=E2=80=99s better to bite the =
bullet and move those fields
>> instead of having vacuum stats spread across two different views.
>=20
> Correct, the most recent one that I could think of is =
pg_stat_checkpointer,
> which pulled the checkpoint related columns from pg_stat_bgwriter.
> In that case though, these are distinct background processes and
> it's a clear distinction.
>=20
> In this case, I am not so sure about this, particularly because
> we will then have the autoanalyze and autovacuum fields in different
> views, which could be more confusing to users than saying =
pg_stat_all_tables
> has high level metrics about vacuum and analyze and for more details =
on
> vacuum, refer to pg_stat_vacuum_tables ( or whatever name we settle on =
).

I guess one question is how realistic it is to try and put everything =
about (auto)vacuum in a single view. Given the complexity, the answer to =
that might just be =E2=80=9Cno=E2=80=9D. In that case leaving existing =
fields in pg_stat_all_tables is a lot more reasonable.

Related to this=E2=80=A6 it=E2=80=99d be nice if we had a view that gave =
insight to users about auto vacuum scheduling. I know there=E2=80=99s =
one floating around the internet, but given the number of systems I=E2=80=99=
ve seen where autovac can=E2=80=99t keep up it=E2=80=99d be good to =
raise user awareness.=