Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Add "format" target to make and ninja to run pgindent and
 pgperltidy
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CAGECzQTsrBm1H5BqwvgeGYYMnYXT6Xnh3qGG3ggxA8_Xw=dHWw@mail.gmail.com>
Date: Fri, 13 Mar 2026 23:26:13 +0100
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Andrew Dunstan <andrew@dunslane.net>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EAB73E05-6551-4537-A742-C091C9206B25@yesql.se>
References: <DFCDD5H4J7VX.3GJKRBBDCKQ86@jeltef.nl>
 <CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
 <3913298.1767194804@sss.pgh.pa.us>
 <5611b8aa-8496-4632-92b4-e096654850d1@dunslane.net>
 <DGTVWJWZB0C9.CKSLBGGSXN4F@jeltef.nl>
 <de91907e-fa32-4bec-968b-1099479dae16@eisentraut.org>
 <DH1IHNI06K3E.35YUXK4EVN8D6@jeltef.nl>
 <475CE843-FEFE-40E0-9341-3D5502D1F51C@yesql.se>
 <CAGECzQTsrBm1H5BqwvgeGYYMnYXT6Xnh3qGG3ggxA8_Xw=dHWw@mail.gmail.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Archived-At: 
 <https://www.postgresql.org/message-id/EAB73E05-6551-4537-A742-C091C9206B25%40yesql.se>
Precedence: bulk

> On 13 Mar 2026, at 16:11, Jelte Fennema-Nio <postgres@jeltef.nl> =
wrote:
>=20
> On Fri, 13 Mar 2026 at 11:03, Daniel Gustafsson <daniel@yesql.se> =
wrote:
>> The primary reason thus far has been that pgperltidy requires a =
specific
>> version of perltidy, no other version is accepted.  Imposing the =
burden of
>> installing that on a greater subset of people than a subset of =
committers
>> didn't seem palatable.
>=20
> I think that makes sense if the burden is big, but with patch 0008 it
> becomes as simple as running a single command:
> src/tools/pgindent/get_perltidy

In todays world of supply-chain attacks, don't think it's all that =
palatable to
take responsibility for installing code in peoples environments.  =
Regardless, I
don't think the patch should remove the installation instructions.

--
Daniel Gustafsson