Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: CREATE TABLE ( .. STORAGE ..)
From: wenjing zeng <wjzeng2012@gmail.com>
In-Reply-To: <de83407a-ae3d-a8e1-a788-920eb334f25b@sigaev.ru>
Date: Fri, 21 Jan 2022 15:40:57 +0800
Cc: pgsql-hackers <pgsql-hackers@postgreSQL.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <ECF2E7F0-D237-44EA-971B-CB163B4EB457@gmail.com>
References: <de83407a-ae3d-a8e1-a788-920eb334f25b@sigaev.ru>
To: Teodor Sigaev <teodor@sigaev.ru>
Archived-At: <https://www.postgresql.org/message-id/ECF2E7F0-D237-44EA-971B-CB163B4EB457%40gmail.com>
Precedence: bulk

HI

For patch create_table_storage-v1

1=20
+ALTER opt_column ColId SET STORAGE name

+opt_column_storage:
+			STORAGE	ColId						=
	{ $$ =3D $2; }

Are they both set to name or ColId? Although they are the same.

2 For ColumnDef new member storage_name, did you miss the function =
_copyColumnDef()  _equalColumnDef()?


Regards
Wenjing


> 2021=E5=B9=B412=E6=9C=8827=E6=97=A5 15:51=EF=BC=8CTeodor Sigaev =
<teodor@sigaev.ru> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> Hi!
>=20
> Working on pluggable toaster (mostly, for JSONB improvements, see =
links below) I had found that STORAGE attribute on column is impossible =
to set  in CREATE TABLE command but COMPRESS option is possible. It =
looks unreasonable. Suggested patch implements this possibility.
>=20
> [1] =
http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfnyc-2021.pdf
> [2] =
http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgvision-2021.pdf
> [3] =
http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfonline-2021.pdf
> [4] =
http://www.sai.msu.su/~megera/postgres/talks/bytea-pgconfonline-2021.pdf
>=20
> PS I will propose pluggable toaster patch a bit later
> --=20
> Teodor Sigaev                      E-mail: teodor@sigaev.ru
>                                      WWW: =
http://www.sigaev.ru/<create_table_storage-v1.patch.gz>