Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: postgresql.conf.sample tab width
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <aRtugij0CQTbpmIx@nathan>
Date: Tue, 18 Nov 2025 10:25:38 +0800
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <EE0918D4-F05C-4047-910C-F0DED136ADE7@gmail.com>
References: <aReNUKdMgKxLqmq7@nathan> <3230808.1763151915@sss.pgh.pa.us>
 <aRefX8JOs_3VbErE@nathan> <3238135.1763156048@sss.pgh.pa.us>
 <aRehOVyEMFIxl5rE@nathan> <aRtugij0CQTbpmIx@nathan>
To: Nathan Bossart <nathandbossart@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/EE0918D4-F05C-4047-910C-F0DED136ADE7%40gmail.com>
Precedence: bulk

Hi Nathan,

I just reviewed the patch. Looks to me the correct three-commit split:

0001 updates tooling/configure so that 0002 will not introduce =
formatting violation
0002 makes large formatting rewrite (tab->white spaces), and so that the =
commit needs to be added to .git-blace-ignore-revs=20
0003 adds CI enforcement so that no future patches to reintroduce tabs

A tiny comment about a typo in 0003=E2=80=99s commit message:
```
The previous commit updated this file to use tabs instead of
spaces.=20
```

Should be =E2=80=9Cuse spaces instead of tabs=E2=80=9D.

> On Nov 18, 2025, at 02:50, Nathan Bossart <nathandbossart@gmail.com> =
wrote:
>=20
> Here is a rebased patch set.  Notably, I've split it into three =
pieces.
> I'm planning to add 0002 to .git-blame-ignore-revs, as testing =
indicates
> this preserves the blame history reasonably well.
>=20
> --=20
> nathan
> =
<v3-0001-Update-.editorconfig-and-.gitattributes-for-postg.patch><v3-0002-=
Switch-from-tabs-to-spaces-in-postgresql.conf.sam.patch><v3-0003-Check-for=
-tabs-in-postgresql.conf.sample.patch>

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/