Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Eliminating SPI / SQL from some RI triggers - take 3
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CA+HiwqHYwNsZU=FJ=iExPca9NvH+Rmb+wTL_Qv4uu014UbTe5g@mail.gmail.com>
Date: Tue, 31 Mar 2026 13:35:33 +0200
Cc: Junwang Zhao <zhjwpku@gmail.com>,
 Chao Li <li.evan.chao@gmail.com>,
 Haibo Yan <tristan.yim@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Tomas Vondra <tomas@vondra.me>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F0A892CA-B2AE-42CF-A0D5-5C3B23A07F72@yesql.se>
References: 
 <CA+HiwqF4C0ws3cO+z5cLkPuvwnAwkSp7sfvgGj3yQ=Li6KNMqA@mail.gmail.com>
 <CA+HiwqGM6nvAV5O+=Nr+BXMPWOma0oeCRVzVP0XiLE8zX5TVAg@mail.gmail.com>
 <CA+HiwqGMaovCUgDbGxVGnK0Mrivr+ph3YE2Ws+47-ugyPb4f7g@mail.gmail.com>
 <CAFj8pRDaiBe_GOLk_yyYHTtPiDAAaLOM8u1-=Q3ZgXBTH+1igg@mail.gmail.com>
 <CA+HiwqGA5Ay_MR0eJEEbt4j6WrVh4F+AasTp8yCbs5aJLOJn6Q@mail.gmail.com>
 <CAEG8a3JM=NoqiTK0V6S9FNxZPvy1+C5F7rfafTtPKBVWnunL-g@mail.gmail.com>
 <CA+HiwqEyiLCY6MTLbOJXDdLNNQLaURYHvdW797MQgbjEK9od4Q@mail.gmail.com>
 <CAEG8a3+VBpwPf1Rm-ECD90whM9b3YnGhux5CVXdsL6khiBfzRQ@mail.gmail.com>
 <CA+HiwqF2UHzF0sKCp-F2a-U29rqh_9ZPy=f1h+Fh_=M8efj3pg@mail.gmail.com>
 <CAEG8a3L9Ew-WL8sxLROVOcypeaENPmd8qCmMvz4geoGL1TDGCA@mail.gmail.com>
 <CAEG8a3+nUFQo4sdPQF9xy0J73J8RFJ5U9A5+_kMosGDaZ+1sXA@mail.gmail.com>
 <2BE661BA-D909-4093-BF78-DB9B0C099337@gmail.com>
 <CAEG8a3JyKdizWvYsF+z_mA1BKy=dpW11iKVMOG=bk6Tbz6M1Bw@mail.gmail.com>
 <CAEG8a3+Hf4tvvbts29_k_AFhWQmRYfEo_SW4C5FY_140iKghBw@mail.gmail.com>
 <CA+HiwqFV-PY-3BxM6j5TaAiC3AwedDxo-6vwRSbvygg3zF+xAQ@mail.gmail.com>
 <CA+HiwqHpaisS-e+0gAgzh92qZAFxncAJMmmTRZZN=efoeTPgOg@mail.gmail.com>
 <CA+HiwqFwZ6WLRbY8R7VC7JVp5Jot6ktZOkr9wDxTjoK=W1SgdQ@mail.gmail.com>
 <CA+HiwqF_Kz=R8juHJBiOATvabWSOugK4VaGOxoJ_n=E2c7UM9w@mail.gmail.com>
 <CA+HiwqHCB7kcbspkhaLN9enoj5x=ehzhFM4PXDgWUUP8Px41GA@mail.gmail.com>
 <77FA04FE-1F84-4DA1-8855-8BBFD8CC889A@gmail.com>
 <CA+HiwqHpVtP485wEKuXdOkdoZWhvVvfFH40-og07Jp3MPx21eg@mail.gmail.com>
 <CAEG8a3JWHkJSXe9nNcVK7wnYKUEqWuMGFDhy5BynB_9tEjmEUg@mail.gmail.com>
 <5761CE63-06B8-49D9-BAF4-D921F64F18B1@yesql.se>
 <CA+HiwqHYwNsZU=FJ=iExPca9NvH+Rmb+wTL_Qv4uu014UbTe5g@mail.gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/F0A892CA-B2AE-42CF-A0D5-5C3B23A07F72%40yesql.se>
Precedence: bulk

> On 31 Mar 2026, at 13:26, Amit Langote <amitlangote09@gmail.com> =
wrote:
>=20
> On Tue, Mar 31, 2026 at 8:22=E2=80=AFPM Daniel Gustafsson =
<daniel@yesql.se> wrote:
>>> On 31 Mar 2026, at 12:57, Junwang Zhao <zhjwpku@gmail.com> wrote:
>>=20
>>> prion is happy now, the fix works, thanks.
>>=20
>> The widowbird failure seems to be SPI related as well, relevant =
portion of log
>> below. Is that the same or another error?
>=20
> prion was unhappy about something else, which I've fixed:
> =
https://www.postgresql.org/message-id/E1w7U6V-002H6n-0o%40gemulon.postgres=
ql.org
>=20
> Though, I'm not sure if or why the fix is now the reason for
> widowbird's failure.
>=20
>> echo "# +++ tap install-check in src/test/modules/worker_spi +++" && =
rm -rf =
'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modules/worker_sp=
i'/tmp_check && /usr/bin/mkdir -p =
'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modules/worker_sp=
i'/tmp_check && cd . && =
TESTLOGDIR=3D'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modu=
les/worker_spi/tmp_check/log' =
TESTDATADIR=3D'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/mod=
ules/worker_spi/tmp_check' =
PATH=3D"/mnt/data/buildfarm/buildroot/HEAD/inst/bin:/mnt/data/buildfarm/bu=
ildroot/HEAD/pgsql.build/src/test/modules/worker_spi:$PATH" =
PGPORT=3D'65678' =
top_builddir=3D'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/mo=
dules/worker_spi/../../../..' =
PG_REGRESS=3D'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modu=
les/worker_spi/../../../../src/test/regress/pg_regress' =
share_contrib_dir=3D'/mnt/data/buildfarm/buildroot/HEAD/inst/share/postgre=
sql/extension' /usr/bin/prove -I ../../../../src/test/perl/ -I . t/*.pl
>> # +++ tap install-check in src/test/modules/worker_spi +++
>> t/001_worker_spi.pl ........ ok
>> # Tests were run but no plan was declared and done_testing() was not =
seen.
>> # Looks like your test exited with 29 just after 8.
>> t/002_worker_terminate.pl ..
>> Dubious, test returned 29 (wstat 7424, 0x1d00)
>> All 8 subtests passed
>>=20
>> Test Summary Report
>> -------------------
>> t/002_worker_terminate.pl (Wstat: 7424 (exited 29) Tests: 8 Failed: =
0)
>> Non-zero exit status: 29
>> Parse errors: No plan found in TAP output
>> Files=3D2, Tests=3D16, 28 wallclock secs ( 0.08 usr 0.01 sys + 6.63 =
cusr 2.93 csys =3D 9.65 CPU)
>> Result: FAIL
>> make[1]: *** [../../../../src/makefiles/pgxs.mk:439: installcheck] =
Error 1
>> make[1]: Leaving directory =
'/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modules/worker_sp=
i'
>> make: *** [Makefile:87: installcheck-worker_spi-recurse] Error 2
>> log files for step testmodules-install-check-en_GB.UTF-8:
>=20
> Not sure what's going on here or how it's related to 68a8601ee.

Not sure either, I just saw SPI when digging and wanted to check, but I =
agree
that it doesn't seem related.  More log excerpts:


[11:15:49.966](3.762s) ok 1 - dynamic bgworker 0 launched
[11:15:50.372](0.407s) ok 2 - background worker blocked the database =
creation
[11:15:50.413](0.041s) ok 3 - background worker is still running after =
CREATE DATABASE WITH TEMPLATE
[11:15:50.663](0.250s) ok 4 - dynamic bgworker 1 launched
[11:15:51.085](0.421s) ok 5 - dynamic bgworker stopped for CREATE =
DATABASE WITH TEMPLATE
[11:15:51.264](0.179s) ok 6 - dynamic bgworker 2 launched
[11:15:51.438](0.175s) ok 7 - dynamic bgworker stopped for ALTER =
DATABASE RENAME
[11:15:51.655](0.216s) ok 8 - dynamic bgworker 3 launched
error running SQL: 'psql:<stdin>:1: ERROR: database "renameddb" is being =
accessed by other users
DETAIL: There is 1 other session using the database.'
while running 'psql --no-psqlrc --no-align --tuples-only --quiet =
--dbname port=3D17048 host=3D/mnt/data/buildfarm/buildroot/tmp/Li3aVcqeUa =
dbname=3D'postgres' --file - --variable ON_ERROR_STOP=3D1' with sql =
'ALTER DATABASE renameddb SET TABLESPACE test_tablespace' at =
/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modules/worker_spi=
/../../../../src/test/perl/PostgreSQL/Test/Cluster.pm line 2335.
# Postmaster PID for node "mynode" is 792281
### Stopping node "mynode" using mode immediate
# Running: pg_ctl --pgdata =
/mnt/data/buildfarm/buildroot/HEAD/pgsql.build/src/test/modules/worker_spi=
/tmp_check/t_002_worker_terminate_mynode_data/pgdata --mode immediate =
stop
waiting for server to shut down...... done
server stopped
# No postmaster PID for node "mynode"
[11:16:02.658](11.003s) # Tests were run but no plan was declared and =
done_testing() was not seen.
[11:16:02.659](0.001s) # Looks like your test exited with 29 just after =
8.


2026-03-31 11:15:51.686 UTC [792340:4] 002_worker_terminate.pl LOG: =
statement: ALTER DATABASE renameddb SET TABLESPACE test_tablespace
2026-03-31 11:15:51.687 UTC [792340:5] 002_worker_terminate.pl DEBUG: =
attempting worker termination for database 16413
2026-03-31 11:15:51.687 UTC [792340:6] 002_worker_terminate.pl DEBUG: =
termination requested for worker (PID 792336) on database 16413
2026-03-31 11:15:51.787 UTC [792340:7] 002_worker_terminate.pl DEBUG: =
attempting worker termination for database 16413
2026-03-31 11:15:51.787 UTC [792340:8] 002_worker_terminate.pl DEBUG: =
termination requested for worker (PID 792336) on database 16413
2026-03-31 11:15:51.887 UTC [792340:9] 002_worker_terminate.pl DEBUG: =
attempting worker termination for database 16413
2026-03-31 11:15:51.887 UTC [792340:10] 002_worker_terminate.pl DEBUG: =
termination requested for worker (PID 792336) on database 16413
<-- snip -->
2026-03-31 11:15:57.088 UTC [792340:102] 002_worker_terminate.pl DEBUG: =
termination requested for worker (PID 792336) on database 16413
2026-03-31 11:15:57.188 UTC [792340:103] 002_worker_terminate.pl DEBUG: =
attempting worker termination for database 16413
2026-03-31 11:15:57.188 UTC [792340:104] 002_worker_terminate.pl DEBUG: =
termination requested for worker (PID 792336) on database 16413
2026-03-31 11:15:57.288 UTC [792340:105] 002_worker_terminate.pl ERROR: =
database "renameddb" is being accessed by other users
2026-03-31 11:15:57.288 UTC [792340:106] 002_worker_terminate.pl DETAIL: =
There is 1 other session using the database.
2026-03-31 11:15:57.288 UTC [792340:107] 002_worker_terminate.pl =
STATEMENT: ALTER DATABASE renameddb SET TABLESPACE test_tablespace
2026-03-31 11:15:57.289 UTC [792340:108] 002_worker_terminate.pl LOG: =
disconnection: session time: 0:00:05.611 user=3Dbuildfarm =
database=3Dpostgres host=3D[local]
2026-03-31 11:15:57.300 UTC [792281:23] LOG: received immediate shutdown =
request
2026-03-31 11:15:57.300 UTC [792281:24] DEBUG: updating PMState from =
PM_RUN to PM_WAIT_BACKENDS
2026-03-31 11:16:02.309 UTC [792281:25] LOG: issuing SIGKILL to =
recalcitrant children
2026-03-31 11:16:02.547 UTC [792281:26] DEBUG: updating PMState from =
PM_WAIT_BACKENDS to PM_WAIT_DEAD_END
2026-03-31 11:16:02.547 UTC [792281:27] DEBUG: updating PMState from =
PM_WAIT_DEAD_END to PM_NO_CHILDREN
2026-03-31 11:16:02.574 UTC [792281:28] LOG: database system is shut =
down

--
Daniel Gustafsson