public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Plug minor memleak in pg_dump
Date: Wed, 9 Feb 2022 14:14:50 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <oZwKiUxFsVaetG2xOJp7Hwao8F1AKIdfFDQLNJrnwoaxmjyB-45r_aYmhgXHKLcMI3GT24m9L6HafSi2ns7WFxXe0mw2_tIJpD-Z3vb_eyI=@pm.me>
	<CALj2ACVd+hvtEX8ZnQKZpP1bh0Q2yjFtqg00zRNVcwRzdd5now@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

> On 9 Feb 2022, at 03:56, Michael Paquier <[email protected]> wrote:
> 
> On Wed, Feb 02, 2022 at 10:06:13AM +0100, Daniel Gustafsson wrote:
>> The leak itself is clearly not something to worry about wrt memory pressure.
>> We do read into tmp and free it in other places in the same function though (as
>> you note above), so for code consistency alone this is worth doing IMO (and it
>> reduces the risk of static analyzers flagging this).
>> 
>> Unless objected to I will go ahead with getting this committed.
> 
> Looks like you forgot to apply that?

No, but I was distracted by other things leaving this on the TODO list.  It's
been pushed now.

--
Daniel Gustafsson		https://vmware.com/

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Plug minor memleak in pg_dump
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox