Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\))
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <CALH1LguAEsoTYJTCsXNB-7z2Hu9UGEpsXA4kj0FOTmoP=6Wp3Q@mail.gmail.com>
Date: Tue, 7 Mar 2023 10:09:23 +0100
Cc: torikoshia <torikoshia@oss.nttdata.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>,
 Danil Anisimow <anisimow.d@gmail.com>,
 Nikita Malakhov <HukuToc@gmail.com>,
 a.lepikhov@postgrespro.ru,
 tgl@sss.pgh.pa.us
Content-Transfer-Encoding: quoted-printable
Message-Id: <F2BEB24D-A6AB-4BB1-AC75-9A060E5338E0@yesql.se>
References: <CALH1Lgv5QeYSWYDgMBd=wvKum8egiaMR-_77VGsiHPt7E8dK9Q@mail.gmail.com>
 <CALH1LgvzpORM+EHVXRz4-Dv+_aHvm9m9Hu6eYM4PfppwKgXvFQ@mail.gmail.com>
 <686e46d6718f9535bc39fac7cad7408b@oss.nttdata.com>
 <CALH1Lgsr7Asz6r6jnRta7DVEjKwyz=b3XJhyCMoYv8Yy9y4cXg@mail.gmail.com>
 <769423519e16d18a1e7611c6931da58b@oss.nttdata.com>
 <CALH1LguQ5P0uZSYQFy4gJihvV11EkLx+gwxZ-+1DFq1Z6dJqbg@mail.gmail.com>
 <CALH1Lgug+mR9A1bBzR8hrp2oW4=jvR_N0An-i2X_j_y9C1fkiA@mail.gmail.com>
 <CALH1LguPAN=p5wHKwGcHrjE8Vj1x4o1z3Pk228YDif6LFzbeYQ@mail.gmail.com>
 <CABm2Ma6_=qf7kZPyOmiK1CUXeio7q08HNPYXrqkCwF3P_KQu7A@mail.gmail.com>
 <CALH1Lgv+L_HNN2NKo=WD8BbgLy7tEH7=OhNTJ2QWCU_CPMum0g@mail.gmail.com>
 <20230205233723.xw5z5zmeyc57ezq3@alap3.anarazel.de>
 <CALH1LgsbWZWS3qMxdGjg4n57DUHxqyBgTzvYSzfi-sP1N-ZORQ@mail.gmail.com>
 <2587470.1675660337@sss.pgh.pa.us>
 <483E1B59-4A80-450B-8685-7CC12762FD5A@anarazel.de>
 <2592557.1675663234@sss.pgh.pa.us>
 <39143e83571d59dfc04c75707fa0ea5a@oss.nttdata.com>
 <CALH1LgvQ5eRMi3zO7RSmod4ucru=9ekASpReahR7zDcCabANZw@mail.gmail.com>
 <0DE0602F-CC12-40ED-B259-3AB91FB02C3B@yesql.se>
 <8ad8492ff9fae3481d87c7aab4e0aed0@oss.nttdata.com>
 <CALH1LguAEsoTYJTCsXNB-7z2Hu9UGEpsXA4kj0FOTmoP=6Wp3Q@mail.gmail.com>
To: Damir Belyalov <dam.bel07@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/F2BEB24D-A6AB-4BB1-AC75-9A060E5338E0%40yesql.se>
Precedence: bulk

> On 7 Mar 2023, at 09:35, Damir Belyalov <dam.bel07@gmail.com> wrote:

> I felt just logging "Error: %ld" would make people wonder the meaning =
of=20
> the %ld. Logging something like ""Error: %ld data type errors were=20
> found" might be clearer.
> =20
> Thanks. For more clearance change the message to: "Errors were found: =
%".=20

I'm not convinced that this adds enough clarity to assist the user.  We =
also
shouldn't use "error" in a WARNING log since the user has explicitly =
asked to
skip rows on error, so it's not an error per se. How about something =
like:

  ereport(WARNING,
          (errmsg("%ld rows were skipped due to data type =
incompatibility", cstate->ignored_errors),
           errhint("Skipped rows can be inspected in the database log =
for reprocessing.")));

--
Daniel Gustafsson