public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Tim McNamara <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: New developer papercut - Makefile references INSTALL
Date: Mon, 17 Jan 2022 11:17:05 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> On 17 Jan 2022, at 02:11, Tim McNamara <[email protected]> wrote:
> 
> Hello,
> 
> I encountered a minor road bump when checking out the pg source today. The Makefile's all target includes the following help message if GNUmakefile isn't available: 
> 
>  echo "You need to run the 'configure' program first. See the file"; \
>  echo "'INSTALL' for installation instructions." ; \
> 
> After consulting README.git, it looks as though INSTALL isn't created unless the source is bundled into a release or snapshot tarball. I'm happy to submit a patch to update the wording, but wanted to check on the preferred approach.
> 
> Perhaps this would be sufficient?
> 
>  echo "You need to run the 'configure' program first. See the file"; \
>  echo "'INSTALL' for installation instructions, or visit" ; \
>  echo "<https://www.postgresql.org/docs/devel/installation.html>"; ; \

That's a good point, and one few developers are likely to spot so thanks for
raising the issue.  To avoid replicating the wording we can do something like
the attached as well.

--
Daniel Gustafsson		https://vmware.com/



Attachments:

  [application/octet-stream] install.diff (698B, ../[email protected]/2-install.diff)
  download | inline diff:
diff --git a/Makefile b/Makefile
index 99dcfff654..3e78a8ca62 100644
--- a/Makefile
+++ b/Makefile
@@ -17,8 +17,13 @@ all:
 
 all check install installdirs installcheck installcheck-parallel uninstall clean distclean maintainer-clean dist distcheck world check-world install-world installcheck-world:
 	@if [ ! -f GNUmakefile ] ; then \
+	   if [ ! -f INSTALL ] ; then \
+	       INSTRUCTIONS="'README.git'"; \
+	   else \
+		   INSTRUCTIONS="'INSTALL'"; \
+	   fi; \
 	   echo "You need to run the 'configure' program first. See the file"; \
-	   echo "'INSTALL' for installation instructions." ; \
+	   echo "$$INSTRUCTIONS for installation instructions." ; \
 	   false ; \
 	 fi
 	@IFS=':' ; \

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: New developer papercut - Makefile references INSTALL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox