Feedback-ID: i7c334307:Fastmail
From: "David E. Wheeler" <david@justatheory.com>
Message-Id: <F411E109-F9A2-4617-ADB6-0A8D4A44DC53@justatheory.com>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_4A68AE1F-9E12-48EA-AD6D-42DDBFE52131";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: RFC: Additional Directory for Extensions
Date: Fri, 25 Apr 2025 15:23:47 -0400
In-Reply-To: <aAtzApxI8A03tiXc@msg.df7cb.de>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Matheus Alcantara <matheusssilv97@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>,
 Craig Ringer <craig.ringer@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
To: Christoph Berg <myon@debian.org>
References: 
 <CAFY6G8dGcv1D8tCkjrz+9DvAYG9h4U=hBm0VXjJEXExy44hauQ@mail.gmail.com>
 <CAFY6G8eOMkGXLqzUz=qXrwt4X_HvmVZ13570DAbgAiw+3q03DA@mail.gmail.com>
 <CAFY6G8fV5FTqn7p8pxbvPYUD5+ffik-J50GChjKH2Gg7d=fRPg@mail.gmail.com>
 <38c53446-6b65-4222-b76b-351e56f4841c@eisentraut.org>
 <CAFY6G8cGeUV0f5K8v-Du0ts3iZyRE6Q5dNtYjQq8cjS4epLX5A@mail.gmail.com>
 <7c178ff3-20a5-493e-a704-e6b3263e782f@eisentraut.org>
 <CAFY6G8d56BK5TZ7K+uw4DHLZ=9Th3p+E1x4pp26nJ_K5k4EUwA@mail.gmail.com>
 <28e98657-9369-4539-9e06-9124d1e77853@eisentraut.org>
 <6B5BF07B-8A21-48E3-858C-1DC22F3A28B4@justatheory.com>
 <25075595-41F1-4BDA-9390-9E0D983BA909@justatheory.com>
 <aAtzApxI8A03tiXc@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/F411E109-F9A2-4617-ADB6-0A8D4A44DC53%40justatheory.com>
Precedence: bulk


--Apple-Mail=_4A68AE1F-9E12-48EA-AD6D-42DDBFE52131
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_7A6F95EE-8EC4-46E5-B400-C159B73BDA04"


--Apple-Mail=_7A6F95EE-8EC4-46E5-B400-C159B73BDA04
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Apr 25, 2025, at 07:33, Christoph Berg <myon@debian.org> wrote:
>=20
> Re: David E. Wheeler
>> +<programlisting>
>> +make install prefix=3D/etc/postgresql
>=20
> I'd use /usr/local/postgresql there. "/etc" is just wrong.

Thank you for the review. Here=E2=80=99s v3*.

Best,

David

* Also reviewable as a GitHub PR[1].

[1]: https://github.com/theory/postgres/pull/10


--Apple-Mail=_7A6F95EE-8EC4-46E5-B400-C159B73BDA04
Content-Disposition: attachment;
	filename=v3-0001-Flesh-out-docs-for-the-prefix-make-variable.patch
Content-Type: application/octet-stream;
	name=v3-0001-Flesh-out-docs-for-the-prefix-make-variable.patch;
	x-unix-mode=0644
Content-Transfer-Encoding: quoted-printable

=46rom=20d49d3445ca5bdde436713dc8a2ae7707683851e3=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"David=20E.=20Wheeler"=20=
<david@justatheory.com>=0ADate:=20Fri,=2025=20Apr=202025=2015:22:23=20=
-0400=0ASubject:=20[PATCH=20v3]=20Flesh=20out=20docs=20for=20the=20=
`prefix`=20make=20variable=0A=0AThe=20variable=20is=20a=20bit=20magical=20=
in=20how=20it=20requires=20"postgresql"=20or=20"pgsql"=0Ato=20be=20part=20=
of=20the=20path,=20and=20files=20end=20up=20in=20its=20`share`=20and=20=
`lib`=0Asubdirectories.=20So=20mention=20all=20that=20and=20show=20an=20=
example=20of=20setting=0A`extension_control_path`=20and=20=
`dynamic_library_path`=20to=20use=20those=0Alocations.=0A---=0A=20=
doc/src/sgml/extend.sgml=20|=2033=20+++++++++++++++++++++++++++++----=0A=20=
1=20file=20changed,=2029=20insertions(+),=204=20deletions(-)=0A=0Adiff=20=
--git=20a/doc/src/sgml/extend.sgml=20b/doc/src/sgml/extend.sgml=0Aindex=20=
64f8e133cae..05063d4e7bc=20100644=0A---=20a/doc/src/sgml/extend.sgml=0A=
+++=20b/doc/src/sgml/extend.sgml=0A@@=20-1809,10=20+1809,35=20@@=20=
include=20$(PGXS)=0A=20=20=20=20=20setting=20=
<varname>PG_CONFIG</varname>=20to=20point=20to=20its=0A=20=20=20=20=20=
<command>pg_config</command>=20program,=20either=20within=20the=20=
makefile=0A=20=20=20=20=20or=20on=20the=20<literal>make</literal>=20=
command=20line.=0A-=20=20=20=20You=20can=20also=20select=20a=20separate=20=
installation=20directory=20for=20your=20extension=0A-=20=20=20=20by=20=
setting=20the=20<literal>make</literal>=20variable=20=
<varname>prefix</varname>=0A-=20=20=20=20on=20the=20=
<literal>make</literal>=20command=20line.=20=20(But=20this=20will=20then=20=
require=0A-=20=20=20=20additional=20setup=20to=20get=20the=20server=20to=20=
find=20the=20extension=20there.)=0A+=20=20=20</para>=0A+=0A+=20=20=20=
<para>=0A+=20=20=20=20You=20can=20also=20select=20a=20separate=20=
directory=20prefix=20in=20which=20to=20install=20your=0A+=20=20=20=20=
extension's=20files=20by=20setting=20the=20<literal>make</literal>=20=
variable=0A+=20=20=20=20<varname>prefix</varname>=20when=20executing=20=
<literal>make=20install</literal>=0A+=20=20=20=20like=20so:=0A=
+<programlisting>=0A+make=20install=20prefix=3D/usr/local/postgresql=0A=
+</programlisting>=0A+=20=20=20=20This=20will=20install=20the=20control=20=
SQL=20files=20into=0A+=20=20=20=20=
<literal>/usr/local/postgresql/share</literal>=20and=20shared=20modules=20=
into=0A+=20=20=20=20<literal>/usr/local/postgresql/lib</literal>.=20If=20=
the=20prefix=20does=20not=0A+=20=20=20=20include=20the=20strings=20=
<literal>postgres</literal>=20or=0A+=20=20=20=20=
<literal>pgsql</literal>,=20such=20as:=0A+<programlisting>=0A+make=20=
install=20prefix=3D/usr/local/extras=0A+</programlisting>=0A+=20=20=20=20=
Then=20the=20<literal>postgresql</literal>=20directory=20will=20be=20=
appended=20io=20the=0A+=20=20=20=20prefix,=20installing=20the=20control=20=
and=20SQL=20files=20into=0A+=20=20=20=20=
<literal>/usr/local/extras/postgresql/share/extension</literal>=20and=20=
shared=0A+=20=20=20=20modules=20into=20=
<literal>/usr/local/extras/postgresql/lib</literal>.=20Either=0A+=20=20=20=
=20way,=20you'll=20need=20to=20set=20<xref=20=
linkend=3D"guc-extension-control-path"/>=20and=0A+=20=20=20=20<xref=20=
linkend=3D"guc-dynamic-library-path"/>=20to=20allow=0A+=20=20=20=20=
<productname>PostgreSQL</productname>=20to=20find=20the=20files:=0A=
+</programlisting>=0A+extension_control_path=20=3D=20=
'/usr/local/extras/postgresql/share/extension:$system'=0A=
+dynamic_library_path=20=3D=20'/usr/local/extras/postgresql/lib:$libdir'=0A=
+=20</programlisting>=0A=20=20=20=20</para>=0A=20=0A=20=20=20=20<para>=0A=
--=20=0A2.48.1=0A=0A=

--Apple-Mail=_7A6F95EE-8EC4-46E5-B400-C159B73BDA04
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii


--Apple-Mail=_7A6F95EE-8EC4-46E5-B400-C159B73BDA04--

--Apple-Mail=_4A68AE1F-9E12-48EA-AD6D-42DDBFE52131
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgL4UQACgkQkt9idPjI
gfG7yRAAhrMfKCOM8Am6lPKeGjK/sd1/Uv9Oq+ccgGgtQBqQHX6SUmFVHcMCdyf1
b7iI6LgtqWHNOUkA61w+6s7QXocQI2TpY4w4/0pvwO40g+0Fj26F1PrTeUZ8817t
VAVGE/uoT4b4daRx3p8Tr+61+ygj6rDbEWXUS5W1VNY7qVfjRP5w6Ia+co+CxjxX
Pb908TBgL13a/o23KRFsBLECqY6P5cktma6rnStbUGqOzlOops0dz2zNGPUdUeeE
1C2G+QrsgR997jN0oO2bXVWNbZoVx+yXEGJspEZKslyI1+WlRWDXLSg1ZkPcD0y3
pHi+YjhS7FvZNw69M6J2WG1zM6ij+w9pwpHOck2nczfrIB4V7GxlBqRb4YJdfmoF
UIbUkaBvPzyyv+KmRsnWyAuY0qdJ+SSO3IVHLQx45wwdbV7xfu0bndbZlJJSI2kO
Q2fagKG1JvnWqh/iE3DG0w/oqSQEtB2QaKixpN3aq7T28e1TDgiL8Oado5m3gMmg
Gdxo5zVYbdNoEilPL6hNrbeaByJ8EbecRcVp/pwM23TU8Lkr9oB2IPuo/aaxdoyj
kaOci0wirX/w6VmeXb0zEj7JmJl0/WUxiJA8ULS9EWDh5ENiqK30IZSSp6URjNkp
Nj5+3XaBqENJz8E+lIZUlDSXTmovS+eY1BpDl6fOxdEGRSDjL9I=
=6BOv
-----END PGP SIGNATURE-----

--Apple-Mail=_4A68AE1F-9E12-48EA-AD6D-42DDBFE52131--