public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: Tom Lane <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Amit Kapila <[email protected]>
Subject: Re: docs: clarify ALTER TABLE behavior on partitioned tables
Date: Mon, 30 Mar 2026 11:06:18 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAEoWx2=mYhCfsnHaN96Qqwq5b0GVS2YgO3zpVqPPRd_iO52wRw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbWNCX1M1e9_-3P9RVGo10huPjuqdL74FJ+-a5EW791KA@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZ+o6La5DyK9_-L2gpeiKNvGMbR78UjocO4++JkyZaRHw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwabxFyFQob=RfKOV3upjxwomAzmGzSouN-h2ypuXz+dZg@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZaquUrTOhfmJ2CenwiyAHx4nORQ0kB01sL+z5pCBuLFQ@mail.gmail.com>
	<CAEoWx2mUiCYJEBuo5D74gi7pHfNz82b54oDHjZNtrXRFDnBPOg@mail.gmail.com>
	<CAKFQuwbQ=L8w8jEaB8_gW-RrNv2_V-VrFYBump7__z-vh-QJWw@mail.gmail.com>
	<CAEoWx2nwoBtWX3=UOQQpGZOuRH5vNv2PHqeFHqDPdiKGaOigiA@mail.gmail.com>
	<CAKFQuwZyJNBN+N5Qtcg0aG6ZpOFvQV5m=cALLgv7g3u1Sz-tZw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZr_GLBOOLohfEcKVVTcP9D+nzVdUUKabYbXWXRnOFjnA@mail.gmail.com>
	<CAEoWx2=CK=QEvpL5HSgFEuFqjO2Q1sDy6a2G-s-+! [email protected]>
	<CAN4CZFNoLSUcVKcOOJgOtTkDuOseCL5j9MQr3tGjb3btD=jHNQ@mail.gmail.com>
	<CAKFQuwZwAuO3qXEeqxwV6vM+89BkB-aSkcXqDGG8e_xBy_Q3Xw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwa9OEJ_sygQi3fNKxzQz7M6V7-zu=4fL0rquXCjudUoyw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbXVypHH=tQEGo-PskaOjnaPwheh7m-PBw-4QDd8bJMeg@mail.gmail.com>
	<[email protected]>
	<CAN4CZFM+vnALQBJ2n9x4njbnm_PQFKXLrPRJ1WYsOUozwz1fsQ@mail.gmail.com>
	<[email protected]>
	<CAKFQuwa9E+k_VekEeP1syJg2qAzTLGcO6qexPAuMZeSEZE9-QA@mail.gmail.com>
	<[email protected]>
	<[email protected]>



> On Mar 30, 2026, at 03:01, Tom Lane <[email protected]> wrote:
> 
> Chao Li <[email protected]> writes:
>> PFA v10 - just integrated v9-0002-diff into the patch.
> 
> I do not like this patch *at all*.  It removes the documentation
> that enunciates the general principles ALTER is following, such as
> 
> -    If a table has any descendant tables, it is not permitted to add,
> -    rename, or change the type of a column in the parent table without doing
> -    the same to the descendants.  This ensures that the descendants always
> -    have columns matching the parent.  Similarly, a <literal>CHECK</literal>
> 
> and replaces that with highly repetitive, explanation-free
> statements like "Specifying <literal>ONLY</literal> is not allowed"
> for each option.  I don't see how this set of changes is an improvement.
> It's also close to unreviewable, since it's so hard to see whether
> those statements have been attached to all and only the proper
> options.
> 
> If there's mistakes in the existing text, by all means let's fix
> them.  But this doesn't seem like the way to go about it.
> 
> By the by, I believe that our general project style is to leave a
> blank line between <para> units.  So I also don't approve of the
> patch making a concerted effort to remove a lot of those blank
> lines, especially when it's doing that to just one file.
> 
> regards, tom lane

Hi Tom,

Thanks for your comments.

The main goal of this patch is to clarify how ALTER TABLE sub-commands behave on partitioned tables, since the current behavior is not always consistent or easy to predict. Because of that, some per-subcommand verification is probably unavoidable. But I agree the current patch may make that harder than it should be.

I also was not aware of the blank-line style convention. In any case, that part is easy to fix.

I’ll rework the patch to better address your concerns.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

view thread (19+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: docs: clarify ALTER TABLE behavior on partitioned tables
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox