Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vetpD-001eWh-1H
	for pgsql-hackers@arkaria.postgresql.org;
	Sun, 11 Jan 2026 11:41:41 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vetpC-00BvAW-0J
	for pgsql-hackers@arkaria.postgresql.org;
	Sun, 11 Jan 2026 11:41:38 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <rkhapov@yandex-team.ru>)
	id 1vetpB-00BvAO-24
	for pgsql-hackers@lists.postgresql.org;
	Sun, 11 Jan 2026 11:41:38 +0000
Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <rkhapov@yandex-team.ru>)
	id 1vetp9-005W8G-1d
	for pgsql-hackers@postgresql.org;
	Sun, 11 Jan 2026 11:41:37 +0000
Received: from mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:65a0:0:640:e1de:0])
	by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id C2CDC807B1;
	Sun, 11 Jan 2026 14:41:30 +0300 (MSK)
Received: from smtpclient.apple (unknown [2a02:6bf:8080:538::1:3a])
	by mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id TfPWSL4Ata60-6todhlNa;
	Sun, 11 Jan 2026 14:41:30 +0300
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;
	s=default; t=1768131690;
	bh=IOx8rFFLuhdQFKekxT07JLDZOrx+8wzkwLTC0xodozQ=;
	h=Message-Id:To:Date:References:Cc:In-Reply-To:From:Subject;
	b=rpO1gl0+XgGUc4Eom4ygocucJWB7zllAnHYFjRmghLdy5dSY8RO5mB6PCTTpWCM2L
	 7hLUoE9C1PBjTsXSoG410P9qGY8awNk6kYSHWhzOgVkovEXzhfmg4bUhMPXw03jxxW
	 1zNuP2elXELlIwLr5d7TGTrUzsDdnZqVJtevMyNY=
Authentication-Results: mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: Use correct macro for accessing offset numbers.
From: Roman Khapov <rkhapov@yandex-team.ru>
In-Reply-To: <CALdSSPidtC7j3MwhkqRj0K2hyp36ztnnjSt6qzGxQtiePR1dzw@mail.gmail.com>
Date: Sun, 11 Jan 2026 16:41:19 +0500
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: 7bit
Message-Id: <F722FCB5-7790-4043-8F64-8D9676943726@yandex-team.ru>
References: <CALdSSPidtC7j3MwhkqRj0K2hyp36ztnnjSt6qzGxQtiePR1dzw@mail.gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
X-Mailer: Apple Mail (2.3864.300.41.1.7)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/F722FCB5-7790-4043-8F64-8D9676943726%40yandex-team.ru>
Precedence: bulk


> On 11 Jan 2026, at 16:21, Kirill Reshke <reshkekirill@gmail.com> wrote:
> 
> Hi hackers!
> 
> PFA trivial patch that uses UInt16GetDatum for OffsetNumber rather
> than Int16GetDatum

Hi!

LGTM, should we check another places of offset number conversations to Datum
as part of this thread?

--
Best regards,
Roman Khapov