From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <F8483DF1-268F-44D3-8D3A-CCB333E2D81F@yesql.se>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_852F46FF-7863-45A1-BE29-8CD869558E4E"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
Date: Wed, 10 Apr 2024 20:33:03 +0200
In-Reply-To: <CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
To: Ranier Vilela <ranier.vf@gmail.com>
References: <CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com>
 <DB8C32CC-83B9-4441-9E6A-626890B5E7F6@yesql.se>
 <CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/F8483DF1-268F-44D3-8D3A-CCB333E2D81F%40yesql.se>
Precedence: bulk


--Apple-Mail=_852F46FF-7863-45A1-BE29-8CD869558E4E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On 10 Apr 2024, at 20:31, Ranier Vilela <ranier.vf@gmail.com> wrote:
>=20
> Em ter., 2 de abr. de 2024 =C3=A0s 15:31, Daniel Gustafsson =
<daniel@yesql.se <mailto:daniel@yesql.se>> escreveu:
>> > On 2 Apr 2024, at 20:13, Ranier Vilela <ranier.vf@gmail.com =
<mailto:ranier.vf@gmail.com>> wrote:
>>=20
>> > Fix by freeing the pointer, like pclose_check (src/common/exec.c) =
similar case.
>>=20
>> Off the cuff, seems reasonable when loglevel is LOG.
>=20
> Per Coverity.
>=20
> Another case of resource leak, when loglevel is LOG.
> In the function shell_archive_file =
(src/backend/archive/shell_archive.c)
> The pointer *xlogarchcmd*  is not freed.

Thanks, I'll have a look.  I've left this for post-freeze on purpose to =
not
cause unnecessary rebasing.  Will take a look over the next few days =
unless
beaten to it.

--
Daniel Gustafsson


--Apple-Mail=_852F46FF-7863-45A1-BE29-8CD869558E4E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><div><blockquote type=3D"cite"><div>On 10 Apr 2024, =
at 20:31, Ranier Vilela &lt;ranier.vf@gmail.com&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div><div dir=3D"ltr"><div =
class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Em ter., 2 =
de abr. de 2024 =C3=A0s 15:31, Daniel Gustafsson &lt;<a =
href=3D"mailto:daniel@yesql.se">daniel@yesql.se</a>&gt; =
escreveu:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">&gt; On 2 Apr 2024, at 20:13, Ranier =
Vilela &lt;<a href=3D"mailto:ranier.vf@gmail.com" =
target=3D"_blank">ranier.vf@gmail.com</a>&gt; wrote:<br>
<br>
&gt; Fix by freeing the pointer, like pclose_check (src/common/exec.c) =
similar case.<br>
<br>
Off the cuff, seems reasonable when loglevel is =
LOG.<br></blockquote><br><div>Per Coverity.</div><div><br></div><div>
<div>Another case of resource leak, when loglevel is =
LOG.</div><div></div>

</div><div>In the function shell_archive_file =
(src/backend/archive/shell_archive.c)</div><div>The pointer =
*xlogarchcmd*&nbsp; is not =
freed.<br></div></div></div></div></blockquote><div><br></div><div><div>Th=
anks, I'll have a look. &nbsp;I've left this for post-freeze on purpose =
to not</div><div>cause unnecessary rebasing. &nbsp;Will take a look over =
the next few days unless</div><div>beaten to =
it.</div></div></div><br><div>
<div>--<br>Daniel Gustafsson</div>

</div>
<br></body></html>=

--Apple-Mail=_852F46FF-7863-45A1-BE29-8CD869558E4E--