Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Small patch to improve safety of utf8_to_unicode().
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <227d0c0c6c7a23c297033df01ad010cbeea5fb09.camel@j-davis.com>
Date: Mon, 29 Jun 2026 06:29:47 +0800
Cc: pgsql-hackers@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F865EE32-6C05-4CA1-8DEC-54E4A7C5CE0D@gmail.com>
References: <c355354e6c3f4a7aafb047361b73db247260fca0.camel@j-davis.com>
 <541F240E-94AD-4D65-9794-7D6C316BC3FF@gmail.com>
 <f11b6c89612f89b76b758807a32a1d3769652d90.camel@j-davis.com>
 <C09D685C-FA5C-47E1-8EDB-B1FDD635309F@gmail.com>
 <c4b27c82decf5b85523ad01f1df3785d8999f333.camel@j-davis.com>
 <fbcb039a9ab3ba834f34174915254732fdcfae86.camel@j-davis.com>
 <c82358d3b1bbd250a03937534bf76de9f4250d0c.camel@j-davis.com>
 <fb7979177b7ab44d9abc2d423391de4ad9faea46.camel@j-davis.com>
 <313BCA0E-2E74-4EB6-9AA8-10DB7F439151@gmail.com>
 <592441c1d871a4ed0ac1708e132f447caa35869c.camel@j-davis.com>
 <3058CAA1-40E0-4098-893B-615F77CD35E1@gmail.com>
 <0cedb517aee8b79b8e31a4e42885ed88c2a67c5f.camel@j-davis.com>
 <16CAD4DB-9D4A-481A-BB4E-78775C4F4B2C@gmail.com>
 <227d0c0c6c7a23c297033df01ad010cbeea5fb09.camel@j-davis.com>
To: Jeff Davis <pgsql@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/F865EE32-6C05-4CA1-8DEC-54E4A7C5CE0D%40gmail.com>
Precedence: bulk


> On Jun 27, 2026, at 22:02, Jeff Davis <pgsql@j-davis.com> wrote:
>=20
> On Fri, 2026-06-26 at 12:38 +0800, Chao Li wrote:
>> Sounds like 0001 will be back patched. In that case, the commit
>> message "defend against invalid UTF8=E2=80=9D seems too broad. Does =
it make
>> sense to add some brief description about the defend behavior to the
>> function header comment and the commit message?
>=20
> Right. Would "defend against truncated byte sequences" or "defend
> against truncated UTF8" be better wording?
>=20
> Regards,
> Jeff Davis
>=20

Yes, I think they are better. =E2=80=9CTruncated=E2=80=9D is more =
specific than =E2=80=9Cinvalid=E2=80=9D. I'm slightly more keen on the =
second phrase.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/