Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: Unstable tests for recovery conflict handling
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: <394950.1651077914@sss.pgh.pa.us>
Date: Wed, 27 Apr 2022 10:11:53 -0700
Cc: Andres Freund <andres@anarazel.de>,
 Melanie Plageman <melanieplageman@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F9294C25-83A0-49F1-9F39-3179739AEF63@enterprisedb.com>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org>
 <394950.1651077914@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/F9294C25-83A0-49F1-9F39-3179739AEF63%40enterprisedb.com>
Precedence: bulk


> On Apr 27, 2022, at 9:45 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> [ starting a new thread cuz the shared-stats one is way too long ]
>=20
> Andres Freund <andres@anarazel.de> writes:
>> Add minimal tests for recovery conflict handling.
>=20
> It's been kind of hidden by other buildfarm noise, but
> 031_recovery_conflict.pl is not as stable as it should be =
[1][2][3][4].
>=20
> Three of those failures look like

Interesting,

I have been getting failures on REL_14_STABLE:

t/012_subtransactions.pl ............. 11/12                             =
                              =20
#   Failed test 'Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared =
transaction on promoted standby'
#   at t/012_subtransactions.pl line 211.
#          got: '3'
#     expected: '0'
t/012_subtransactions.pl ............. 12/12 # Looks like you failed 1 =
test of 12.
t/012_subtransactions.pl ............. Dubious, test returned 1 (wstat =
256, 0x100)
Failed 1/12 subtests=20

And the logs, tmp_check/log/regress_log_012_subtransactions, showing:

### Enabling streaming replication for node "primary"
### Starting node "primary"
# Running: pg_ctl -D =
/Users/mark.dilger/recovery_test/postgresql/src/test/recovery/tmp_check/t_=
012_subtransactions_primary_data/pgdata -l =
/Users/mark.dilger/recovery_test/postgresql/src/test/recovery/tmp_check/lo=
g/012_subtransactions_primary.log -o --cluster-name=3Dprimary start
waiting for server to start.... done
server started
# Postmaster PID for node "primary" is 46270
psql:<stdin>:1: ERROR:  prepared transaction with identifier =
"xact_012_1" does not exist
not ok 11 - Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction =
on promoted standby

#   Failed test 'Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared =
transaction on promoted standby'
#   at t/012_subtransactions.pl line 211.
#          got: '3'
#     expected: '0'


This is quite consistent for me, but only when I configure with =
--enable-coverage and --enable-dtrace.  (I haven't yet tried one of =
those without the other.)

I wasn't going to report this yet, having not yet completely narrowed =
this down, but I wonder if anybody else is seeing this?

I'll try again on master....

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company