Feedback-ID: id4a34324:Fastmail
Date: Thu, 24 Nov 2022 11:32:35 -0800
From: Andres Freund <andres@anarazel.de>
To: Daniel Gustafsson <daniel@yesql.se>, Nikolay Shaplov <dhyan@nataraj.su>
CC: =?ISO-8859-1?Q?Dagfinn_Ilmari_Manns=E5ker?= <ilmari@ilmari.org>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: TAP output format in pg_regress
User-Agent: K-9 Mail for Android
In-Reply-To: <3F201049-250A-4BE4-9365-36A840C162E3@yesql.se>
References: <5e6bc6a6-0a4e-109d-2b7d-c286dc58d609@enterprisedb.com>
 <20221122235636.4frx7hjterq6bmls@awork3.anarazel.de>
 <C0C46A78-F20A-4C6D-81AE-1205662595D0@yesql.se>
 <1787166.pFkNfHHBAF@thinkpad-pgpro>
 <3F201049-250A-4BE4-9365-36A840C162E3@yesql.se>
Message-ID: <FA463F9F-F4FE-464F-998C-22772176656A@anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/FA463F9F-F4FE-464F-998C-22772176656A%40anarazel.de>
Precedence: bulk


On November 24, 2022 11:07:43 AM PST, Daniel Gustafsson <daniel@yesql=2Ese=
> wrote:
>> On 24 Nov 2022, at 18:07, Nikolay Shaplov <dhyan@nataraj=2Esu> wrote:
>One option could be to redefine bail() to take the exit function as a par=
ameter
>and have the caller pass the preferred exit handler=2E
>
>-bail_out(bool non_rec, const char *fmt,=2E=2E=2E)
>+bail(void (*exit_func)(int), const char *fmt,=2E=2E=2E)
>
>The callsites would then look like the below, which puts a reference to t=
he
>actual exit handler used in the code where it is called=2E

I'd just rename _bail to bail_noatexit()=2E


>> This magic spell "=2E=2E=2E%-5i %s%-*s %8=2E0f ms\n" is too dark to rep=
eat it even two=20
>> times=2E I understand problems with spaces=2E=2E=2E But may be it would=
 be better=20
>> somehow narrow it to one ugly print=2E=2E=2E Print "ok %-5i    "|"not o=
k %-5i" to=20
>> buffer first, and then have one "%s%-*s %8=2E0f ms%s\n" print or someth=
ing like=20
>> that=2E=2E=2E
>
>I'm not convinced that this printf format is that hard to read (which may=
 well
>be attributed to Stockholm Syndrome), and I do think that breaking it up =
and
>adding more code to print the line will make it less readable instead=2E

I don't think it's terrible either=2E I do think it'd also be ok to switch=
 between ok / not ok within a single printf, making it easier to keep them =
in sync=2E

Andres

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E