Feedback-ID: i675e48f3:Fastmail
Date: Tue, 23 Sep 2025 14:26:19 -0400
From: Greg Burd <greg@burd.me>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Message-ID: <FA6E34DD-6956-4CF8-8221-1100987911C6@getmailspring.com>
In-Reply-To: <3097370.1758646009@sss.pgh.pa.us>
References: <3097370.1758646009@sss.pgh.pa.us>
Subject: Re: [PATCH] Add tests for Bitmapset
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="68d2e64b_6b8b4567_89a"
Archived-At: 
 <https://www.postgresql.org/message-id/FA6E34DD-6956-4CF8-8221-1100987911C6%40getmailspring.com>
Precedence: bulk

--68d2e64b_6b8b4567_89a
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


On Sep 23 2025, at 12:46 pm, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Michael Paquier <michael@paquier.xyz> writes:
>> On Tue, Sep 23, 2025 at 01:43:47AM -0400, Tom Lane wrote:
>>> This patch seems to be rather full of arbitrary casts to or
>>> from Datum, which is no longer okay.  You need to be using
>>> the appropriate conversion macros, such as PointerGetDatum.

Tom, thanks for pointing out the oversight.  Apologies, I should have
tried that out in my local tests.

>> Right, this can ve reproduced with a -m32 added to gcc.
> 
> Curiously, I don't see these warnings on 32-bit FreeBSD
> (with clang version 19.1.7).  But I tested your patch on
> mamba's host and confirmed that it makes that gcc happy.
> 
>> I don't see a need for a Datum manipulation in these conversion
>> macros, as we already allocate the results to and from "text"
>> before/after using the GETARG or RETURN macros.  Using directly
>> text_to_cstring() and cstring_to_text() takes care of the warnings, as
>> well.
> 
> Yeah, this is better, but I think the new macros could use a bit
> more parenthesis-twiddling:
> 
> +#define BITMAPSET_TO_TEXT(bms) cstring_to_text(nodeToString((bms)))

Agreed, that was my mistake.

> The extra parens around "bms" are surely unnecessary.  (If they were
> necessary, it could only be because nodeToString was a macro that
> failed to parenthesize its argument where needed.  But that would
> be a bug to fix in nodeToString, not here.)
> 
> +#define TEXT_TO_BITMAPSET(str) (Bitmapset *) stringToNode(text_to_cstring(str))
> 
> Here, on the other hand, I think an extra outer set of parens
> would be a good idea, ie
> 
> +#define TEXT_TO_BITMAPSET(str) ((Bitmapset *) stringToNode(text_to_cstring(str)))

Sounds reasonable to me.

> It may be that the C cast binds tightly enough that this cannot
> be a problem, but I don't think assuming that is project style.
> 
> 			regards, tom lane

patch attached, best.

-greg

--68d2e64b_6b8b4567_89a
Content-Type: application/octet-stream
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="v1-0001-Avoid-triggering-warnings-in-Bitmapset-tests-rela.patch"

RnJvbSBjYTMwMzFiZjFiMDQxODM5YmY2MjllYTQ0ZjU4MzcxNzk2ZTllYmQ1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIEJ1cmQgPGdyZWdAYnVyZC5tZT4KRGF0ZTogVHVlLCAy
MyBTZXAgMjAyNSAxNDoxMToxMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIEF2b2lkIHRyaWdn
ZXJpbmcgd2FybmluZ3MgaW4gQml0bWFwc2V0IHRlc3RzIHJlbGF0ZWQgdG8KIERhdHVtIGNhc3Rz
CgpUaGUgQml0bWFwc2V0IHRlc3RzIGVuY29kZS9kZWNvZGUgYml0bWFwcyB0by9mcm9tIHRleHQg
dXNpbmcgdGhlIGF2YWlsYWJsZQpub2RlVG8vRnJvbVN0cmluZygpIGZ1bmN0aW9ucyBmb3Igc2lt
cGxpY2l0eS4gIFRoZXkgZG9uJ3QgbmVlZCBmb3IgYSBEYXR1bQptYW5pcHVsYXRpb24gaW4gdGhl
aXIgY29udmVyc2lvbiBtYWNyb3MsIGFzIHdlIGFscmVhZHkgYWxsb2NhdGUgdGhlIHJlc3VsdHMg
dG8KYW5kIGZyb20gInRleHQiIGJlZm9yZS9hZnRlciB1c2luZyB0aGUgR0VUQVJHIG9yIFJFVFVS
TiBtYWNyb3MuIFVzaW5nIGRpcmVjdGx5CnRleHRfdG9fY3N0cmluZygpIGFuZCBjc3RyaW5nX3Rv
X3RleHQoKSB0YWtlcyBjYXJlIG9mIHRoZXNlIHdhcm5pbmdzLgotLS0KIHNyYy90ZXN0L21vZHVs
ZXMvdGVzdF9iaXRtYXBzZXQvdGVzdF9iaXRtYXBzZXQuYyB8IDQgKystLQogMSBmaWxlIGNoYW5n
ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvdGVz
dC9tb2R1bGVzL3Rlc3RfYml0bWFwc2V0L3Rlc3RfYml0bWFwc2V0LmMgYi9zcmMvdGVzdC9tb2R1
bGVzL3Rlc3RfYml0bWFwc2V0L3Rlc3RfYml0bWFwc2V0LmMKaW5kZXggNjFmMjU2ZjY1YTQuLjVi
YzRkYWEyM2YxIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfYml0bWFwc2V0L3Rl
c3RfYml0bWFwc2V0LmMKKysrIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X2JpdG1hcHNldC90ZXN0
X2JpdG1hcHNldC5jCkBAIC04NCw4ICs4NCw4IEBAIFBHX0ZVTkNUSU9OX0lORk9fVjEodGVzdF9y
YW5kb21fb3BlcmF0aW9ucyk7CiAJfSB3aGlsZSAoMCkKIAogLyogRW5jb2RlL0RlY29kZSB0by9m
cm9tIFRFWFQgYW5kIEJpdG1hcHNldCAqLwotI2RlZmluZSBCSVRNQVBTRVRfVE9fVEVYVChibXMp
ICh0ZXh0ICopIENTdHJpbmdHZXRUZXh0RGF0dW0obm9kZVRvU3RyaW5nKChibXMpKSkKLSNkZWZp
bmUgVEVYVF9UT19CSVRNQVBTRVQoc3RyKSAoQml0bWFwc2V0ICopIHN0cmluZ1RvTm9kZShUZXh0
RGF0dW1HZXRDU3RyaW5nKChEYXR1bSkgKHN0cikpKQorI2RlZmluZSBCSVRNQVBTRVRfVE9fVEVY
VChibXMpIGNzdHJpbmdfdG9fdGV4dChub2RlVG9TdHJpbmcoYm1zKSkKKyNkZWZpbmUgVEVYVF9U
T19CSVRNQVBTRVQoc3RyKSAoKEJpdG1hcHNldCAqKSBzdHJpbmdUb05vZGUodGV4dF90b19jc3Ry
aW5nKHN0cikpKQogCiAvKgogICogSW5kaXZpZHVhbCB0ZXN0IGZ1bmN0aW9ucyBmb3IgZWFjaCBi
aXRtYXBzZXQgQVBJIGZ1bmN0aW9uCi0tIAoyLjUwLjEgKEFwcGxlIEdpdC0xNTUpCgo=

--68d2e64b_6b8b4567_89a--