Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: RFC: adding pytest as a supported test framework
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20240612155040.u6cvatdb5tiwcxci@awork3.anarazel.de>
Date: Wed, 12 Jun 2024 19:30:33 +0200
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FAC2FCFE-8C70-4996-9598-34DD7596BB41@yesql.se>
References: <CAOYmi+kThkM9Z87u=R_Wi7fCor2i+UZKAyq0UCyprzCwTQvqgA@mail.gmail.com>
 <20240610200411.byj6sv2vpgol6wcf@awork3.anarazel.de>
 <CAOYmi+niQdwFdX7srOiD8zdme_rxEp2m4JGdqzK=+dS6dpV2Og@mail.gmail.com>
 <20240612155040.u6cvatdb5tiwcxci@awork3.anarazel.de>
To: Andres Freund <andres@anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/FAC2FCFE-8C70-4996-9598-34DD7596BB41%40yesql.se>
Precedence: bulk

> On 12 Jun 2024, at 17:50, Andres Freund <andres@anarazel.de> wrote:
> On 2024-06-11 07:28:23 -0700, Jacob Champion wrote:

>> The OAuth pytest suite makes extensive use of
>> - psycopg, to easily drive libpq;
>=20
> That's probably not going to fly. It introduces painful circular =
dependencies
> between building postgres (for libpq), building psycopg (requiring =
libpq) and
> testing postgres (requiring psycopg).

I might be missing something obvious, but if we use a third-party libpq =
driver
in the testsuite doesn't that imply that a patch adding net new =
functionality
to libpq also need to add it to the driver in order to write the tests?  =
I'm
thinking about the SCRAM situation a few years back when drivers weren't =
up to
date.

--
Daniel Gustafsson