Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\))
Subject: Re: Rename of varatt_external to varatt_external_oid
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <apoc0WqBlSeBHIMg@paquier.xyz>
Date: Fri, 4 Sep 2026 14:20:48 +0800
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Andres Freund <andres@anarazel.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FBE0E804-F1F5-4AD5-8A46-445F26B097A7@gmail.com>
References: <apoD1Ulet2PtDrRV@paquier.xyz>
 <1B63EFC9-93D5-4197-8D12-181D8F55ACA5@gmail.com>
 <apoc0WqBlSeBHIMg@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/FBE0E804-F1F5-4AD5-8A46-445F26B097A7%40gmail.com>
Precedence: bulk


> On Sep 4, 2026, at 09:20, Michael Paquier <michael@paquier.xyz> wrote:
>=20
> On Fri, Sep 04, 2026 at 08:43:37AM +0800, Chao Li wrote:
>> I tried to review this patch, but =E2=80=9Cgit am=E2=80=9D failed on =
the current
>> HEAD (2b3d11aaed8). Would you please rebase?
>=20
> Oops.  Sorry for the incorrect rebase blurp caused by 2b3d11aaed89.
> The attached should work better.
> --
> Michael
> <v2-0001-Rename-varatt_external-to-varatt_external_oid.patch>

I briefly went through the referenced patch as well as Tom=E2=80=99s =
comment, so I have no objection to this renaming.

The code changes in v2 look good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/