From: Chao Li <li.evan.chao@gmail.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_03473D25-1D04-4FC6-A941-0861CAA3EEA3"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: heapam_tuple_complete_speculative : remove unnecessary tuple fetch
Message-Id: <FCB61654-575D-4F08-AA7E-ED462EDE48A7@gmail.com>
Date: Tue, 24 Mar 2026 14:56:28 +0800
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/FCB61654-575D-4F08-AA7E-ED462EDE48A7%40gmail.com>
Precedence: bulk


--Apple-Mail=_03473D25-1D04-4FC6-A941-0861CAA3EEA3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hi,

While reviewing another patch, I noticed this:
```
static void
heapam_tuple_complete_speculative(Relation relation, TupleTableSlot =
*slot,
								  uint32 =
specToken, bool succeeded)
{
	bool		shouldFree =3D true;
	HeapTuple	tuple =3D ExecFetchSlotHeapTuple(slot, true, =
&shouldFree); // <=3D=3D tuple is not used

	/* adjust the tuple's state accordingly */
	if (succeeded)
		heap_finish_speculative(relation, &slot->tts_tid);
	else
		heap_abort_speculative(relation, &slot->tts_tid);

	if (shouldFree)
		pfree(tuple);
}
```

In this function, tuple is not used at all, so there seems to be no need =
to fetch it, and shouldFree is thus not needed either.

This appears to have been there since 5db6df0c011, where the function =
was introduced. It looks like a copy-pasto from the previous function, =
heapam_tuple_insert_speculative(), which does need to fetch and possibly =
free the tuple.

I tried simply removing ExecFetchSlotHeapTuple(), and "make check" still =
passes. But I may be missing something, so I=E2=80=99d like to confirm.

The attached patch just removes the unused tuple and shouldFree from =
this function. As touching the file, I also fixed a typo in the file =
header comment.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_03473D25-1D04-4FC6-A941-0861CAA3EEA3
Content-Disposition: attachment;
	filename=v1-0001-heapam_handler-remove-unused-tuple-fetch-in-specu.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="v1-0001-heapam_handler-remove-unused-tuple-fetch-in-specu.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20576c596d20c67a92713da971e01a2b567901b76d=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20<lic@highgo.com>=0A=
Date:=20Wed,=2011=20Mar=202026=2014:14:57=20+0800=0ASubject:=20[PATCH=20=
v1]=20heapam_handler:=20remove=20unused=20tuple=20fetch=20in=20=
speculative=0A=20completion=0A=0Aheapam_tuple_complete_speculative()=20=
fetched=20a=20tuple=20from=20the=20slot=20only=20to=0Afree=20it=20=
immediately=20afterwards,=20without=20ever=20using=20it.=0A=0AThe=20=
function=20only=20needs=20slot->tts_tid=20to=20complete=20or=20abort=20=
the=0Aspeculative=20insertion,=20so=20remove=20the=20unnecessary=20fetch=20=
and=20pfree().=0A=0AAuthor:=20Chao=20Li=20<lic@highgo.com>=0A=
Reviewed-by:=0ADiscussion:=20https://postgr.es/m/=0A---=0A=20=
src/backend/access/heap/heapam_handler.c=20|=208=20+-------=0A=201=20=
file=20changed,=201=20insertion(+),=207=20deletions(-)=0A=0Adiff=20--git=20=
a/src/backend/access/heap/heapam_handler.c=20=
b/src/backend/access/heap/heapam_handler.c=0Aindex=20=
253a735b6c1..f0e2be3e85d=20100644=0A---=20=
a/src/backend/access/heap/heapam_handler.c=0A+++=20=
b/src/backend/access/heap/heapam_handler.c=0A@@=20-12,7=20+12,7=20@@=0A=20=
=20*=0A=20=20*=0A=20=20*=20NOTES=0A-=20*=09=20=20This=20files=20wires=20=
up=20the=20lower=20level=20heapam.c=20et=20al=20routines=20with=20the=0A=
+=20*=09=20=20This=20file=20wires=20up=20the=20lower=20level=20heapam.c=20=
et=20al=20routines=20with=20the=0A=20=20*=09=20=20tableam=20abstraction.=0A=
=20=20*=0A=20=20=
*-------------------------------------------------------------------------=
=0A@@=20-295,17=20+295,11=20@@=20static=20void=0A=20=
heapam_tuple_complete_speculative(Relation=20relation,=20TupleTableSlot=20=
*slot,=0A=20=09=09=09=09=09=09=09=09=20=20uint32=20specToken,=20bool=20=
succeeded)=0A=20{=0A-=09bool=09=09shouldFree=20=3D=20true;=0A-=09=
HeapTuple=09tuple=20=3D=20ExecFetchSlotHeapTuple(slot,=20true,=20=
&shouldFree);=0A-=0A=20=09/*=20adjust=20the=20tuple's=20state=20=
accordingly=20*/=0A=20=09if=20(succeeded)=0A=20=09=09=
heap_finish_speculative(relation,=20&slot->tts_tid);=0A=20=09else=0A=20=09=
=09heap_abort_speculative(relation,=20&slot->tts_tid);=0A-=0A-=09if=20=
(shouldFree)=0A-=09=09pfree(tuple);=0A=20}=0A=20=0A=20static=20TM_Result=0A=
--=20=0A2.50.1=20(Apple=20Git-155)=0A=0A=

--Apple-Mail=_03473D25-1D04-4FC6-A941-0861CAA3EEA3--