Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: bugfix - fix broken output in expanded aligned format, when data
 are too short
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAFj8pRAf1jYo8Nfz=sbfpMfaUBDsb77qGxdR+8JBxTH3_6MnBw@mail.gmail.com>
Date: Tue, 24 Mar 2026 14:12:18 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD1712E1-9646-4438-BD17-97E08CE70BEC@gmail.com>
References: 
 <CAFj8pRCzGpsr9zTHbtTd4mGh2YPJqOEgLgt8JLiopuYA9_1xGw@mail.gmail.com>
 <CAFj8pRAf1jYo8Nfz=sbfpMfaUBDsb77qGxdR+8JBxTH3_6MnBw@mail.gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/FD1712E1-9646-4438-BD17-97E08CE70BEC%40gmail.com>
Precedence: bulk


> On Mar 24, 2026, at 13:46, Pavel Stehule <pavel.stehule@gmail.com> =
wrote:
>=20
> Hi
>=20
> new version
>=20
> * fixed unwanted forcing to wrapped mode
> * regress test
>=20
> Regards
>=20
> Pavel
> =
<v20260324-1-0001-The-output-of-thin-table-is-broken-in-expanded-mode-.pat=
ch>

Thanks for the fix. The patch overall looks good to me. A couple of =
small comments:

1
```
 	/*
 	 * Calculate available width for data in wrapped mode
 	 */
-	if (cont->opt->format =3D=3D PRINT_WRAPPED)
+	if (cont->opt->format =3D=3D PRINT_WRAPPED || cont->opt->format =
=3D=3D PRINT_ALIGNED)
```

Since the condition has been updated, I think the comment above should =
be adjusted as well.

2
```
+-- the output in expanded mode is shorter than header
+\pset border 2
+\pset expanded on
+create table psql_short_tab(a int, b int);
+insert into psql_short_tab values(10,20),(30,40);
+\pset format aligned
+select * from psql_short_tab;
+\pset format wrapped
+select * from psql_short_tab;
+drop table psql_short_tab;
+
```

After this test, does it make sense to turn expanded mode off =
explicitly, in case it affects following tests? Today the next test =
happens to reset it, but maybe tomorrow a new test gets added before =
that point.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/