Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAJ7c6TPCJz-ExBFL8q2dCkXZpUdpm=+wvTF11gDENGk39n3DYA@mail.gmail.com>
Date: Tue, 11 Nov 2025 14:28:43 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Nathan Bossart <nathandbossart@gmail.com>,
 Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
 Bruce Momjian <bruce@momjian.us>,
 Michael Paquier <michael@paquier.xyz>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD184796-6F6E-4D08-9320-9DD89D96B178@gmail.com>
References: 
 <CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw@mail.gmail.com>
 <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
 <CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
 <aFVomQjfkDvtQRwo@momjian.us>
 <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
 <aPqPK4ERy5-jj185@nathan>
 <CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
 <9AD706B0-B73A-4DCC-9A71-F924D8B74F4B@gmail.com>
 <CAJ7c6TPCJz-ExBFL8q2dCkXZpUdpm=+wvTF11gDENGk39n3DYA@mail.gmail.com>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/FD184796-6F6E-4D08-9320-9DD89D96B178%40gmail.com>
Precedence: bulk


> On Nov 10, 2025, at 17:28, Aleksander Alekseev =
<aleksander@tigerdata.com> wrote:
>=20
>> 1. I just ran the patched pgindent against a random file, then I got =
a lot diffs like:
>>=20
>> ```
>>        /*
>> -        * Direct advancement: avoid waking non-caught up backends =
that
>> -        * aren't interested in our notifications.
>> +        * Direct advancement: avoid waking non-caught up backends =
that aren't
>> +        * interested in our notifications.
>>         */
>> ```
>=20
> I'm not sure if this is part of the PostgreSQL code base either. My
> best guess is that something is wrong with whitespaces here (tabs vs
> spaces). We have plenty of multiline comments like this and from what
> I can tell they are processed correctly.

I recalled that. I ran pgindent on a file from a patch I was reviewing, =
so, the file was not pgindent-ed yet at the time.

I just tried to run the patched pgindent on several files and no diff =
generated. So this comment is resolved.

Regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/