Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\))
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CAOYmi+mXoq9dUagnkXDgWa72QjCg8SdagBz_yGPUdh1Px0XD5g@mail.gmail.com>
Date: Wed, 30 Apr 2025 20:09:28 +0200
Cc: Christoph Berg <myon@debian.org>,
 Jelte Fennema-Nio <postgres@jeltef.nl>,
 Peter Eisentraut <peter@eisentraut.org>,
 Andres Freund <andres@anarazel.de>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Bruce Momjian <bruce@momjian.us>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>,
 Nazir Bilal Yavuz <byavuz81@gmail.com>,
 Antonin Houska <ah@cybertec.at>,
 Wolfgang Walther <walther@technowledgy.de>,
 =?utf-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FE299814-66B2-47B4-8F06-2B6A7AB508EF@yesql.se>
References: <Z_ayCLeAEinXvSxL@msg.df7cb.de>
 <CAOYmi+n9DHS_xUatuuspdC8tjtaMzY8P11Y9y5Fz+2pjikkL9g@mail.gmail.com>
 <f47ce2cb-4076-46f3-be2e-60fa4dd70f41@eisentraut.org>
 <CAOYmi+=2cArQoSSRdAYwx2TBSHL5r0UhX28Q-5TP=0g-sxBXCA@mail.gmail.com>
 <CAGECzQShbNtypPqabVv2eKJP=0Ejox=6f8k8G1E-2GN6Ag1kAA@mail.gmail.com>
 <CAOYmi+=j9nLQFjQ8z0vyQmuhNMwsFbzvne_2S2pTbBGir4q6EQ@mail.gmail.com>
 <aAOREVWMFTuWvJ1l@msg.df7cb.de>
 <CAOYmi+k9uN2OQ_sXjztZYPSpPbfGmkkv4yhtPhyjNQ6vy7SSfA@mail.gmail.com>
 <aAkJnDQq3mOUvmQV@msg.df7cb.de>
 <CAOYmi+=WA4ZfyHWt+4=yFV7VAXQWvNKsn4R=3PwLd4GfmSTiBA@mail.gmail.com>
 <aAkXb1wdZUDycyWi@msg.df7cb.de>
 <CAOYmi+=cs+gDTAH0L+3JzpRLeHPOXDQxu7MOfsbjah9SkAP_kw@mail.gmail.com>
 <CAOYmi+=UsSnLM4K+hYkhrezpQROQ5jr=72feAkQ0Te8GJf3Fbg@mail.gmail.com>
 <8210C830-DDBB-4CD7-AB39-F5F59C36D547@yesql.se>
 <CAOYmi+mXoq9dUagnkXDgWa72QjCg8SdagBz_yGPUdh1Px0XD5g@mail.gmail.com>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/FE299814-66B2-47B4-8F06-2B6A7AB508EF%40yesql.se>
Precedence: bulk

> On 30 Apr 2025, at 19:59, Jacob Champion =
<jacob.champion@enterprisedb.com> wrote:
> On Wed, Apr 30, 2025 at 5:55=E2=80=AFAM Daniel Gustafsson =
<daniel@yesql.se> wrote:

>> Nitpick, but it won't be .so everywhere.  Would this be clearar if =
spelled out
>> with something like "do not rely on libpq-int.h when building =
libpq-oauth as
>> dynamic shared lib"?
>=20
> I went with "do not rely on libpq-int.h in dynamic builds of
> libpq-oauth", since devs are hopefully going to be the only people who
> see it. I've also fixed up an errant #endif label right above it.

That's indeed better than my suggestion.

> I'd ideally like to get a working split in for beta.

+Many

> Barring
> objections, I plan to get this pushed tomorrow so that the buildfarm
> has time to highlight any corner cases well before the Saturday
> freeze.

I'll try to kick the tyres a bit more as well.

--
Daniel Gustafsson