Date: Fri, 1 Aug 2025 13:53:33 +0800
From: Japin Li <japinli@hotmail.com>
To: Euler Taveira <euler@eulerto.com>
Cc: Andres Freund <andres@anarazel.de>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org
Subject: Re: log_min_messages per backend type
Message-ID: 
 <ME0P300MB04454F2F47351AEC1A1B8C12B626A@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
References: <202502051851.2nvzh3a6ukzc@alvherre.pgsql>
 <313aa202-b5fa-4e3f-95d0-83425575c66d@app.fastmail.com>
 <y5tgui75jrcj6mm5nmoq4yqwage2432akx4kp2ogtcnim3wskx@2ipmtfi4qvpi>
 <c0135750-48d8-4a13-9b7c-426f27888e9b@app.fastmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c0135750-48d8-4a13-9b7c-426f27888e9b@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: ME0P300MB0445:EE_|CB2P300MB1581:EE_
X-MS-Office365-Filtering-Correlation-Id: 25a314ef-0bf2-40ef-97ad-08ddd0bfc35c
X-MS-Exchange-SLBlob-MailProps: 
	EgT5Wr3QDKwnrVpDQWFAOn/Q3AQFDxfrdzph/mkaLZj3RreCW0KAKE29Gc/2ysORUugE9sgHeMPB4ONebhrrrJHU8CpgX4OJmKL+ka1oVkouujvZzbFHQC5FfDj5gof17/GyIKBwQVGqlOIxeBH0EOXILWZ2rD45LZsEhO2OnzPUgAFG6LFSf7bIwhWgJ2Xb9hhsqJWnikq+10aJC9x6fCx8LyRJM+stIiEZHRZpokDsKr4y1pXfIakEYMFJhBpxXCnNVSH86WRMT/dxyHWLNgoqLIYimdfrb8R9s4s5nSPp9udsB92crFzeZDg5Jw7QU/XmkEXajzl2ytZmCwlI9tpJN/Rg6KL7q1Z9OumWeRdRLmOWUapzVLYDb/fPAuSN5hEAX8d4S2wsDdY/zlVzHt6pFDUAJUYmc+FNplifMJ3czNlssHt7GQXmMzwozk5mjsQISpHDYcG7OqtHLgX3+Tq/IHdyQ8chMQVW1SRU0P99WqeJyLz0PsFQG2Eln1JxjA7GMA6Bm7t/MfnNTxQ2uBpbPoPpYbWi4AEFqPItedi4DbqmuqDVpYmzCIRxuH9xvpFTcjoakcHhWGaMKg+HCZXbtNX3SpwmLj6Ox7RHqMZOOOTbCtteYjSGEh9AQU0cZhywP660180DsrBUkiB4WpxgFSON05X134wuIBKCYcyTdXFoUzSfFwxtqKbKbbtMcBJze9lw07BQzvXD8AEDXoS04Xc7n7I31UY7WM8RhNA=
X-Microsoft-Antispam: 
	BCL:0;ARA:14566002|15080799012|8060799015|19110799012|461199028|5072599009|6090799003|40105399003|51005399003|440099028|3412199025;
X-Microsoft-Antispam-Message-Info: 
	=?us-ascii?Q?Ltx5dSLZYJWLyQmwbOVzB/ol1kYJbTLP+6Wn6r32e6ftS73XmOLNbxek5fCS?=
 =?us-ascii?Q?3CtvZLa2tjWpDSMSuLWFkqeO9M+6QnkcDhiGihXussdxzTSBVGzh29q7xuVe?=
 =?us-ascii?Q?N9v2hF2UjGC5JNX687jB26b2FZSVVkKhf9tKc0eRIyHBKsvqY8LwGIsrGQ10?=
 =?us-ascii?Q?RX9GDx721N1c5HuegoskNV+ek//a8m57CJ5hV6xBSyfiogtIxeITL17xGzJV?=
 =?us-ascii?Q?sQEST/or2J00ot7lqdh9i9HN73/5KoR4yaG0cjgs7Xn4UzBjDxbp3vgZT5lf?=
 =?us-ascii?Q?c6BvdUoL1G+bPJ7sjYImptFTlF0MvW+z9q26y47D9tUy8/1l1MDI+ADvt9Av?=
 =?us-ascii?Q?YSzDKwaSUouHyvrQF0Siywix4D+46KGZWTKUtIrkjRIKYGn1Fiozvn989qIl?=
 =?us-ascii?Q?kwyuWekYDY22sCWxX3KJ7y2QCddHKxs1E8Auq2lygRl9vaaSfg6AmEEG73P1?=
 =?us-ascii?Q?B1Jaqx6mXKLL889ROWdaRjZ11zHYSxppBF669jfiNjVxN9joXINh6z51IEvi?=
 =?us-ascii?Q?9f7LD9ar+0qp20USJ+G8KhFpcBhf19o3XcIdE8IWnfEljCydHugx0FlOfwo8?=
 =?us-ascii?Q?zJ+FSi+ovpHa2TNecF5/XMDhRp9/XPMJJK2S4lp5G4riGkOTSXbbNzDmzI+c?=
 =?us-ascii?Q?/VPOAslNt/HWFYYCT+LWw3fhT16rmfSRNgNsfs7yoBqo3s70jkh+eaanK0Oy?=
 =?us-ascii?Q?qEFd9vdvH5nUAMM0Y/x7XdCMlyNBHkRFd5BQQEtyMrwpPmhiZSW26tAaEiCW?=
 =?us-ascii?Q?heKKzRC1RvVl4TmM1xXemjKk4Z6ctb5TBD6MkxOa8smJqAp72QrMGVSFk/Vz?=
 =?us-ascii?Q?BuDqrUl5iYzjNqYuVZypqwqANZoIIPnpl7DyFuuepfgN8yTtRx1IbYnftiwr?=
 =?us-ascii?Q?rjsIW40btY65+hxiH99LrFc7wNmxdwu0bTJ97Oto9YrqH6M6SQ950Th+Mdei?=
 =?us-ascii?Q?OcnDe9WONY0qLM69A8SpS2il2Yb6F4oRJ419qVkLKglwfkSvAEZBT2RTmMqu?=
 =?us-ascii?Q?KafBcY4Cg4JArhgTioV3eZ325g6hPQmI+Z5gGHmjxjqEwxkBdc1vVD40HQ3N?=
 =?us-ascii?Q?hSEU3/0v/O2YXNc0GVjEI2bYxSM0FE1ipnJmCibumr7vscvjl4T/4b5N3ZMH?=
 =?us-ascii?Q?F+BGF7c0jfDdruefUuy63t7FaizrCiB2+EV0WD77XfMhZOEZO9Sj24Q=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?/aY2J0Ai7+XOxbZHcOYyiRV+pi6863blzCAa5TUxUQRmloGTRSQE43DmmV7/?=
 =?us-ascii?Q?RhyGbnYZXa4YjyparZGtWWDdMIY0gWTsnxl82vhRXMHD07uiQjwow3o9KOoS?=
 =?us-ascii?Q?sM5ymqpnfkHHs68VWBkwdXh5QwkkutdbP8oE73e9zgfBxRg/9eoBtLrIAG16?=
 =?us-ascii?Q?LL7Gte9EJqQ6hyzopg3LTJpkGYE+BsLnbWWZ09VorOq9DSG0R1oMoyqy5Jxr?=
 =?us-ascii?Q?tNvLA6czLwgryh2eMG2CqXhGBwvtE3pYMuSN0pmiNn6cF5IVQ/BFFA7yYrY9?=
 =?us-ascii?Q?p4H8+7gERh9aWlbNpTM60np/nmVOZyJKxf+8QEk2uWUnXI3UdX72ZembK57v?=
 =?us-ascii?Q?Y49WqZYhtZGo34s3i3CZG6x1fv/geaK/aBvs+aGnN0Af/kJcRhUDmAkVZtMX?=
 =?us-ascii?Q?Wj82SDhxBbzb7KDM5jkx4F7NwuYkfeP+C5P8S/NbQQxVVPEZ1BOaRUdCx+id?=
 =?us-ascii?Q?lqRBl0vHqHdCbZ4Tr1rbWFpGD+SR9mRf0TzR0o3nZx9TTxD32f7ej3/n6puS?=
 =?us-ascii?Q?QuwiN8Z7ZrLNmCX+odOfk53OSrmwXa4d5TdikLkzIoKKnthIBjRdQuDeU8Yr?=
 =?us-ascii?Q?FTglbncN3sgkOSwOXTR14mhX0afA9VgTBEV7nCDKwemy9vzNeCLjo7P4UT7g?=
 =?us-ascii?Q?jX4GcgnXP6TK/usfIz/WARTf2ENEGLpMJhFRi5HtknBbtJerjGoYrOBdWCNc?=
 =?us-ascii?Q?8bCY2JEFEgVpskJ1jxTSP8q54zYoX8YCdB4BdT9325ffOmb1H/MDuAVcLXft?=
 =?us-ascii?Q?EfpQiA5HM1likDwqthozN3cK8uQ5pH0lK9QxIhATVp9cmMLyUmQ+kBiHaksH?=
 =?us-ascii?Q?pvfPAc6R8mBIukxJQlbLegKnaSiplWK8rai+NMmMZcZKCRtmm31wfYPF0Ma+?=
 =?us-ascii?Q?27kEbP+l7NDaAUzvFw3PiTTvkRMg82pKhjxISwb5nKpHWWjI7UvfNBrv9aAh?=
 =?us-ascii?Q?foYhebNhKyWMN5auJlvh0FJxHMRFkj4l3NArwFOcyLrQ7rDDfDxCmgbZTcYv?=
 =?us-ascii?Q?aNA4YG6R1LSyO6mJpG+ORhOnw4IVWj6RxZXiBUoRQ0DfX8Qlg8Ys9LlJZe2n?=
 =?us-ascii?Q?GPvLUSY2cnHeFrYydiiuiZHQwueBf6MT6DmY7Ht1KKl1Lr+NjLtsLHxxnLsP?=
 =?us-ascii?Q?gmPk2fShA5pCYThqE0WvJXvZ8U6g1QadIAmuy+RbzUBrBctQ2OV0XMzW29DB?=
 =?us-ascii?Q?nT/Um+IiAQs4Pm4YVnS0Bf7jXqrNqP2TwpvlJyMPLajiV2oLDPmswOawqsc?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-fb8bf.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 25a314ef-0bf2-40ef-97ad-08ddd0bfc35c
X-MS-Exchange-CrossTenant-AuthSource: ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2025 05:53:39.5997
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CB2P300MB1581
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ME0P300MB04454F2F47351AEC1A1B8C12B626A%40ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
Precedence: bulk

On Thu, Jul 31, 2025 at 11:19:48AM -0300, Euler Taveira wrote:
> On Thu, Mar 6, 2025, at 10:33 AM, Andres Freund wrote:
> > Huh, the startup process is among the most crucial things to monitor?
> >
> 
> Good point. Fixed.
> 
> After collecting some suggestions, I'm attaching a new patch contains the
> following changes:
> 
> - patch was rebased
> - include Alvaro's patch (v2-0001) [1] as a basis for this patch
> - add ioworker as new backend type
> - add startup as new backend type per Andres suggestion
> - small changes into documentation
> 
> > I don't know what I think about the whole patch, but I do want to voice
> > *strong* opposition to duplicating a list of all backend types into multiple
> > places. It's already painfull enough to add a new backend type, without having
> > to pointlessly go around and manually add a new backend type to mulltiple
> > arrays that have completely predictable content.
> >
> 
> I'm including Alvaro's patch as is just to make the CF bot happy and to
> illustrate how it would be if we adopt his solution to centralize the list of
> backend types. I think Alvaro's proposal overcomes the objection [2], right?
> 

I think we can avoid memory allocation by using pg_strncasecmp().

diff --git a/src/backend/commands/variable.c b/src/backend/commands/variable.c
index 5c769dd7bcc..f854b2fac93 100644
--- a/src/backend/commands/variable.c
+++ b/src/backend/commands/variable.c
@@ -1343,14 +1343,10 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 		}
 		else
 		{
-			char	   *loglevel;
-			char	   *btype;
-			bool		found = false;

-			btype = palloc((sep - tok) + 1);
-			memcpy(btype, tok, sep - tok);
-			btype[sep - tok] = '\0';
-			loglevel = pstrdup(sep + 1);
+			char	   *btype = tok;
+			char	   *loglevel = sep + 1;
+			bool		found = false;

 			/* Is the log level valid? */
 			for (entry = server_message_level_options; entry && entry->name; entry++)
@@ -1377,7 +1373,7 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
 			found = false;
 			for (int i = 0; i < BACKEND_NUM_TYPES; i++)
 			{
-				if (pg_strcasecmp(log_min_messages_backend_types[i], btype) == 0)
+				if (pg_strncasecmp(log_min_messages_backend_types[i], btype, sep - tok) == 0)
 				{
 					/* Reject duplicates for a backend type. */
 					if (assigned[i])

-- 
Best regards,
Japin Li
ChengDu WenWu Information Technology Co., LTD.