public inbox for [email protected]  

help / color / mirror / Atom feed

From: Japin Li <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Remove unused <poll.h> header file in pqcomm.c
Date: Thu, 27 Feb 2025 14:34:24 +0800
Message-ID: <ME0P300MB04458874441B6CC8D0B34C80B6CD2@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM> (raw)


Hi, all

When I read the code of pqcomm.c, I find we don't use anything from <pool.h>
after commit cba5b994c99.  Maybe we should remove the include instruction.

diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index e5171467de1..744699ec35a 100644
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -53,9 +53,6 @@
  */
 #include "postgres.h"
 
-#ifdef HAVE_POLL_H
-#include <poll.h>
-#endif
 #include <signal.h>
 #include <fcntl.h>
 #include <grp.h>


-- 
Regrads,
Japin Li

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove unused <poll.h> header file in pqcomm.c
  In-Reply-To: <ME0P300MB04458874441B6CC8D0B34C80B6CD2@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox