public inbox for [email protected]  

help / color / mirror / Atom feed

From: Japin Li <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Remove unnecessary forward declaration for heapam_methods variable
Date: Wed, 31 Jul 2024 10:36:11 +0800
Message-ID: <ME0P300MB04459456D5C4E70D48116896B6B12@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM> (raw)


Hi,

I think the forward declaration for heapam_methods variable in heapam_handler.c
is unnecessary, right?

-- 
Regrads,
Japin Li



Attachments:

  [text/x-diff] v1-0001-Remove-unnecessary-forward-declaration-for-heapam.patch (891B, ../ME0P300MB04459456D5C4E70D48116896B6B12@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM/2-v1-0001-Remove-unnecessary-forward-declaration-for-heapam.patch)
  download | inline diff:
From 77a6957e94692b3c4c9437c69cdbcb48ea53f3ee Mon Sep 17 00:00:00 2001
From: Japin Li <[email protected]>
Date: Wed, 31 Jul 2024 10:01:04 +0800
Subject: [PATCH v1 1/1] Remove unnecessary forward declaration for
 heapam_methods variable

---
 src/backend/access/heap/heapam_handler.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 6f8b1b7929..e28047c201 100644
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -56,8 +56,6 @@ static bool SampleHeapTupleVisible(TableScanDesc scan, Buffer buffer,
 
 static BlockNumber heapam_scan_get_blocks_done(HeapScanDesc hscan);
 
-static const TableAmRoutine heapam_methods;
-
 
 /* ------------------------------------------------------------------------
  * Slot related callbacks for heap AM
-- 
2.43.0

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove unnecessary forward declaration for heapam_methods variable
  In-Reply-To: <ME0P300MB04459456D5C4E70D48116896B6B12@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox