public inbox for [email protected]  

help / color / mirror / Atom feed

From: Japin Li <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Remove unnecessary static type qualifiers
Date: Tue, 08 Apr 2025 16:29:04 +0800
Message-ID: <ME0P300MB0445C44B2DEC2FC9CEFC23E1B6B52@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM> (raw)


Hi, all

When I read the libpq source code, I found unnecessary static type qualifiers
in PQsetClientEncoding().

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 0258d9ace3c..300ddfffd55 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -7717,7 +7717,7 @@ int
 PQsetClientEncoding(PGconn *conn, const char *encoding)
 {
 	char		qbuf[128];
-	static const char query[] = "set client_encoding to '%s'";
+	const char	query[] = "set client_encoding to '%s'";
 	PGresult   *res;
 	int			status;
 


-- 
Regrads,
Japin Li

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove unnecessary static type qualifiers
  In-Reply-To: <ME0P300MB0445C44B2DEC2FC9CEFC23E1B6B52@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox