User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Typo about the SetDatatabaseHasLoginEventTriggers?
Date: Tue, 16 Apr 2024 14:05:46 +0800
Message-ID:
 <ME3P282MB316611A2F7BF43919F695228B6082@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: ME3P282MB3166:EE_|ME3P282MB0929:EE_
X-MS-Office365-Filtering-Correlation-Id: 8e1a3237-7906-4fbf-bd7e-08dc5ddb47ec
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xExeqv5sAAHr1cBVTtjjyiMoHXHkM3ObQ5dlxxB0HCz5+kQaJnr+twpZTchDn2raiRgBaRddRps1rFayu5DEZFkPA6DmS+RQr8dyoQFacK2OI9LWuDq7p5yZ52ZcqUB+XjbnLY0/Uvf5kcUHnNAcGsZOgVxjGmjTYjyNJ+ny81qddUOdP997EE+jZW+9oZEbwNgxxWNLlzKJF1Ixd4s8xjwwMD6B2pbdYBJN4TlxfLclN52yXZPRIZvgGE9ny1HSBMwiYJFbgG60+wUa4YgYDWDnVIu7PpCqZjpbCaOt2OJY1LrOq8Fzr8WB8jBYZaBj4PTeMiILf2/Z1E6SaIZW0gZLyqRg3zS/tCbr6FO5mqcOHDnE1LuGkQcsk+5lU9N4Zh4bN/bQXWeYJbZb/BCPmr4mP2edjCLCjBI82lX12JuyDhIYFiKltwCo7Uy8zsdKz5py+vcHP23wLETF5Bkq9uSaa9mZK6e96mMwHfwR393dhuw07Mb0LR+AKytvp1unb2O5agcvmCFvNXhLvv+ZlT0UKNDITy1Ez3OkDbKpsABMpw5hOHTUmL6Xra5rQzUi
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qEJDjWS5ViL4+QEWSoK5caxSf2asX3VFSqhlIYVn3XPe6hxn4YrZj/0oBesL?=
 =?us-ascii?Q?SYeX6h/XsZ/XrCKM4G7xuaxp+4bT1fJw5IXRX1k/y80n8GeqYD5rrEyqwUT0?=
 =?us-ascii?Q?zTIRIZDTASuozSJJmlFNtOd0XAmB2qjpVcuLGWrx/AdtxFLdaf5mSGUuUMCK?=
 =?us-ascii?Q?Lq/wfsFVkTVdArFmjv35GvDwfOMaRECQ1IDnwgJ0VlkCJQBvtiY+TqU6YfKb?=
 =?us-ascii?Q?ZhlMtAq2yDSfJ6xfp34kBIy5UBYoZxFDjHs958NhpDEM3Zj/lwp7KUsfZDoe?=
 =?us-ascii?Q?o/wEiXr6xNBEmun7hi5jgEyfrhjucck8yK6J3xDKqZRjVSLK6LLy8V7j/9Nh?=
 =?us-ascii?Q?rEAa96p9HL0ehvQILpjjZLEVSHMgmEk5/ofE4drq1rswrIowqqmgeKaIuQLP?=
 =?us-ascii?Q?j+V653VSM8Agicg8yVzyMxbw3BV2xDo95MthqKQbcVpKaf8U3RIQ4uXADYzo?=
 =?us-ascii?Q?NlZxeEClpJuJBMdeAfT0hKjNQbaRLeZIpfU9MI0wp7h41U1UrWBwFqsgrxry?=
 =?us-ascii?Q?+1E2MFLjUaqysqxHR0vkNUbbVVwTBzUL03ge8UPWSP0ws88klJCbHtiI7CMJ?=
 =?us-ascii?Q?zrspEdl0m/z065IrufBOLm/AaXjExRMSo92p9KsDWcxRw4ojbIb4aNkYyADF?=
 =?us-ascii?Q?vOnrzh6x4m/OhVh3wBaTu8SjJf7EVI1Yl3MM5zEtlW0TaJd2lchj+RVKbCMf?=
 =?us-ascii?Q?PULeA1qJpthGGjOTfiRLZbk6kghh8fBVFH+sBIQhqnD7pkJpvLJizqFWHzvX?=
 =?us-ascii?Q?b/l3f8EDAtmHlTA1xhlTFnMTQZRk0HYgocvmPi2nFHRfAnxmj8ifwtqLvOhD?=
 =?us-ascii?Q?1TLBQk1arcK9r7iez4ZtIAlsuPs40OKGzZSKywUxDWjDM9YIVCq0Sqa2hfJ7?=
 =?us-ascii?Q?RIIZ8vV6Uxi6DWmYkt4YyDLbVNYptbHq3Ntu3AK7EVznYLY0LsVvidojpg3Y?=
 =?us-ascii?Q?pY5WfiQ9XGMo6RkyuNvlHNGJtkE9OtZ4Z9SFv9lHjATJylFU1L6Tf6yR2imP?=
 =?us-ascii?Q?Lf3nJeZ4YX1/ciHC+FgZWBs/dEbZFLj8PblJrGIZFuQLkS+XWR/9fWg0PHZK?=
 =?us-ascii?Q?Gct3ob2qH8T2ZOw/KrBZweCIJia9u+Lan8Zi9s4/oTSwoIKyb0Cf4rKRoVkp?=
 =?us-ascii?Q?QMT1f4D1E7NgCy3sUso2L0k0tWTI0FInvm6R7iwYy7GpRnZpMeXjpavPoj6P?=
 =?us-ascii?Q?Shf8a9F33+CKUtcO8wKlIfyQVPowjshW0FLLlPlza7LI2jJw3CvzXFWQP7U?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e1a3237-7906-4fbf-bd7e-08dc5ddb47ec
X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 06:05:57.5166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME3P282MB0929
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/ME3P282MB316611A2F7BF43919F695228B6082%40ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


Hi,

Upon reviewing the login event trigger, I noticed a potential typo about
the SetDatabaseHasLoginEventTriggers function name.

diff --git a/src/backend/commands/event_trigger.c b/src/backend/commands/event_trigger.c
index 0d3214df9c..7a5ed6b985 100644
--- a/src/backend/commands/event_trigger.c
+++ b/src/backend/commands/event_trigger.c
@@ -111,7 +111,7 @@ static void validate_table_rewrite_tags(const char *filtervar, List *taglist);
 static void EventTriggerInvoke(List *fn_oid_list, EventTriggerData *trigdata);
 static const char *stringify_grant_objtype(ObjectType objtype);
 static const char *stringify_adefprivs_objtype(ObjectType objtype);
-static void SetDatatabaseHasLoginEventTriggers(void);
+static void SetDatabaseHasLoginEventTriggers(void);

 /*
  * Create an event trigger.
@@ -315,7 +315,7 @@ insert_event_trigger_tuple(const char *trigname, const char *eventname, Oid evtO
 	 * faster lookups in hot codepaths. Set the flag unless already True.
 	 */
 	if (strcmp(eventname, "login") == 0)
-		SetDatatabaseHasLoginEventTriggers();
+		SetDatabaseHasLoginEventTriggers();

 	/* Depend on owner. */
 	recordDependencyOnOwner(EventTriggerRelationId, trigoid, evtOwner);
@@ -383,7 +383,7 @@ filter_list_to_array(List *filterlist)
  * current database has on login event triggers.
  */
 void
-SetDatatabaseHasLoginEventTriggers(void)
+SetDatabaseHasLoginEventTriggers(void)
 {
 	/* Set dathasloginevt flag in pg_database */
 	Form_pg_database db;
@@ -453,7 +453,7 @@ AlterEventTrigger(AlterEventTrigStmt *stmt)
 	 */
 	if (namestrcmp(&evtForm->evtevent, "login") == 0 &&
 		tgenabled != TRIGGER_DISABLED)
-		SetDatatabaseHasLoginEventTriggers();
+		SetDatabaseHasLoginEventTriggers();

 	InvokeObjectPostAlterHook(EventTriggerRelationId,
 							  trigoid, 0);
@@ -925,7 +925,7 @@ EventTriggerOnLogin(void)
 	/*
 	 * There is no active login event trigger, but our
 	 * pg_database.dathasloginevt is set. Try to unset this flag.  We use the
-	 * lock to prevent concurrent SetDatatabaseHasLoginEventTriggers(), but we
+	 * lock to prevent concurrent SetDatabaseHasLoginEventTriggers(), but we
 	 * don't want to hang the connection waiting on the lock.  Thus, we are
 	 * just trying to acquire the lock conditionally.
 	 */
--
Regards,
Japin Li