public inbox for [email protected]
help / color / mirror / Atom feedFrom: Japin Li <[email protected]>
To: Ishaan Adarsh <[email protected]>
Cc: [email protected]
Subject: Re: [DOC] Introducing Quick Start Guide to PL/pgSQL and PL/Python Documentation
Date: Tue, 19 Dec 2023 22:10:53 +0800
Message-ID: <ME3P282MB31667752995127EDF49B7CDCB697A@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CA+oefZ6-Y8tuVs6W6=Rt5fZMtjR98VVEM+5SE2=9eaavYpO9Kw@mail.gmail.com>
References: <CA+oefZ72dLzRzgDe0VU01b7m4+A2bkQnZfXSuvXSzV7QHm0R3Q@mail.gmail.com>
<ME3P282MB3166D4DC73DF9EA86BDE0C49B697A@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
<CA+oefZ6-Y8tuVs6W6=Rt5fZMtjR98VVEM+5SE2=9eaavYpO9Kw@mail.gmail.com>
On Tue, 19 Dec 2023 at 17:57, Ishaan Adarsh <[email protected]> wrote:
> I've addressed the points you raised:
>
> 1. *Missing `<filename>` Tag:*
> I reviewed the "Create the Makefile" section, and it seems that <filename>
> tags are appropriately used for filenames. If there's a specific instance
> where you observed a missing tag, please provide more details, and I'll
> ensure it's addressed.
>
Thanks.
> 2. *Use `CREATE EXTENSION` in "extension--version.sql":*
> Considering that there's already a CREATE EXTENSION step in the quick
> start guide, I can include a note in the general documentation to explain
> the rationale without repeating it in the individual script. What do you
> think?
Agreed.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [DOC] Introducing Quick Start Guide to PL/pgSQL and PL/Python Documentation
In-Reply-To: <ME3P282MB31667752995127EDF49B7CDCB697A@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox