References: <CAFcNs+pcU2ib=jvjNZNboD+M2tHO+vD77C_YZJ2rsGR0Tp35mg@mail.gmail.com>
 <ZRTR7uKogg3YLTFZ@paquier.xyz>
 <CAGECzQR0OExsrx33nBkySPkDShSn-izcz+JhVrqTrJwRfAQm6w@mail.gmail.com>
 <CAJ7c6TM3=tnDYAWyyvRB6UdeoafXaPPMq+XpafW+ZBcOnkg1gA@mail.gmail.com>
 <CAGECzQQwNZ2sKh+Qfx1X+=ODEfx+9V0ig6CsmBwOOs2CAy+kmQ@mail.gmail.com>
 <ZaYM4jR7lDS_A4Ii@paquier.xyz>
 <CALj2ACWYQbU4_6UA5p24Vc5UKnp11sFh0E7qefqcJX2RaE-Rnw@mail.gmail.com>
User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Jelte Fennema-Nio
 <postgres@jeltef.nl>, Aleksander Alekseev <aleksander@timescale.com>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>, =?utf-8?Q?Fabr=C3=ADzio?= de
 Royes Mello
 <fabriziomello@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Add test module for Table Access Method
In-reply-to: <CALj2ACWYQbU4_6UA5p24Vc5UKnp11sFh0E7qefqcJX2RaE-Rnw@mail.gmail.com>
Date: Tue, 16 Jan 2024 14:15:21 +0800
Message-ID:
 <ME3P282MB3166E4BA9602E4FFC977BE52B6732@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: ME3P282MB3166:EE_|SY4P282MB0794:EE_
X-MS-Office365-Filtering-Correlation-Id: 3d6fbe63-adfe-4edd-90b4-08dc165a8819
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jy2Vk2d0RGu/P+2rtv/RPa0W5XjyZ9/DjpTGuRFpCl2t+S9sUsjdyES9vczz0CU1R7shnJ+OJKBvKE1w0IsoWqIr/ja6Bv2eA0sfuBZEy4V5FNEOvvMMxHElhz2AAuy4wc+9b0arCM/sIAHxzndJxybCrD9tjuLDrz9pCZkRLIQtpVZDbujYMr0WrqNi/qQuGCJWpyKK/QIhR1Z51vt6ywoPd9gPmL2uphe+Z1C2rC2dhCvMX5YKFEqXob+0cfXpbT3YQ84MoU4+/pD6GjcAuU3fpl9qXhXDtu+Jxu+leU729go4aeErfr+0Bf7WrnHOFals60GOdpaj3AnIeSeYpNi3QFxrV8uYAj/e7A5upDJvtZIunS8W60KzftDdcCMsWs+q+L4MGVkbRFPX2L/g+uFwlqIKmVHx8H1MNGB/1PvS24g/OPIdyZulIP4UpOtWrAr9Zo4Ttgqjpg7/iFoK65w2tzpIZo8g3gsEsNA6IiIvUfUkbcFElokn8Nx858X1fcC4qEGzPiSJISbl1ANhPzZxwdr6nt4k/yzWtzoOBiOE8IjOte1V5LCsHa1nKsDS
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0dkUGtqaVk1ODNqbHF0RjBMS1hHbmZraUJDQytFNTVXdmF0TUpvQml1VkQ2?=
 =?utf-8?B?TWh0dWpMaGV1M0JXMm5tS3JCbGQ2YkZJY0lsTEZoZHdBOXpLSzh6d2ZJQmdM?=
 =?utf-8?B?UVFuR0ZISTREOFhNOXhmaFRISFEwOEk2RE5ORW5QMTNVRlpUNHVBSmxhUXdm?=
 =?utf-8?B?WS8rajRBMWlLa3liZndwZ2ZzdnJGN2wyV2ZtRmJKa3J3ZlJUd1NRd05Rcmls?=
 =?utf-8?B?cmx5M0d1dlg1Zk5zdCtlMUhpMUpITHc3aG1BRGplbnFjQmE2NE05Qy93NUtL?=
 =?utf-8?B?U3lFbFIvMnVyanF5cE44eisyZ3cxRzZHL01xVUhpS29vTUk4Q1BrMkVBMTc4?=
 =?utf-8?B?ZDRyR0MvWTROSmRxM1ZlYjNEeGJ0ekFDNml6VmRHeHdKaXMwNk81bnEzYWNz?=
 =?utf-8?B?SXZuYXdpTGMyRUVOMHhTWUsxL1BZQ3E1d0RLN1labWE2RDdHQlJpTmpzQzF5?=
 =?utf-8?B?b3Q0eUJudE1lazlndm5xRkFkRWRSUDY5UzVvNW01UFJNM2pMa2xNVVFzaXJo?=
 =?utf-8?B?cCtKdVVVSjIwWjhKcnhBQ3A5R3kxdU9UQ1JCdkQwTmJVWVhHaWNDQUh4cVRm?=
 =?utf-8?B?VU90YzJzUXQza3M4T2Vrc3N5ZzRxajcwbFV1bVFLSEJDRm1pVU9jRGVsL1B5?=
 =?utf-8?B?NEcxRklod0Z5bjJkUUh2a2xGVWx0S0QrRStpNmt4ZHhaRjlkakpYK0JrQWF5?=
 =?utf-8?B?QXdVbkxaMDV6NjJhRkE4eWVZVEpwR0FKWHBmUEphTVQwbll0ckR5ZUxiOVkx?=
 =?utf-8?B?akR3YlV1VmhHZEFES21CNzJxQUNVNDRCTGxiTWJtMjR2MUFlNC91UjlvaXVw?=
 =?utf-8?B?NGkwOWl2MXZyTXlQQTRvZ3ptYTlSbEwvaVVOZWYzMFJRazlaK204TXpHNTZY?=
 =?utf-8?B?T1cybzFuQnJMYWxBUDFQRjVPWlN4MFZsNGtldzQrRGN6Q1ZzTnh4QmpYY3Qz?=
 =?utf-8?B?b3dDSDJSNkhLb1hUUFJHVk9WT3V2UWxUQ3dGUzNlSitzbXFsUXFJckZNUXFl?=
 =?utf-8?B?cStJVkNSV21BbjdvTC9tVlgxLy9wUSt2bHE2d2szN2ozcmQzNitqYjFZWHda?=
 =?utf-8?B?RFZRcEt4WXZFNjFEcUxnVDhteCtsSldTUWsyOER5K3VVN3o2d3o0RFNjalhZ?=
 =?utf-8?B?b3ArRzlPZEtrOXVDeC9yMGcvckxLZHltcTdKRkcyQm9hRTIwTC9tU3kyNkxO?=
 =?utf-8?B?ekE5RHY0ODdhV2gzYmVzUmRkVjVIWkJRdEFMN0hrc0wzTm8xRVQ3dWZPVGdy?=
 =?utf-8?B?dHg3VjBzSWpxUk5IWWllc1BOMDU2aEphbFRBOFR4WnVFQ2JRdWRabTF5WlBu?=
 =?utf-8?B?dzY3VGVoK3BkYW4vUlNhSTN3UVRVbUVPY280S2JiUXJiQlJCdm51UXhpT1dy?=
 =?utf-8?B?dW84M3hianhPT2x5ZVV6QTMwUnp5Q1ZWY0l3RjRnSUF1L3ZLUTFGRzg0NEFY?=
 =?utf-8?B?cEJUMHlodzJhdDlPQ0JhcEV5YXE0VTZXakpRVjFwRTN5VUYrM1ZYYlhvL0w1?=
 =?utf-8?B?eTliNHpJa2MvdXVJclpTZ3JJaDNyTGRxMDg4ZVBKWkNPT1BRcW9ZajVPZzBU?=
 =?utf-8?B?UzM4QUlYbHdRcXJMbkY0WlBiZnB2UHE2LzMvaWdkT1c2WkdxRzhneEN3bnpU?=
 =?utf-8?B?Q1FMR0xGdWtTYld3QnR6VEk2bEVVWWc9PQ==?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d6fbe63-adfe-4edd-90b4-08dc165a8819
X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 06:15:27.3113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB0794
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/ME3P282MB3166E4BA9602E4FFC977BE52B6732%40ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


On Tue, 16 Jan 2024 at 13:15, Bharath Rupireddy <bharath.rupireddyforpostgr=
es@gmail.com> wrote:
> On Tue, Jan 16, 2024 at 10:28=E2=80=AFAM Michael Paquier <michael@paquier=
.xyz> wrote:
>>
>> Hmm.  I'd rather have it do something useful in terms of test coverage
>> rather than being just an empty skull.
>>
>> How about adding the same kind of coverage as dummy_index_am with a
>> couple of reloptions then?  That can serve as a point of reference
>> when a table AM needs a few custom options.  A second idea would be to
>> show how to use toast relations when implementing your new AM, where a
>> toast table could be created even in cases where we did not want one
>> with heap, when it comes to size limitations with char and/or varchar,
>> and that makes for a simpler needs_toast_table callback.
>
> I think a test module for a table AM will really help developers. Just
> to add to the above list - how about the table AM implementing a
> simple in-memory (columnar if possible) database storing tables
> in-memory and subsequently providing readers with the access to the
> tables?

That's a good idea.