From: Japin Li <japinli@hotmail.com>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Mircea Cadariu <cadariu.mircea@gmail.com>,  PostgreSQL Hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: Propagate XLogFindNextRecord error to callers
In-Reply-To: <CAO6_Xqqd316HhigkBsE-rC8oVsAprc_mVh5Z312D+aUOzW-5Jg@mail.gmail.com>
	(Anthonin Bonnefoy's message of "Mon, 9 Feb 2026 10:21:59 +0100")
References: <CAO6_XqoxJXddcT4wkd9Xd+cD6Sz-fyspRGuV4Bq-wbXG4pVNzA@mail.gmail.com>
	<0cbf5d34-f117-456f-bcc0-50fa9a8eafba@gmail.com>
	<CAO6_Xqqd316HhigkBsE-rC8oVsAprc_mVh5Z312D+aUOzW-5Jg@mail.gmail.com>
User-Agent: mu4e 1.12.12; emacs 29.3
Date: Mon, 09 Feb 2026 17:36:19 +0800
Message-ID:
 <MEAPR01MB3031690E672656BB573711B3B665A@MEAPR01MB3031.ausprd01.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MEAPR01MB3031:EE_|SY8PR01MB8613:EE_
X-MS-Office365-Filtering-Correlation-Id: 73900c87-9e59-49dc-ea5b-08de67beb087
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|6090799003|23021999003|8060799015|19110799012|15080799012|5072599009|461199028|40105399003|53005399003|440099028|3412199025;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?MUxzUm82NDI0UDRxdm9nVEdsQ25VaGkzVkZNemRKcnhaSjA4eUZ6NkMwTjRP?=
 =?utf-8?B?Y1ZUR2xuYUtXdDdJUzc1LzVIdm0wc3NHVHF2cVlxMWg4VmNtQ2ZHdlJnQmtP?=
 =?utf-8?B?c1ZoaHZkN0xwaFgvZlVqQ2NTcHJvdllPYzcyTnRQbTdOdDFUZm1yOWU5b2hm?=
 =?utf-8?B?aG9oM21KeWR5Q0lBWkxwaFZZdHpQTVVXeng4TTMvRHRNS0dpbFZldUtQUC9z?=
 =?utf-8?B?cDhReGRUV1hLYVEzeTFUdzdVSkRsVzNuQUJ5YXQvWko4TE94a0hoR0tlcTRO?=
 =?utf-8?B?T1QveHNyNW9LOXFuMVl0NTlSL1paSStxMGN4R1JLN0FSOFRkZXpXc2FNcTRF?=
 =?utf-8?B?UU4rMWl3aXJ6MGc5ekpBL0loMGRwM1BXTm1CSGhRcUgrWHFycXplUUczZzBq?=
 =?utf-8?B?M0FYa1hNMkxBSWlYTFpEZFRzM3k4YWdVazJTeXl2a0h2Qi9NVmNrQjM3KzNw?=
 =?utf-8?B?aUlXV0pBeldSRlp1WC9RZUpBOEVhaE1xbHptSk1NMDdLOCsrY2o3ZkZqOWZB?=
 =?utf-8?B?Ry9jWWxCZ3F1Ykt1eStVSWkvWEZmRmt4SFlicXJaZzBoUU5ReTkrMm9zS2ZT?=
 =?utf-8?B?dFZoM1VhYklMVXJIc1ppdHhqUXRnYVh3M2NnZ21EYkUvU0w3dm1ISDFmSlVT?=
 =?utf-8?B?U1A5LzJLZ253Sjg1U2x0VDFXZGhHcVJMaElQWFY2V2NCMGVIZ3hpTTUwekVh?=
 =?utf-8?B?VlR4SmpxaXVLVnQ4YzRCWEJsTFRsRGVTVGNTaWxGZWJDOHhMNHQ5T3IwRDRw?=
 =?utf-8?B?aHRzRWZ0Tks4bHhneGVsSEJxNXI0S2ZlRWNkcjMrcW9EekFDZUE3UkhmVHY4?=
 =?utf-8?B?bWRTWGNGQmo5aVl6Zk5nMVlaWTZoZUl6R2Nab2ZmdWEwdjZpZXc1eDFiSU1s?=
 =?utf-8?B?NGhsUFV6enRPdEhlMEFtTHFYWnIzVmljM1RDZ0tYZU9ZdDBsdEM4bGo0cVVN?=
 =?utf-8?B?a0lRT1JIMUdaU3hQQktvWldnN2kyV0wvTjV3bHVyUjBaVG91STg4TU9Pbkd0?=
 =?utf-8?B?OVZIRXVyc1ZHOEVBOFIyNW9yc2J6b3ByWHF2aFQxWVhrcWN5Z0FhQlJZempL?=
 =?utf-8?B?a2p1YTFKV2ZCa3Y0SmVDQ2R2RENpeEVvaTlyM3lKbFVvYTRnY1EwVlNjNzEx?=
 =?utf-8?B?Q0xLZWU0bzFuNEMxSzVSUGhidlJvaE5hWnZDa1ZHM0l0aDVxaEl1U0RzdDEy?=
 =?utf-8?B?WDRuZUIrVi9FU0NrTUxzc0thU1JDc01hRllGMDZIaGRlVGRXdTkvSXBKNmg1?=
 =?utf-8?B?b0VGek1RVXNRaDVOaVRhS0xnOVV3Vi9abnBSQTB0ODBKbjlxNzVFcTRhQlZt?=
 =?utf-8?B?WXVSRER5ckZvYSsyelJXVkJabVdQS0hCYjBlNFdsckMwQ1JibDVDQXVLSk5G?=
 =?utf-8?B?Zkw5UXh0VWNmRW9rRURQSVZEbGlNNTdyd0RIcjAwbVArbTkwUjhtOGRLRDlZ?=
 =?utf-8?B?Q3huR1lLd3RSYWNkWGEyNHlDZXljMGxhNFNXRGhsWGl5QmpGWWNTRkJKa3hu?=
 =?utf-8?B?VzF1T0ZxVW1jc25DQlMvOTlnK2lIQjkvdzJPcDNRKzhwNU4zdkdjNmhsN29S?=
 =?utf-8?B?Ylc1aWJEZVFaYndwaGt2UGVrY1RNWmh1R2d0cW4vT0xkUW5ZQWNvZTZlejRZ?=
 =?utf-8?B?Vzk1a2VsRWdlSmJDNng3YmlreEhFamc9PQ==?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aTZXdW5BS3kxOVFNTlBJa2hxWUtBc1daYzNEeXppbEhNUmZBYTlydk9EM1Fi?=
 =?utf-8?B?VHZiR3ZqR0ZMRWlZQmhIM24vZlA3b0I3bmZFdTdHU0NHWDlsRWhNclFSbVIz?=
 =?utf-8?B?Z1BwOUF4dUxYQ1hxeEJQalplWVNJb1o3VnZibUZmc290SGVaMytLWFgvQnEr?=
 =?utf-8?B?cmRWQlg2dXFwK1FTK3REcFBkdGxSVVdPRk1URWh0VTJNaUozWFdiaDFJdkZz?=
 =?utf-8?B?SFVYSnRWVXRKYjVOWGxIYjRrMlZ1UU9OYk5OSW1OZzk2aUZ4cDB0blA2RDFW?=
 =?utf-8?B?YVQxWkRhOSt1Z0pTSUdUbzBFa0FTdlVHbVluUTB5NEdkd3hzVnV4eWIwMGpE?=
 =?utf-8?B?eWRXcXBIODBnUldDUC9tTksrVm04NWtuRmgzcVh6R3dwVklTdmY4YVcwQXM3?=
 =?utf-8?B?VjZUd1FGV2czYkRFZk42SG5PTHc1UFF0YkhLUzRsTG5CVnZhVFlyQjRlRHBQ?=
 =?utf-8?B?aWJqN2VyREVaRmNPdGpvRHUrNzFQU3QvS2J3SnI1b2hIdmF5eEpPYm10Uko3?=
 =?utf-8?B?TE5Vak1Hd3VrQ21yMlhPNmJ4NFZzUVQzVzRSckJxaXJPYzRkNmFyaitia3Yr?=
 =?utf-8?B?Rmw0VnZ5Z1NwTEdNSjkvSFlreGp2QU0xUERrVWZHY25RV3pXdmk5REhCY0M1?=
 =?utf-8?B?bVcvTDFQcHRwTUZTd2FGTXlBWERKa2xvZTNXZGUweWx4Yjk2cEo4T09ueU1k?=
 =?utf-8?B?OVZJalh5QjFGdjZLSVlIMGtmZGl0a2wzdnNvc2NvS1RZSHhDWmlPWFhLRzdQ?=
 =?utf-8?B?bWRkcXNHaU04emEzb0lkc3U1WjBaemJWWFE1SWFMbHd0c3hLdEZHN1NENVRN?=
 =?utf-8?B?aWs4bFY2TWZ0bmZ0UTlUa3JXNStKb2pWcFZENXBwZWxjV052WDlBYTlGbm90?=
 =?utf-8?B?WXdqNmtiZEJRQkM1RHZqZ2Jsd2RuUXdIc3FrN0FFMUFwV3U2aTJuSDNwVlhY?=
 =?utf-8?B?L3g2WFo2YngzSVAzTXg4ZVhOeUhUQUZRaFROeHRocDhhOXg2cnlCTGZMMWNa?=
 =?utf-8?B?MjdUMVRGOGQ5Y3JZN1gxNFAvTTYrRVRyY1NrbDlhZkErMUEycWlMd0kvdVRh?=
 =?utf-8?B?UVdubVlMcFRJTFFKRjhrUmI5bitQYWUvU09hRmxpYkhYTHM2Y3oySnljcDNh?=
 =?utf-8?B?eGZGU000UTFMVXFLMnpia3kxVlJuTUdlY0F6L2YrNUd6d2lrTHVJZ3luNlFQ?=
 =?utf-8?B?T0hpS1pzWHU4NjdKaC9KaUZ6ZkJVYkFkeVAwUkdPWXlIL1dHLzlZVm0ydkRI?=
 =?utf-8?B?c0lnOStCaG9iWDlyZHV5UW5qZUoxNTE3M293anh5dTlFd1IxcUZCbGt4clRD?=
 =?utf-8?B?VnVVNUs1SmJ3R1EzS1FNOTRNT1FRQkcyNy9xNlROVDFya2VNaFovSmNPU3Zk?=
 =?utf-8?B?aFpsM1BKV0YyMUMyVDdwQy9VcTNyZTJnQUhES1FNb2lyODFGV1d2cUlnb1lK?=
 =?utf-8?B?UkpCN1ppVmpCZFcrQUNvV00vYStmQ2x0YUIyK1Ixc3V4NVowZHZiR0NPTW5l?=
 =?utf-8?B?U0lYc1dpM2R3Ynk1V3NLaUhCdEx2L2RjQUhiWVlQRVkzam9tOGN3TGt5MWpF?=
 =?utf-8?B?MjZabjZxTnI4T2V4ZGVWRFQ1WnVycDRlajY0M3NkTEZHVEdzT0szL0RaUFlX?=
 =?utf-8?B?YXF1UVkyM2xPK1E1ZmpZQmpScUhtcFhTa1l4US8vNE5NUE9QUUZZYnBXZXoz?=
 =?utf-8?B?bjBoVFQ0SnhvUlo5K3VwbW5qczczam0rTzJnYVJiMGZheENWb2szYnBkUkg1?=
 =?utf-8?B?UUJBSTR4WVJrblUwNFhvSG5PaXN1blFjR3h4WDBNL1kxenc4enhSTnpreGJD?=
 =?utf-8?B?bWNMTktzNE4zQzJ3cTlsNmViV3EvcGxndVlRZHdoNnROTVBmQ2NJRnYwd3Q1?=
 =?utf-8?Q?CWQ0TDigsigjU?=
X-OriginatorOrg: sct-15-20-9412-4-msonline-outlook-a559e.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 73900c87-9e59-49dc-ea5b-08de67beb087
X-MS-Exchange-CrossTenant-AuthSource: MEAPR01MB3031.ausprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2026 09:36:24.1509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY8PR01MB8613
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/MEAPR01MB3031690E672656BB573711B3B665A%40MEAPR01MB3031.ausprd01.prod.outlook.com>
Precedence: bulk

On Mon, 09 Feb 2026 at 10:21, Anthonin Bonnefoy <anthonin.bonnefoy@datadogh=
q.com> wrote:
> On Tue, Feb 3, 2026 at 5:05=E2=80=AFPM Mircea Cadariu <cadariu.mircea@gma=
il.com> wrote:
>> I've picked up the review for your patch.
>
> Thanks for picking it!
>
>> Attached is a failing test that reproduces the issue. Have I got it
>> right? We can consider using it to validate your patch then.
>
> Yeah, that's the gist of it. However, the test you've written will
> only work on little endian architectures. Also, I think the xlog page
> header size won't have the 4 bytes padding on 32 bits systems.
>
> I've added a similar test in 001_basic.pl, but it relies on copying an
> existing WAL file and setting the WAL magic to 0000. This way, the
> result will be the same independent of the endianness and memory
> padding.
>

+	{
+		if (errormsg)
+			pg_fatal("could not find a valid record after %X/%X: %s",
+					 LSN_FORMAT_ARGS(private.startptr), errormsg);
+		else
+			pg_fatal("could not find a valid record after %X/%X",
+					 LSN_FORMAT_ARGS(private.startptr));

For consistency, this should use the %X/%08X format as elsewhere.

> Regards,
> Anthonin Bonnefoy
>
> [2. text/x-diff; v2-0001-Propage-errormsg-to-XLogFindNextRecord-caller.pa=
tch]...

--=20
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.