References: <CALfch19pW48ZwWzUoRSpsaV9hqt0UPyaBPC4bOZ4W+c7FF566A@mail.gmail.com>
 <CA+hUKG+i3Dnsv_M+Opk6tTv96w8ZfWFPQAYScj_LRtvw=qx0+A@mail.gmail.com>
 <CALfch1_cu_uurBGVG+GO_AtyyYxnuLU5GWf0ahHMre_HDqGDyw@mail.gmail.com>
 <MEYP282MB166993107CB3858B7524EA9FB62EA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CACJufxHe9CZQD0orxhBJMi8VT9iJzmJ7Eodbnkd4LqEOQD7x7A@mail.gmail.com>
User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: jian he <jian.universality@gmail.com>
Cc: Palak Chaturvedi <chaturvedipalak1911@gmail.com>, Thomas Munro
 <thomas.munro@gmail.com>, pgsql-hackers@postgresql.org,
 pgsql-hackers@lists.postgresql.org
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
In-reply-to: <CACJufxHe9CZQD0orxhBJMi8VT9iJzmJ7Eodbnkd4LqEOQD7x7A@mail.gmail.com>
Date: Tue, 04 Jul 2023 17:45:47 +0800
Message-ID:
 <MEYP282MB166908007942485DA71CF8DBB62EA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MEYP282MB1669:EE_|MEAP282MB0373:EE_
X-MS-Office365-Filtering-Correlation-Id: dd1d6190-fcdf-4c6b-3849-08db7c73763a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	56njC7iENt7jkq+6GvbWn5Zcb3WX7ifJCoJzUp0TCmYiF9nR+UwZi8sxHoMP3EiXaOX4NMSdOG5bZWe6KB2n9diplbp5L9dq2eRuULeDKpGtAYXrsUoiGlTaejb2d9/8JeCQ3OQy8xUSXM8A7/jadCwXjpDgyfhG8rE5o7yqO4b2Cq1x+f5w7QFIl9A/w0FSdlKL5yKOeAmkStn0VzU+Oybk215PuamkAkJsge1jNoZT23QUf1cVrXbeK6VYKxSKst48RCzGraoc0O/eAMi5l328obpDrzVkXl4J2SVFFmblIpTlT2kujj1S/tb7TTXgKi0LPz5QBaYwaUWtsp9wjXmMgK+VK+wGsl2Qc8MLOKrFDNCcl10zED+PIRKPViF2poJpOK0KvpjaGiHwgpgBiVWaWkO1lesp30NLyAWTI+4GyceBVBC9JJdHUEzbXQptB10c0XBcycJD4ik2VZJ+xp2FM9tN8ujntUqvaiugXvYaDVSnTD+LhWHbxDsm8zg3/x+A3iJqb+ZL3ef2CHndVTePFqrsPnG1F5XG5KPkqvyTGZyy2+uo4sEG4gywuRLB
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0pL+ShW3T4VjwWzUHpgGMFET6GTd8LV50Pwr4nBC+607EOm8DuSGBpjvUG6+?=
 =?us-ascii?Q?8Ev4e04s78nidpWp4t6inrfBuREhbQYxjk7k6+cGembwOsqUEdFL1EY51BfO?=
 =?us-ascii?Q?5NFEWQ+wL28ac8q7d/Zud9Wqcy5PjFJUB8gvoRk2cOygjDKd2eIChFzmW4ze?=
 =?us-ascii?Q?aGXPP/A9Y2yzQ2BfiFh53+OO1XyOHGna6Odk72qkLF2h3tP3gtlSO1AOliTZ?=
 =?us-ascii?Q?ym5TnbNzqL0QDe2g8Utm/z1yRdZHfFIIgc0KSOyUcbrO13kDkiV04WxOOLZ3?=
 =?us-ascii?Q?qkZsudFRm8LWdradh/n+kXMFycE3lEZj3X12dL0+7D5eLvfHtByX2XyP8Ti4?=
 =?us-ascii?Q?df5OE/R3u1azmDQNDsLtf3RBI/18uo0Jx12ttk4C5IfGwoT818S3dR3tEW8B?=
 =?us-ascii?Q?CsIvrxFVOhxI5sfj+qeFMPnoCGD2tsLoMqiTnEnoMqzUYjDacwfF1fyIp2jM?=
 =?us-ascii?Q?vmkN3Otkv3PpOctDF1+hefPMlq8P06MxOJhnNPUQA5FYigyggZJGpyutuY2F?=
 =?us-ascii?Q?Zaj+m/aFC/0ypzRkIHQEdmbDOgHcjSkS70hcL4Y7BlETbWLXB2mlP2u0S91J?=
 =?us-ascii?Q?yDahuJiVysCB7Hi8djUMRf8sP5tq7vhssXScsb1O9A4oPIwpDMVsA9EF50XT?=
 =?us-ascii?Q?cSKWXe0NMRrAsWN2cTpHVBJdTq5JpLSKnCGxT/ZdFXl+6qLzOAc6oVplb3P5?=
 =?us-ascii?Q?cgaO9vqtxeg8UMsvfvmuUuXzfiyqYBXJGNm/Dlmvl7o8BvplJm/YmdY+dmFA?=
 =?us-ascii?Q?aZdeLrBpx2YPmcV54xm9DNWlyBYxlTnnSv26gRRGtDWnIlHRKlALmYFrLzVq?=
 =?us-ascii?Q?oGBFT9RHi6q3jK7xRCk8csHsmpsXcahvkuJ2wHFNdTWI9cXTpXT1X1yDc/cR?=
 =?us-ascii?Q?SdfkbCl8dHdFxsNYGC7BxjJPUnDcRaXIjKMkIfTypiSM2DLxlXjz7uB6XnOt?=
 =?us-ascii?Q?nH3QJAtK/apEpajU8uQrv47VblwMLd6QZTftQPDEf1EJq9NoUP/gW+AyAQzQ?=
 =?us-ascii?Q?ko+LyMbhxyw6/IhjW2JbODIYiitb3xiMIDfXVJfNA7jEHBl233G17P+mCUtA?=
 =?us-ascii?Q?iFRp4yr5sQ8y6oi0eqgLgaEPbZ/sTgqdwMvCR4u/m6tvJuW5oGujTcusJ8DW?=
 =?us-ascii?Q?mHeSrvLPVdDO/tbvfk6PrBNXWV1vMhk63BNB8L78m0vbpXuA04OLdd5Q9o8g?=
 =?us-ascii?Q?pyWATfPQP/RjDMFhHSBpw0xCLqE73XsPAlxRTQ=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: dd1d6190-fcdf-4c6b-3849-08db7c73763a
X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 09:45:55.2761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEAP282MB0373
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/MEYP282MB166908007942485DA71CF8DBB62EA%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


On Tue, 04 Jul 2023 at 17:00, jian he <jian.universality@gmail.com> wrote:
> the following will also crash. no idea why.
> begin;
>     select count(*) from onek;
>     select relpages from pg_class where relname = 'onek'; --queryA
>
>     SELECT count(*) FROM pg_buffercache WHERE relfilenode =
> pg_relation_filenode('onek'::regclass); --queryB
>
>     insert into onek values(default);
>
>     select count(pg_buffercache_invalidate(bufferid)) from
>     pg_buffercache where relfilenode =
> pg_relation_filenode('onek'::regclass);
>
> ---------------------------------
> queryA returns 35, queryB returns 37.
> ----------------------------------
> crash info:
> test_dev=*#     insert into onek values(default);
> INSERT 0 1
> test_dev=*#     select count(pg_buffercache_invalidate(bufferid)) from
>     pg_buffercache where relfilenode =
> pg_relation_filenode('onek'::regclass);
> TRAP: failed Assert("resarr->nitems < resarr->maxitems"), File:
> "../../Desktop/pg_sources/main/postgres/src/backend/utils/resowner/resowner.c",
> Line: 275, PID: 1533312

According to the comments of ResourceArrayAdd(), the caller must have previously
done ResourceArrayEnlarge(). I tried to call ResourceOwnerEnlargeBuffers() before
PinBuffer_Locked(), so it can avoid this crash.

		if ((buf_state & BM_DIRTY) == BM_DIRTY)
		{
+			/* make sure we can handle the pin */
+			ResourceOwnerEnlargeBuffers(CurrentResourceOwner);
+
			/*
			 * Try once to flush the dirty buffer.
			 */
			PinBuffer_Locked(bufHdr);

-- 
Regrads,
Japin Li.