References: <MEYP282MB1669EC0FED922F7A151673ACB65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com>
 <CAMbWs48KxbY9EzZSQBy-30Ey06H-+Bi4HcQvxrOvEHANSGQmVg@mail.gmail.com>
 <ZIlwod7WjAs3SM/n@paquier.xyz>
 <CAMbWs4-tSAcv9XMMnOTb4ELB6azc0jzZpLBn7xDiSvficEKEbQ@mail.gmail.com>
User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Masahiko Sawada
 <sawada.mshk@gmail.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
In-reply-to: <CAMbWs4-tSAcv9XMMnOTb4ELB6azc0jzZpLBn7xDiSvficEKEbQ@mail.gmail.com>
Date: Wed, 14 Jun 2023 21:42:37 +0800
Message-ID:
 <MEYP282MB166980680AB1C25961134677B65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MEYP282MB1669:EE_|SYBP282MB0411:EE_
X-MS-Office365-Filtering-Correlation-Id: 3e785369-9d3e-4e57-9733-08db6cdd4220
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EDkdtJOz6VnBTWT7FxJD8oqIUZI+ZtEb7Gbr51Fwlc6og//FrozVZEyOmPMDTLZhQDzO0Q+zMdKVzD0jgNAzJzZRx5kcutkKultqkxCiFz+AhCo7k96zUdbYrpg6pN09PGs1OSbDyiXbGsHROxHl1HQrDjfukO9J0UoO22ZuWdzQdntMeyXtRjinM4YCDJAlEUNQQN54Qu3M53LIUZW7X4SMj5LCdoiRxdhRtS0CpPk1nNYQC45t+XqO/0+UMG4Tu0yDesi46vh0a6kE3TOdFusw5ZRD1px+UPcgyA9qUzhUsgTaUCtHKzUWYI95RKxkt0DonvM6EA5jhcp9xlAI6TnWLusNJ8NnlwLbNl0h3op4GlG2ltyvDgHrRunWFAVb4uKoDUJcxXhgGCkoXDJgLpIXEMhgiQm0GIO0MC8Dw0LhRPohp3XJrqoQtiqMmKLqmdNmqgwKAHQSOjwSjehknO61ZTmjN/RiX7EwplCeXSh4KlQe0oAB+7DwG4y531nm3C34LLmZ48pU2vqXR1VGwEjWRq+wds37QfIrPYF8rgN34IxmNqR8ogAd/Hxp81JseVW1ctJ4spZ9AlBE3j9sPwr5LGyES5u8dacfDNrIP6bElNQrJPJrukpJ1jYwv8cu
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkV1cVEwZzhacUt2SUZFWndsNnpoOVV2RHhhbFh4aExRV0c2U3FyY1drc1Bp?=
 =?utf-8?B?eVBmWWtEekVSR0tWN0R3ekZlRW50Nlc2YVBpNkpYZk1iQ05UaW1VejdmY3NN?=
 =?utf-8?B?UUNEeVA0MFR5dlM4Y0JFL3B3RkpWcjBsN3NiWDlJMWNIaUV4YmJtL1ZQUG9u?=
 =?utf-8?B?ai8wQTNoR2lQVWxsYjhoYzJJbGpScjJrRjdZQWxWb3c3RC9kcXVoNW5mSEl0?=
 =?utf-8?B?b3hMTktZTTZGeDcxV1FZQlFlOVdnVGs2SFNlZCsyenRVSk1wUStTMVNPVkVo?=
 =?utf-8?B?dFdoL2xmUVcwTXdGcUVWakdVZU02TEJXNGlsb0hjRG5pYmdNQ1krYjVyNTNa?=
 =?utf-8?B?ZjFiTEY1V3dqNUo2LzNybjZ0RzNneGVvTjdaeE5YeXdleWJUSVNjbk05ckN5?=
 =?utf-8?B?NEFIZ3VZY25lWWgyeTN4a01acnNTR1NQSHQwQjA3NUp2dHhodFhUZHdjR3ZT?=
 =?utf-8?B?eVBOcHVzVDhYVlFFdlIvSzRYcUIrRmJZazNPYmRKZThiTkVoMU5xbm8vSmtN?=
 =?utf-8?B?MXVyb3phS2hCZWozalArTEtvWlFlT1VyNU9WWWxnVEpyMlFwOURsOWRXSWdC?=
 =?utf-8?B?VXNJdDN6UFhaUUVoNlNQc0E0N2tiTEcrZTRqS1kyZGVnMTRHcmJJT2dmem5h?=
 =?utf-8?B?azUyY2ZaUkdlSE5FTHZBbmlVYllYdHBXZ2tLNjFpb0g1Q3pOamR0ejlmQllv?=
 =?utf-8?B?VGFVMm5PcnB1UTE0ejRKS1BnTWxrV0crOVQzUEVsRDFTUFFrb3hMaEhmNTZs?=
 =?utf-8?B?aTJBQjg2UmVOVllYZW1DTmdieFJ1eVZ1K1dUaHJJS1BGZnR4eFFpNzY0K1pQ?=
 =?utf-8?B?MjdFaVJWOG44b3BPajhPMVpVcnBRSEhTMlE5OU15Tnd5QzhKYkhYMVovK3dv?=
 =?utf-8?B?TUsya2RuUCsxZEdSelpzRTBmS1JJMVhMcDMyekUyNGpFNjRSNXNCT3o4VjVZ?=
 =?utf-8?B?WTFnRFc4c21iTzVxUTNNNDVRdWIwbFVQeWg4Um5RNExwLzhZNkVTcjEzNldH?=
 =?utf-8?B?cGMxMVVHMFVwMkx3ekdWcDdtRDMydkFrLzI5WnZ4bk0rbytrOXQrRjZmWFJi?=
 =?utf-8?B?WHkxV01oT3FxQ29sUG5VY3JhaktTazJyRzRRSC9WNkpEVVRCRVZZS0prWVVF?=
 =?utf-8?B?ZGJ5VkJYVmRSaDlHNmh4aU1FQlNaZFVObjlRQnRUclVLREkwK2I3bzV1Zy9l?=
 =?utf-8?B?MGE3UElBbkcweVFPMVJPVXI0UnRZS3dnYXF6MnpwdCtCUzBGclNpRmx2ak1a?=
 =?utf-8?B?VnF5dnhTNXdlRXVVcS9MYm1UaWczMGJtMjdDeVM5VE1vcnhtMEFrN3hDVDZz?=
 =?utf-8?B?cGszK3J5OWNCKzdZejVVQlhwSGRXWldGb09ZZnBYMHhVM3lFQXdtTVhudTdn?=
 =?utf-8?B?VE9EK21RWEU2UXgzN0xielBMWFlNUlBjRjNsVU9pT1lCais1TzNlamZkRDlj?=
 =?utf-8?B?ZVFCMnZibVk0UHRkclhqQkhhN3JyUFdxYmNvUWl3eGx6UXRiOHdmZDZ0dVhU?=
 =?utf-8?B?MS9ZdDZpV0c3NzlSRDdCTUxQd2F0bDJLenBOTDJGOVFDMllKMHdCQ1dtSHov?=
 =?utf-8?B?QWhQUjhXa2phMGhZdW53czZTdXZ6bkhqelEwcVZFY2ZrejdpRHlBZEUwYkd5?=
 =?utf-8?B?WmxObU4zUW1RM0owMjlrV2d2REdCL3c9PQ==?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e785369-9d3e-4e57-9733-08db6cdd4220
X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 13:42:56.0695
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYBP282MB0411
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/MEYP282MB166980680AB1C25961134677B65AA%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


On Wed, 14 Jun 2023 at 17:52, Richard Guo <guofenglinux@gmail.com> wrote:
> On Wed, Jun 14, 2023 at 3:47=E2=80=AFPM Michael Paquier <michael@paquier.=
xyz> wrote:
>
>> On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
>> > +1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
>> > GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
>> > not.  It still indicates that we need to use time units table.
>>
>> Some out-of-core code declaring custom GUCs could rely on that, so
>> it is better not to remove it.
>
>
> I see.  Thanks for pointing that out.
>

Thanks for all of your reviews.  Agreed with Michael do not touch GUC_UNIT_=
TIME.

--=20
Regrads,
Japin Li.