User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Message-ID:
 <MEYP282MB1669EC0FED922F7A151673ACB65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Date: Wed, 14 Jun 2023 11:33:06 +0800
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MEYP282MB1669:EE_|SY4P282MB4158:EE_
X-MS-Office365-Filtering-Correlation-Id: 164f1e72-553b-4177-bc07-08db6c8814be
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1o48wZ3rEqLwzmHwBOx1DZ04qs6nLoEn76wijHGW5a/1SLWnDbVm4E6miQHBXKYixOJGMXJ1R/7FfT+FupMjd2Xi/IqfsUJVMQDiJIgcWLcmpejHyLCdr5YfTbBk92LR/YBWBFCamN1Rfdc0ySuEDwhM3tgUDC5DdaMSPsEioWwWRg9UOkTbEAN+GTm/U5P+O8HNEHi0mv6NrCVm1dXMh9JTMY0wkf9qDVooSNMf1qZ2Qt8ByJvn1I2MAVg2KkMFn6+EJKbQ4aGDhRdxGCi+Gx0o7wvLjY75O9iXe2188mAibna9X4e+e5qiJu2cZF3ZjqyzJUr3GOIf9r7jTpfE0UeWds66akVtoB7b6/ONuT0Pkbvt0kmrd37uUUDV0SmOhxIKb2KXRWBWZ+oWp4+WcpNuOnja3iu254S6MuNoSH9DUICEaKG43rvFrj1iRSCtJLbBefZke4DReLr+CV4CioRvVJeViDCAbzAs3wahvtEtKJNbYp2cvkDkX9U/j+iXJLbOTVD4xTQRaXyFlPZzo2+MzqxZrMKErcO3pmqygaJ5JLZrnbRppaPYJRlDOyYH
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8UxRtiMSVRecTJv+o0OFZ+KFyb1LR6wo2tb35VxEJg841T9Rkilb1uAusj5u?=
 =?us-ascii?Q?P6NnPKOokLnMqrltgRGg6a8XecRW+j2uyjTwy40V2nYZ8jk/KJLr34LBfRbX?=
 =?us-ascii?Q?5RxcnfYwhXADc1D8QqrK7UD+uYXKaS0kLn/8BLm6vWIK2usVFltDsH1ICCX4?=
 =?us-ascii?Q?wE3c1hTCSp5e7CI5cIJz9zrraguX65r1IbmewpQnpL9r+WFngYHk/fyDRhtz?=
 =?us-ascii?Q?Fj95Qw6KlO7ubWqneqToA/tbbnueNvIhH8EvFW+oQla+D0z7gOyS6D9gTaYX?=
 =?us-ascii?Q?842abVENf0pTOvPC7INRN8V5x1jB6R0TlKkxOHL2zsR47HtygMWqCawj7DbT?=
 =?us-ascii?Q?Sxsc6RThH6LcDtRPcWiKw2QkALytj+0y+AuIKaCs8uzps46I03zYNbKgPIMg?=
 =?us-ascii?Q?zs6TY728RVc8dCZD83ayoYb9D6U626JXslBePcXDa4vF5aR3L52aq0VsjSzV?=
 =?us-ascii?Q?4dTOF4KkSV9u7bh4udAgdd9XqP6oJlfTxC/UAUuw/OD2LaD8g3Or14TqII5y?=
 =?us-ascii?Q?2Y9Be2N/Okju4x7ka/Can+Iub4VpGp4z0lYinGz+Mk5pJwhdFwa8JeYq3ONs?=
 =?us-ascii?Q?hGO0gbPPdf0HKvvW8aZk/OuxTNeSLArRyidI774HAOq9eF0QAvFnJMKtKWp/?=
 =?us-ascii?Q?NujFLBKdyc3ZJEoCxCHVrxZa+aJsauPFYmiyCfnpdgMKtW/LaGAPaqr7nr0I?=
 =?us-ascii?Q?GcZ7vuSNwsiEGZb0Ia8FtSGFIb577HsYDNQHnOlpwuYig+4AJkRMYKk3OxdR?=
 =?us-ascii?Q?31ZBCOqetY0SlAFAItmyjjtdYCCkw2EQhwwCojDrpYBW84EF0kP3su6BwEwd?=
 =?us-ascii?Q?SuOfz4ObXYtvxU1CgZTRGNH0w1sZ7FKAV002rIXt8h0oTGFFaFioGn7T/QH5?=
 =?us-ascii?Q?+sMWUQnBb4o1X8O0B7g2RO7MWvVCzRPDPd4xMhZ9GioE+OZBT9o283aFDg25?=
 =?us-ascii?Q?Ag2M2ohHvDtQxtc0qTif9ZME4Yk+vgTgDc1C4bzpXb84zhtRVxkUvoDMSfvI?=
 =?us-ascii?Q?+9YUBxkAJvawQCArHSrJvPdtDbheVkmLXvHNCLWux/uBO4O5ZbPh53SxGaYU?=
 =?us-ascii?Q?j5Plfsh36HAhLRkgdWxiyoidPga/EVKDZYz8wGP+f7D/m4VCQG2wTTq+XJFA?=
 =?us-ascii?Q?6bbRqKINEbuFSmTZCWNEl5bYEwLDUeX0mLc2LabdPi3zgLY0jNQlTzk2E3Cm?=
 =?us-ascii?Q?sYn7egQAzanSePjDiZKD4/EKGJ2EMW51U8mjIA=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 164f1e72-553b-4177-bc07-08db6c8814be
X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 03:33:12.8292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB4158
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/MEYP282MB1669EC0FED922F7A151673ACB65AA%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


Hi, hackers

We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though we
already define it in guc.h.

Maybe using GUC_UNIT is better?  Here is a patch to fix it.

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index a9033b7a54..5308896c87 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2766,7 +2766,7 @@ convert_real_from_base_unit(double base_value, int base_unit,
 const char *
 get_config_unit_name(int flags)
 {
-    switch (flags & (GUC_UNIT_MEMORY | GUC_UNIT_TIME))
+    switch (flags & GUC_UNIT)
     {
         case 0:
             return NULL;        /* GUC has no units */
@@ -2802,7 +2802,7 @@ get_config_unit_name(int flags)
             return "min";
         default:
             elog(ERROR, "unrecognized GUC units value: %d",
-                 flags & (GUC_UNIT_MEMORY | GUC_UNIT_TIME));
+                 flags & GUC_UNIT);
             return NULL;
     }
 }
 
-- 
Regrads,
Japin Li.