References: <MEYP282MB1669FC91C764E277821936D3B624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAMbWs4_ZFNUw59JhAnKUm+SLtaBvJ3FicLQKg0YXJ2mWGH2hGQ@mail.gmail.com>
User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Another incorrect comment for pg_stat_statements
In-reply-to: <CAMbWs4_ZFNUw59JhAnKUm+SLtaBvJ3FicLQKg0YXJ2mWGH2hGQ@mail.gmail.com>
Date: Wed, 28 Jun 2023 12:15:47 +0800
Message-ID:
 <MEYP282MB1669FB3A6F7AD9B0D949CA7CB624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Content-Type: multipart/mixed; boundary="=-=-="
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MEYP282MB1669:EE_|SY7P282MB3866:EE_
X-MS-Office365-Filtering-Correlation-Id: b04a3b5b-adee-43ff-0351-08db778e60e9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U2x/IaAvEe7ilS1tcB8oyyc/JxzWAPq4NzLPOrgYuu+l7vH4VfvRnHE9OK34at0zitQo6eIwNZ6tsoq1GTcBChd3PjZZbyDYvyBUSaHfL9QJwGUc5vyaoFGWB79O4tT7VWrtnrQePPdawTWLw8vCCIK0+kMhgKFoXjOqMq+LGdR3CoCDrjS1WzhH1r2RKuNXMd34aVLrM38bxRhDVQozbEak8t1w87P6lVkNLMeIV0aHovC4EhgEWPvfriG4a8Dqkn+Y6wtjotw5niDlG/FH+6EQlB8DghlkbmqrcGrvfHghsQsAK1+n0aScSU2r3zN9ylSTn/69kcc7HzNdY7S9oRFndtgeU7x99KDVtsBbsqD2SBGowPH0o5otLvkgyxJbDQmIUnQF743eB2AZql6sjuQ6ePaG+jnDCG0rwQogUzDfOJEG48wEJTGl34u11Y/TUMzCq3Oc26C6fSoA8dTlrPnSgmdw2hvXrmcT26/uoBTAniIqCzVCFBwOEmcll5y+f4PeQZ1JlmsIO86wNZKwOhygHgC9csWsGCrDRz6l/0JIcvb06Iq7OSnwTU1xwrO8
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3cxdUIweXB0Wk1vNnZXTktCMW4ybW5waGl3dFc1SGdjMjVNcHdoRlVHcG1z?=
 =?utf-8?B?eGtPM1RqYUU5Y1ZSa3NJYllOdENqb3NHTTB5dWRlY2w2N21VaGFFWFA3VU01?=
 =?utf-8?B?M1dpQTBzQy91VzF1cnhlR0tWZ1RNUnhSVVQxWHQxc2NsOTZkMFVqZ25VOS9k?=
 =?utf-8?B?R1ZOWEFNR3Y3QytnQXRLT3ZwYnlObnVVQkNrV1p3QTZFTVN6a0F4SlozR0ov?=
 =?utf-8?B?SFRwam5jVGF5VWpacGhXdDdxa2FPZTRTbTlpWUlDODU0MVdscnBKeDA5R0Fm?=
 =?utf-8?B?Q3pQaDZWMUxtOVZGeThhUEdqeXUrcVdnWENFUkFqSlNudjMrVE1tVnFncE40?=
 =?utf-8?B?MGppSUxMeTRaTnVwUnM1UjR3WjNIMWE3aGhnQ3VkZCtQVnV6Mnp2ZnZKamto?=
 =?utf-8?B?ZlBaQlI2UWlPWDl3SloreVR2OHNqOWxZOU1ndU5LR0ZCSFFzcC9ZVm43bzZJ?=
 =?utf-8?B?UUwvd3hxNytjZm0wRGRWQ3hpWnBkR2o2bGtKblpjaVZFeUE4WjlnY2NZU05T?=
 =?utf-8?B?YWlHWjYzOTM4THAvZEZFWTA0MDdkaXRhRTVLQkUrZGN5QlVaMUFCRE1xMloy?=
 =?utf-8?B?MVdMdXc4dU0xcFRPakZXKzVpMDc0NkN5RFRuaDhrZnUvVVd1cWRKY1NXMmcx?=
 =?utf-8?B?V1hRTjl1MExYa0JPZGVQaHJQODRzakVjMDczTXRZamV5ZVZtelRZNkdoMVBY?=
 =?utf-8?B?MThTTkVOQmY0V2ZLTmtiOE5NZ0JFMS85cUNTbTZ1aEN6K3J2dnNLVTg1YUVR?=
 =?utf-8?B?Q2wxVVRrdjhkMk0rMEE1di9HeStRTUxMckxEUG5tVTRKTzlEamFJODN6ei83?=
 =?utf-8?B?ZEhyNmpPaExqcWhtMklIT2c5NktTYzF6OXZERUJvcXJVTmtRcTZVVTB6UjZt?=
 =?utf-8?B?Qi9scXlyclhDQ0FqUmJaREJCdkQyNU5pTVgwcjMzUlExa3JaVzBCY3JpNnFQ?=
 =?utf-8?B?WDF6U2JYN3BqbTdna3RQTDBVaDJQK20rS2M0ZjF0N0JjaWRsMGVVTTYzbHhI?=
 =?utf-8?B?d0Rza0NQZ2tuQWt0by9SRnR0cW5mYVI5VzMya3JmV0hHSzUvMEI3T0RVb0F6?=
 =?utf-8?B?RTNRN0w0Y2JNQXM3Z245SjBkMktzVCtWUG5vZ2sraGpFTHFMNVF4ZEdxK3FE?=
 =?utf-8?B?MjVxbTNyMHRYM2tKQ0RwcWh3SmtqblhBZ01Lck1hdE1FL3pTWnE5bFFLcmVI?=
 =?utf-8?B?bGtUTVRoVVhMZ2tWWmZMdDJkbkQ5VFg3UkRjZHd6MUcvUVp4T2swc081UVQ5?=
 =?utf-8?B?M2Z1OEZCV3BPKzRHVERHQTY5RFdMbFJLMTc2U3pBWkhaUDVMUUhnVTlBclBU?=
 =?utf-8?B?cy9tbXphdkN0STJMRXlsa1JUeXZCNjBMOUkwYWRVWXZTbERjL3hSQmJzMUUr?=
 =?utf-8?B?UElabFVycm14b3VFUzJaZ1YwSXdYYmlHSEF3RGw3dmI1TzVGTDlGY005VUNh?=
 =?utf-8?B?emJ0SFp6OXBNcFg2ek5COXpDTDNseWUzTE5CQS9TaGNlV2UwWjhQdnhCREtW?=
 =?utf-8?B?QzNDL1J2V2lvR3JBdERIVXNINHdoVVZieDhDVGd5UVZJQjdjTlF0TFdaWjEw?=
 =?utf-8?B?N1UwY3NUQlRoSndySTR0WmphVUJaaXdkQ2pHdFZzRDZWWnkzbHlYV3d6dFJy?=
 =?utf-8?B?L29Bay9sUW9nVkYyM1BSWnVZakxSRlE9PQ==?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: b04a3b5b-adee-43ff-0351-08db778e60e9
X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 04:16:00.0936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY7P282MB3866
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/MEYP282MB1669FB3A6F7AD9B0D949CA7CB624A%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


On Wed, 28 Jun 2023 at 11:22, Richard Guo <guofenglinux@gmail.com> wrote:
> On Wed, Jun 28, 2023 at 10:53=E2=80=AFAM Japin Li <japinli@hotmail.com> w=
rote:
>
>>
>> Hi, hackers
>>
>> There has $subject that introduced by commit 6b4d23feef6.  When we reset
>> the entries
>> if all parameters are avaiable, non-top-level entries removed first, the=
n
>> top-level
>> entries.
>
>
> I did not see the diffs.  Maybe uploaded the wrong attachment?
>

My bad!  Here is the patch.  Thanks!


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=fix-comment-for-entry_reset.patch

diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c
index 21bede29fe..670c993816 100644
--- a/contrib/pg_stat_statements/pg_stat_statements.c
+++ b/contrib/pg_stat_statements/pg_stat_statements.c
@@ -2552,7 +2552,7 @@ entry_reset(Oid userid, Oid dbid, uint64 queryid)
 		key.dbid = dbid;
 		key.queryid = queryid;
 
-		/* Remove the key if it exists, starting with the top-level entry  */
+		/* Remove the key if it exists, starting with the non-top-level entry */
 		key.toplevel = false;
 		entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
 		if (entry)				/* found */

--=-=-=
Content-Type: text/plain


-- 
Regrads,
Japin Li.

--=-=-=--