public inbox for [email protected]
help / color / mirror / Atom feedFrom: Japin Li <[email protected]>
To: Andrey M. Borodin <[email protected]>
Cc: 邱宇航 <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Nikolay Samokhvalov <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: [email protected]
Subject: Re: Transaction timeout
Date: Mon, 18 Dec 2023 17:32:22 +0800
Message-ID: <MEYP282MB316457B6810B840A012649AFB690A@MEYP282MB3164.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <[email protected]>
References: <CAAhFRxiQsRs2Eq5kCo9nXE3HTugsAAJdSQSmxncivebAxdmBjQ@mail.gmail.com>
<CANNMO+LyVtwmYhzPX-A3G4EEi2OuD83zkyFndKD5gY8DWwdXaA@mail.gmail.com>
<CAAhFRxg7p+Z=xAFAdPeuLeOvc+3DyKKJtg8PKfdE453yybfHMQ@mail.gmail.com>
<[email protected]>
<CAAhFRxgP_w8ddYPJ3cJ4QZKQU7VWrH55MOYrxdceFBchDwuGrQ@mail.gmail.com>
<CAAhFRxg9i6DrHT1cALBNztsnJ7OR3cawfCmyFA=J6=oDFX+h2Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<SY8PR01MB9288C3D90276EB758E066694B68BA@SY8PR01MB9288.ausprd01.prod.outlook.com>
<[email protected]>
<SY8PR01MB9288F5CF03D38662BE59C628B68AA@SY8PR01MB9288.ausprd01.prod.outlook.com>
<[email protected]>
<SY8PR01MB9288335A3B81E8D6E121980FB68AA@SY8PR01MB9288.ausprd01.prod.outlook.com>
<[email protected]>
<ME3P282MB3166E33F193D2E7B0CDB633FB692A@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
<[email protected]>
On Mon, 18 Dec 2023 at 13:49, Andrey M. Borodin <[email protected]> wrote:
>> On 16 Dec 2023, at 05:58, Japin Li <[email protected]> wrote:
>>
>>
>> On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin <[email protected]> wrote:
>>>> On 8 Dec 2023, at 15:29, Japin Li <[email protected]> wrote:
>>>>
>>>> Thanks for updating the patch. LGTM.
>>>
>>> PFA v9. Changes:
>>> 1. Added tests for idle_in_transaction_timeout
>>> 2. Suppress statement_timeout if it’s shorter than transaction_timeout
>>>
>> + if (StatementTimeout > 0
>> + && IdleInTransactionSessionTimeout < TransactionTimeout)
>> ^
>>
>> Should be StatementTimeout?
> Yes, that’s an oversight. I’ve adjusted tests so they catch this problem.
>
>> Maybe we should add documentation to describe this behavior.
>
> I've added a paragraph about it to config.sgml, but I'm not sure about the comprehensiveness of the wording.
>
Thanks for updating the patch, no objections.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
view thread (61+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Transaction timeout
In-Reply-To: <MEYP282MB316457B6810B840A012649AFB690A@MEYP282MB3164.AUSP282.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox