public inbox for [email protected]  

help / color / mirror / Atom feed

From: Steven Niu <[email protected]>
To: Pg Hackers <[email protected]>
Subject: remove obsolete comment in AtEOXact_Inval
Date: Mon, 27 Oct 2025 02:43:51 +0000
Message-ID: <MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com> (raw)

Hi, Hackers,

When I read the code, I noticed there is one line of comment in function AtEOXact_Inval() which is obviously obsolete.

    "This should be called as the last step in processing a transaction"

AtEOXact_Inval() is called in CommitTransaction() and AbortTransaction() and there are many other steps after function AtEOXact_Inval() is called.
Such as:
      AtCommit_Notify();
      AtEOXact_GUC(true, 1);
      AtEOXact_SPI(true);
      AtEOXact_Enum();
      AtEOXact_on_commit_actions(true);
      AtEOXact_Namespace(true, is_parallel_worker);
      AtEOXact_SMgr();
      AtEOXact_Files(true);
      AtEOXact_ComboCid();
      AtEOXact_HashTables(true);
      AtEOXact_PgStat(true, is_parallel_worker);
      AtEOXact_Snapshot(true, false);
      AtEOXact_ApplyLauncher(true);
      AtEOXact_LogicalRepWorkers(true);

So that comment is no longer true. I made a patch to remove it as attached.

Best Regards,
Steven


Attachments:

  [application/octet-stream] 0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch (1.1K, 3-0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch)
  download | inline diff:
From c8c79a425b0db0407bddaafac61ab0475d442bf3 Mon Sep 17 00:00:00 2001
From: Steven Niu <[email protected]>
Date: Mon, 27 Oct 2025 10:18:56 +0800
Subject: [PATCH] remove obsolete comment in AtEOXact_Inval

There are many other steps after function AtEOXact_Inval() is called
in processing a transaction. So the comment of function AtEOXact_Inval()
"This should be called as the last step in processing a transaction."
is obsolete and should be deleted.

Author: Steven Niu <[email protected]>
---
 src/backend/utils/cache/inval.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/backend/utils/cache/inval.c b/src/backend/utils/cache/inval.c
index 02505c88b8e..e6a93229e6f 100644
--- a/src/backend/utils/cache/inval.c
+++ b/src/backend/utils/cache/inval.c
@@ -1191,9 +1191,6 @@ ProcessCommittedInvalidationMessages(SharedInvalidationMessage *msgs,
  * In any case, reset our state to empty.  We need not physically
  * free memory here, since TopTransactionContext is about to be emptied
  * anyway.
- *
- * Note:
- *		This should be called as the last step in processing a transaction.
  */
 void
 AtEOXact_Inval(bool isCommit)
-- 
2.43.0

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: remove obsolete comment in AtEOXact_Inval
  In-Reply-To: <MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox