From: "r.takahashi_2@fujitsu.com" <r.takahashi_2@fujitsu.com>
To: 'Fujii Masao' <masao.fujii@oss.nttdata.com>, Kyotaro Horiguchi
	<horikyota.ntt@gmail.com>
CC: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: RE: Support escape sequence for cluster_name in
 postgres_fdw.application_name
Thread-Topic: Support escape sequence for cluster_name in
 postgres_fdw.application_name
Thread-Index: AQHYEbmV/Yi9fGCaFk68+aHPL9A/Kqx2h00AgAAl/ICAAThk8A==
Date: Fri, 28 Jan 2022 05:07:28 +0000
Message-ID:
 <OS0PR01MB5682DB788FD7EAD3BDBC36F182229@OS0PR01MB5682.jpnprd01.prod.outlook.com>
References: <1041dc9a-c976-049f-9f14-e7d94c29c4b2@oss.nttdata.com>
 <20220127.171042.1194024926941192601.horikyota.ntt@gmail.com>
 <b4cb3b76-903f-50fe-7dc2-b37d851e7b56@oss.nttdata.com>
In-Reply-To: <b4cb3b76-903f-50fe-7dc2-b37d851e7b56@oss.nttdata.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2022-01-28T05:04:44Z;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=15570edf-d325-4a96-a2a9-2b91857cfb3d;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=fujitsu.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5e2aad8c-5a15-45b3-4161-08d9e21c148f
x-ms-traffictypediagnostic: OSAPR01MB4307:EE_
x-microsoft-antispam-prvs:
 <OSAPR01MB4307FBAAB116D67687F63F5C82229@OSAPR01MB4307.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 TSwiMrdnJK9CQMhjxLq0XzHdpHWVduRzYwMrS09SfsuwNg1vxlOMk6GquEeGtULsfjr/3nonftuz79PdLoWKo+SYjDkUwCesRzIx+UOq0rMeqU0okkNjOpLlntzxCC0S3l7KXUK1iZPOxVUFZ8lgWmAmQ7HkIICNPBRH4zsEWy1ugSabUQ8zciTRrEdKQHI68oA/gIsBkHFNah01XODYmnAu+2cot4LrGWfxRzq8GFw2Y8KboRN+Q8/6AWUJkfX2VWWelxKZFQpCNYVjACiFQa+Sns2rrBtsBMnx0te6Mxn0atbXQrx32FT6KQCpahupobizHB0S1eRaKDxWpAlV+Bpkh02WzQV7y32CgvZBqO3e9B0kiTSqwZYpvq4Ov23HfsVO9+UOU/O4zRtTCoC3k1+j7kPlZxu67NfHnOoOH1Dq+BF4vbmw8mrNy1vC7KdUdrfAXA3vP6mjpPDNRI2a4857WMbl1Lc97lXjAbI6NKreGCWhYX2mpXbYcgS0/WFXy+vxkYsvTk2j3LEw6IAXDmIrjgUE3cQBkupcWWcaJVxyfuXPFfm7VfH0Mqt8gl48SZe9jRd5OFwZrtm7ytbTvvDVy0a/kqb4GwXkJBdU2U3tCFt/7GaBqYgBWEc2SEQ6/tXto4mmN487zLMylsjSZCjn5LMnFMR/Ls8uSQdRLrL3WiduvDfW/R1w7qVlFoXPGd5efiL2NhDycPoAeicbzg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS0PR01MB5682.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(38070700005)(76116006)(4326008)(5660300002)(66476007)(4744005)(8936002)(86362001)(508600001)(52536014)(33656002)(316002)(64756008)(38100700002)(110136005)(66556008)(82960400001)(66446008)(66946007)(2906002)(71200400001)(122000001)(85182001)(8676002)(186003)(9686003)(26005)(6506007)(7696005)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-2022-jp?B?U2hhT3FFakQvdG1hRmF6ZDRtUFNnT1ZqYmtBL2JNdUVpVWlvTkVSNlZS?=
 =?iso-2022-jp?B?dkdxZUtBd1U3VTRlV3NER0ZkeDJpMzBjblVidlFVUm9jZlZOYTNPRDU0?=
 =?iso-2022-jp?B?Qlg5cCtoRUlZS3BtM3ZnVmozQVdrdkdDamtTZjQvNVBqdmZZQ01IejF6?=
 =?iso-2022-jp?B?aFE4bGFvU3JhKzN2eW5vZFNOWnU5K3VMdDRnOUlMNUViemY3YnlVL0pm?=
 =?iso-2022-jp?B?WlJOV2R6bVdYVUpjUExWYVFURGtXOU10Z3VKR3lHVXM2aTFNaUQvZHF6?=
 =?iso-2022-jp?B?a1VNUXhFU08wT3h6MStUN1dQWWxZdG1FaUdqaTVIdU5TZjQwWGkyeDhx?=
 =?iso-2022-jp?B?UVdpT3l1bWFDYXluL1lNRHEyVHVXSEZOdWgzM3NSdFlRZ3VTa3BIQTI3?=
 =?iso-2022-jp?B?aWY2MWZzZkhuSitYTy9sVFZaYlZ5MksyVEpvaEZHbmw3MEpONHQ5dmFD?=
 =?iso-2022-jp?B?aWgzQ1VyVHQwOTJKT2RNQ09aMVFkYjRYdmxMTmhNVUxnSW0wUTFEdjNS?=
 =?iso-2022-jp?B?eEdCTEtjbnhrNys5YlVMOGNPUWF6WmhNSk1jTnNiS1JoSTRhVzEvWUF2?=
 =?iso-2022-jp?B?VUpvQnFnN0JKNEQ2ZGtwTjFTaVYvWFZxM2I0YkNhbTZjek5XaFNQT1Rl?=
 =?iso-2022-jp?B?S3R5VjJQa1B6Rlk3ZW9DcVZ1T0wwRnN6WVJsMm50NEdFdlMvK2pGWnVG?=
 =?iso-2022-jp?B?cWEwNVRvN0FXckxlWmVNbzNhQnFPRE44Z0ZucDc1eEpQK2FvcUhsa3Ix?=
 =?iso-2022-jp?B?VzJUZnV5cld4ZkZVa1BPZjFaUS9XUXJUeTZSNUVDUVV6RllSS3QyVm5O?=
 =?iso-2022-jp?B?d1pKTlUrVzhPVkxOa3Z0alA4NEFxMUdTQnFBRkJ4OGhMQ3J4R3pVYmk0?=
 =?iso-2022-jp?B?M1h4WmM5ZFc1UkRnVkhmRlZqSUNGVHl5d0ZMQXJTeGpWdC9IUWVYTzlY?=
 =?iso-2022-jp?B?eXRSdlV6WEllaWwreTZXaVZqTnpFd2NNQTArNVdweVJpWUNYanlzZjNX?=
 =?iso-2022-jp?B?L0k0R29abEh5U2wrSmwzRUwrYlJlQjFRWEdyOS84ZkJnM0JSNXFyUmEv?=
 =?iso-2022-jp?B?OGNsc1BpVWM1bGl6RXdJR2kwaUd0NmQ4OFNnaGtPelM2Q1Exc2tsdlZZ?=
 =?iso-2022-jp?B?T3haUnVtUEVuZzBNVDB0SlFENGlDblFQN2Z6cnQzbzFYYzljc2FSM3hJ?=
 =?iso-2022-jp?B?bkJJbDVUWXd1MStPdktGak9pZXlRZkNYd2lLMkYvMlZFcThDWGdnQncw?=
 =?iso-2022-jp?B?dEdWVVEvT2EzVGpFYnB6RGNWM2wxeTBkakNVaUxmY0thVXBZVVF2RWxZ?=
 =?iso-2022-jp?B?RFRXTjlxWWY2SnJNa0dSN2tSOG10NS9LdnpkK3FZRGpDd3dsbXJNQnBN?=
 =?iso-2022-jp?B?cFFoRWs1bTZhRjBHK3hTaHluWVZtZm9RMlNNVDM0azZ6R044aERNOEI0?=
 =?iso-2022-jp?B?djB2V1IrMHVwcnhBQTJaZW9ISXVxYVdrdWUydFE0ZEwvNDV2OG1VTmJa?=
 =?iso-2022-jp?B?UE9Ec002SWVGWVE2cHFRVFpaajh0Y1I0Wi83YXcvT21VdWo0MmorVjFW?=
 =?iso-2022-jp?B?WEFsY05oYlRYdnVGRlM2YWNlblhBNlYyOTZIN29uY1pYczI5N0VyclVS?=
 =?iso-2022-jp?B?bmh5T21USnVkaWRMbjJLWHBiNFlzZE52TzNyRFNxbUVZdmFRVnZhcS9Y?=
 =?iso-2022-jp?B?TnB6SHA0cldLWjB6a3VYNTl1aXlOQnpSeHJzMTdZd3dWdHhVQkxpS0hN?=
 =?iso-2022-jp?B?aEFsSU90Q1VDdjBETlBXK0ZKL2tiQ3o2bDN4Wkw0RzhVTVlEYm5RQXl4?=
 =?iso-2022-jp?B?ZmorM2JYNDd6ZG9pdS83NW1oK0Rva0NYNjBBYk9GTVovNG5Iak5lelhp?=
 =?iso-2022-jp?B?Z1E3QXpOajh0ZlM5UHlaZVF0eUFmbmVCN2JWTUJxWXlnbERFTVVMWEdj?=
 =?iso-2022-jp?B?U0lCVWE0NWJjVi9maVNnc1dqNlNwN0NWVlE3dkErdXpMTmI0a0lRUkJq?=
 =?iso-2022-jp?B?NlpTQTB2bjV1TjlTT0I0RDlTSkx0STg2amIvZWJLZmtmV2FXRUFHOGg0?=
 =?iso-2022-jp?B?M3BvTWFVTk53bWxWVHRvMEVzZTNGbUo3Zi9ENjlHaTVaNlhuTFNiVG1o?=
 =?iso-2022-jp?B?dFVsYjZHOFh2VThyc08wOWdqcWwybjVwN0o0QjNuSk9xSFZmdUZwN3Vm?=
 =?iso-2022-jp?B?VitBMDZpbTVSNDErYU1kUnh0clhkcnpGZUliOFpVUjc5L2xRY24vZHhk?=
 =?iso-2022-jp?B?ZlV4d1dYUTcraGNyT29XNGpoUGVyK3pMOEN6ckE4cDdFczVsZWdYYkgx?=
 =?iso-2022-jp?B?MkhUZ3l4S1JmdzMyU2tXcVd0Y2VsRm9sWXdkeVJTVzNCSk5lTFdqd1pt?=
 =?iso-2022-jp?B?WGdRV0VPRGRaeVJQRDJRNGg5cnpGcHp4ZVFsSDRHd1k3U0xHdmJhWnlY?=
 =?iso-2022-jp?B?TXE4OFpBPT0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5682.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2aad8c-5a15-45b3-4161-08d9e21c148f
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 05:07:28.0749
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 64oH1dCnc+24v41LqnTa4RW2Cn6Ihrdx9RxDBNBoV4wOntUg2vGlNi2GL+BgNttp/BaNL39uQVZaVHS9HHUeAZ0fhDMDdN34MZVO0AKvaqc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB4307
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/OS0PR01MB5682DB788FD7EAD3BDBC36F182229%40OS0PR01MB5682.jpnprd01.prod.outlook.com>
Precedence: bulk

Hi,


Thank you for developing this feature.
I think adding escape sequence for cluster_name is useful too.

> Is the reason for 'C' in upper-case to avoid possible conflict with
> 'c' of log_line_prefix?  I'm not sure that preventive measure is worth
> doing.  Looking the escape-sequence spec alone, it seems to me rather
> strange that an upper-case letter is used in spite of its lower-case
> is not used yet.

I think %c of log_line_prefix (Session ID) is also useful for postgres_fdw.=
application_name.
Therefore, how about adding both %c (Session ID) and %C (cluster_name)?


Regards,
Ryohei Takahashi